Jira (PDB-5141) Fix issue with lock_timeout format during partition drop

2021-05-28 Thread Zachary Kent (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Zachary Kent updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5141  
 
 
  Fix issue with lock_timeout format during partition drop   
 

  
 
 
 
 

 
Change By: 
 Zachary Kent  
 

  
 
 
 
 

 
 tbd The `show lock_timeout` query we do [here|https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/scf/storage.clj#L1634-L1635] to grab any existing system lock_timeout returns a result that isn't formatted properly for Long/parseLong. We need to fix this query so that it doesn't throw if there is a system lock_timeout already set.To reproduce with a local PDB:{code:java}in psql: alter role pdb_test set lock_timeout=300;run: lein test :only puppetlabs.puppetdb.cli.services-test/regular-gc-drops-oldest-partitions-incrementally{code}This will cause the test to fail with:{code:java}21349 [pool-3-thread-3] ERROR puppetlabs.puppetdb.cli.services - Error while sweeping reports and resource eventsjava.lang.NumberFormatException: For input string: "300ms" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.base/java.lang.Long.parseLong(Long.java:692) at java.base/java.lang.Long.parseLong(Long.java:817) at puppetlabs.puppetdb.scf.storage$prune_daily_partitions.invokeStatic(storage.clj:1571)...{code}If there is a lock_timeout set for postgres or for the puppetdb/pe-puppetdb role it will cause partition GC to fail and cause partitions to build up until PDB is restarted or the lock_timeout is reset. If there isn't a lock_timeout set the query returns 0 which isn't a problem for Long/parseLong.As a workaround resetting the lock_timeout should allow partition GC to succeed. For example:{code:java} alter role "pe-puppetdb" reset lock_timeout;{code}Will reset the lock_timeout on the pe-puppetdb role and should resolve the error seen above. Partition drops are still protected by a (5min default) lock_timeout which is defaulted and set via an env var [here|https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/scf/storage.clj#L1584-L1586].  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 
 

Jira (PUP-9570) Catalog failure on first run due to pluginsync and environment switch

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9570  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Catalog failure on first run due to pluginsync and environment switch   
 

  
 
 
 
 

 
 I am able to reproduce the issue as follows:  
 
 
 
 
 ~/work/puppet retry_pluginsync_9570*  
 
 
 ❯ tree ~/.puppetlabs/etc/code
 
 
 /home/josh/.puppetlabs/etc/code  
 
 
 └── environments  
 
 
 ├── dev  
 
 
 │   ├── manifests  
 
 
 │   │   └── site.pp  
 
 
 │   └── modules  
 
 
 │   └── only  
 
 
 │   └── lib  
 
 
 │   └── facter  
 
 
 │   └── onlyindev.rb  
 
 
 └── production  
 
 
    
   

Jira (FACT-3048) Incorrect usage of ffi_lib on Windows

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Josh Cooper  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3048  
 
 
  Incorrect usage of ffi_lib on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Josh Cooper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.401085.1622153865000.43665.1622154240460%40Atlassian.JIRA.


Jira (PUP-11075) Pip provider on Windows does not work correclty with wheel files

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11075  
 
 
  Pip provider on Windows does not work correclty with wheel files   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Affects Version/s: 
 PUP 7.6.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400759.1622023814000.43754.1622157900028%40Atlassian.JIRA.


Jira (FACT-3048) Incorrect usage of ffi_lib on Windows

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3048  
 
 
  Incorrect usage of ffi_lib on Windows   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/05/27 3:17 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 We shouldn't pass CURRENT_PROCESS in the call to:  
 
 
 
 
   ffi_lib [FFI::CURRENT_PROCESS, :ntdll]
  
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  

Jira (PUP-11032) Pluginsync Improvements

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11032  
 
 
  Pluginsync Improvements   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 This epic contains work to make pluginsync more efficient and sync more things (primarily puppet types) to the agent. Pluginsync naively downloads individual files, which doesn't scale as the number of files increases. Each file content request competes for JRuby instances affecting compilation. In addition, data types and type aliases are not downloaded to the agent, which is barrier to adopting deferred functions.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.397460.161963485.42660.1622056860034%40Atlassian.JIRA.


Jira (PUP-11075) Pip provider on Windows does not work correclty with wheel files

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper moved an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11075  
 
 
  Pip provider on Windows does not work correclty with wheel files   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Component/s: 
 Windows  
 
 
Component/s: 
 Windows  
 
 
Key: 
 PA PUP - 3758 11075  
 
 
Affects Version/s: 
 puppet-agent 7.6.0  
 
 
Project: 
 Puppet  Agent  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to

Jira (PDB-5141) Fix issue with lock_timeout format during partition drop

2021-05-28 Thread Rob Browning (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5141  
 
 
  Fix issue with lock_timeout format during partition drop   
 

  
 
 
 
 

 
Change By: 
 Rob Browning  
 
 
Sprint: 
 HA 2021-06-02  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400985.162207298.43403.1622140800025%40Atlassian.JIRA.


Jira (PUP-11072) purge_ssh_keys does not work if the key file is not owned by the user

2021-05-28 Thread Martin Alfke (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Alfke commented on  PUP-11072  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: purge_ssh_keys does not work if the key file is not owned by the user   
 

  
 
 
 
 

 
 The hardening requirements comes from CSC 14: 14.4 and 14.6 https://www.venafi.com/sites/default/files/2016-10/Venafi_Securing_SSH_CSCs_final.pdf Prevent non-superusers from installing new authorized keys for user accounts. Restrict access on identity keys to interactive use, automated process or named admin staff responsible for managing keys. Allow only authorized administrators to modify authorized keys.
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400814.1622037183000.42076.1622040120023%40Atlassian.JIRA.


Jira (PDB-5141) Fix issue with lock_timeout format during partition drop

2021-05-28 Thread Rob Browning (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning assigned an issue to Rob Browning  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5141  
 
 
  Fix issue with lock_timeout format during partition drop   
 

  
 
 
 
 

 
Change By: 
 Rob Browning  
 
 
Assignee: 
 Rob Browning  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400985.162207298.43401.1622140740076%40Atlassian.JIRA.


Jira (PDB-5141) Fix issue with lock_timeout format during partition drop

2021-05-28 Thread Rob Browning (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5141  
 
 
  Fix issue with lock_timeout format during partition drop   
 

  
 
 
 
 

 
Change By: 
 Rob Browning  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400985.162207298.43402.1622140740125%40Atlassian.JIRA.


Jira (PUP-10539) Agent Environment Convergence

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10539  
 
 
  Agent Environment Convergence   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 This epic contains tickets for improving how There are architectural issues with  the  way the  agent  converges on  and server negotiate  which environment to use :* Newly provisioned agent runs will fail if pluginsync occurs in production, but catalog compilation occurs in a different environment, and the manifest references a fact that doesn't exist in production* Each agent run results in two node requests, and corresponding classifier requests .  Facts are not sent with the first node request, so the classifier terminus retrieve last-known facts from puppetdb. Finally, the first node request returns all of the last-known facts back to the agent (since facts are merged into node parameters).* If the first node request fails or times out due to server load, then the agent will switch back to "production", deleting all its plugins. This leads to a positive feedback loop as agents then download all plugins again, one file at a time.* If the agent is configured to use an environment  in puppet.conf, and the environment is deleted on the server, then the agent will never successfully run again until the setting is removed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 

Jira (PDB-5141) Fix issue with lock_timeout format during partition drop

2021-05-28 Thread Zachary Kent (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Zachary Kent created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5141  
 
 
  Fix issue with lock_timeout format during partition drop   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/05/26 4:49 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Zachary Kent  
 

  
 
 
 
 

 
 tbd  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

Jira (PUP-11052) Trusted fact based lookups

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11052  
 
 
  Trusted fact based lookups   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 We encourage users to classify nodes based on trusted facts, such as what role to assign a node. However, it's not possible to simulate that when running "puppet lookup".  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.397996.1620065058000.42648.1622056260217%40Atlassian.JIRA.


Jira (PUP-8257) Puppet::FileSystem::Windows should support LFN

2021-05-28 Thread GeorgesZ (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 GeorgesZ commented on  PUP-8257  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet::FileSystem::Windows should support LFN   
 

  
 
 
 
 

 
 It should also work if long path have been enabled. See [Enable Long Paths in Windows 10, Version 1607, and Later 
 

 
 
https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later]. For example, the purge attribute of the file resource fails when it tries to remove entries with a path longer than 260 characters with an error like this   
 
 
 
 
 Err: No such file or directory @  - C:/  
 
 
 
    
 

 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
  

Jira (FACT-3045) facter4 performance regression from facter3

2021-05-28 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3045  
 
 
  facter4 performance regression from facter3   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Team: 
 Night's Watch  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400063.1621546219000.43868.1622195040040%40Atlassian.JIRA.


Jira (PUP-11072) purge_ssh_keys does not work if the key file is not owned by the user

2021-05-28 Thread Martin Alfke (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Alfke updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11072  
 
 
  purge_ssh_keys does not work if the key file is not owned by the user   
 

  
 
 
 
 

 
Change By: 
 Martin Alfke  
 

  
 
 
 
 

 
 *Puppet Version:* any *Puppet Server Version:* unrelated *OS Name/Version:* any Linux system using SSHIn a secured environment ssh keys may not be in users home, but must be located in root context (e.g. /etc/ssh/keys/Besides this it is forbidden for a user to add a new key or remove  an old  a  key. Therefor the key files must be owned by root user using 0644 as access mode.When using purge_ssh_keys => ["/etc/ssh/keys/${user}"]  within  the  user resource, the  removal of ssh keys fails, as Puppet wants to delete the key using user privileges.Reason is a hard-coded setting in puppet type:{code:java}  # lib/puppet/type/user.rb line 785 and following:def find_unmanaged_keys  self[:purge_ssh_keys].select { |f| File.readable?(f) }.map { |f| unknown_keys_in_file(f) }.flatten.each do |res|  res[:ensure] = :absent  res[:user] = self[:name]  # <-- !  @parameters.each do |name, param|res[name] = param.value if param.metaparam?  endendend{code}*Desired Behavior:*Any unmanaged key gets removed.*Actual Behavior:*Puppet throws an error, that it can not change the file.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 
  

Jira (PUP-11072) purge_ssh_keys does not work if the key file is not owned by the user

2021-05-28 Thread Martin Alfke (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Alfke updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11072  
 
 
  purge_ssh_keys does not work if the key file is not owned by the user   
 

  
 
 
 
 

 
Change By: 
 Martin Alfke  
 
 
Summary: 
 purge_ssh_keys does not work if the key  file  is not owned by the user  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400814.1622037183000.42072.1622039280031%40Atlassian.JIRA.


Jira (FACT-3046) Facter 4 CLI does not accept concatenated short flags

2021-05-28 Thread Ciprian Badescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3046  
 
 
  Facter 4 CLI does not accept concatenated short flags   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Story Points: 
 5  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400395.1621841877000.43002.1622102340030%40Atlassian.JIRA.


Jira (PUP-11073) Reduce Memory Usage

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11073  
 
 
  Reduce Memory Usage   
 

  
 
 
 
 

 
Issue Type: 
  Epic  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/05/26 1:14 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 Puppet was written before frozen string literals were added in Ruby 2.3, so by default puppet creates many transient string objects during compilation, which must be garbage collected. We can't simply switch all source files over to using frozen_string_literal: true because we sometimes create a string in one module/class/file, and the string is mutated somewhere unrelated. So we have to be selective about adding the pragma or calling String#freeze. The following are prime candidates:  
 
 
 
 
 lib/puppet/concurrent/thread_local_singleton.rb  
 
 
 lib/puppet/parser/scope.rb  
 
 
 lib/puppet/parser/templatewrapper.rb  
 
 
 lib/puppet/pops/model/factory.rb  
 
 
 lib/puppet/pops/model/ast.rb  
 
 
  

Jira (PDB-5142) Restart pdb service or fix the delete-reports task

2021-05-28 Thread Margaret Lee (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Margaret Lee created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5142  
 
 
  Restart pdb service or fix the delete-reports task   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/05/27 2:48 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Margaret Lee  
 

  
 
 
 
 

 
 DOC-4632 brought to light that customers expect PDB to start up again after the delete-reports script. Melissa is adding a step to the upgrade docs to call this out. We should explore add this as a step to the script so customers do not miss this step and forget to restart.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

Jira (PDB-5140) Adding Azure PostgreSQL as backend for puppetDB fails

2021-05-28 Thread Samantha (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Samantha created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5140  
 
 
  Adding Azure PostgreSQL as backend for puppetDB fails   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 PDB 7.3.1  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 PuppetDB  
 
 
Created: 
 2021/05/26 11:58 AM  
 
 
Environment: 
 Ubuntu 18.04   
 
 
Priority: 
  Major  
 
 
Reporter: 
 Samantha  
 

  
 
 
 
 

 
 I created an Azure PosgtresSQL server that has appropriate firewall rules to connect to, created a database named puppet, created user named puppet and gave it all privilege on the puppet database. Now I try to point puppetdb to it and start puppetDB and it fails In my database.ini file I have : [database] subname = //hostname.postgres.database.azure.com:5432/puppet username = puppet password = mypassword connection-username = puppet@hostname   When I do sudo systemctl start puppetdb it fails  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
  

Jira (FACT-3044) Add --version to --help output

2021-05-28 Thread Ciprian Badescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3044  
 
 
  Add --version to --help output   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Sprint: 
 NW-2021-06- 16 02  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400018.1621535586000.42999.1622101500030%40Atlassian.JIRA.


Jira (PDB-4386) Improve performance of catalog inserts/updates (by using an UPSERT)

2021-05-28 Thread Nick Walker (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nick Walker commented on  PDB-4386  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Improve performance of catalog inserts/updates (by using an UPSERT)
 

  
 
 
 
 

 
 I'm a little skeptical of the reasoning here. However, even if we don't go with a full UPSERT it appears that we are updating, deleting, and maybe inserting a single row at a time instead of doing them as a single operation.  It seems like at a minimum we could fetch all the records, do an UPSERT as one operation for insert and update ( instead of one operation per row that needs to be updated or inserted ), and then a delete as a single operation.  I suspect it would still be better to write a single temp table that represents the new catalog and then an UPSERT followed by a delete but even without that I think removing all of the single row inserts and updates would be a boost.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.310840.155925674.42521.1622051100051%40Atlassian.JIRA.


Jira (PUP-10892) Update Public-facing Puppet docs to include Fedora 34 x86_64

2021-05-28 Thread Ciprian Badescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10892  
 
 
  Update Public-facing Puppet docs to include Fedora 34 x86_64   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Labels: 
 DOCS  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386584.1612776588000.42992.1622101020189%40Atlassian.JIRA.


Jira (PUP-10892) Update Public-facing Puppet docs to include Fedora 34 x86_64

2021-05-28 Thread Ciprian Badescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10892  
 
 
  Update Public-facing Puppet docs to include Fedora 34 x86_64   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Sprint: 
 ready for triage  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386584.1612776588000.42994.1622101080100%40Atlassian.JIRA.


Jira (PUP-10892) Update Public-facing Puppet docs to include Fedora 34 x86_64

2021-05-28 Thread Ciprian Badescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10892  
 
 
  Update Public-facing Puppet docs to include Fedora 34 x86_64   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Sprint: 
 NW-2021-06-02  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386584.1612776588000.42993.1622101080052%40Atlassian.JIRA.


Jira (PUP-11074) Add catalog edge only if parent resource has a container

2021-05-28 Thread Gabriel Nagy (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gabriel Nagy created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11074  
 
 
  Add catalog edge only if parent resource has a container   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/05/27 7:33 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Gabriel Nagy  
 

  
 
 
 
 

 
 Puppet Version: 7.7.0/6.23.0 Puppet Server Version: n/a OS Name/Version: n/a Managing resources with generators behaves differently with puppet resource and puppet apply. When running with puppet apply, the parent resource is always contained by something like Class[Main], so adding an edge between that and our generated resource works. When running with puppet resource, the parent resource is not contained by anything (container_of(parent_resource) returns nil), which adds an edge with a nil vertex to the catalog. This in turn causes the run to fail with a NilClass exception when performing pre-run checks in the Transaction class, as the catalog now contains a nil vertex. Desired Behavior: Running the following does not error:  
 
 
 
 
 > touch /tmp/asd  
 
 
 > puppet resource tidy /tmp/asd age=0 --trace
  
 
 
 
  Actual Behavior: Running the above example gives the following error:  
 
 
 
 
   

Jira (PUP-11072) purge_ssh_keys does not work if the key is not owned by the user

2021-05-28 Thread Martin Alfke (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Alfke updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11072  
 
 
  purge_ssh_keys does not work if the key is not owned by the user   
 

  
 
 
 
 

 
Change By: 
 Martin Alfke  
 
 
Summary: 
 purge_ssh_keys does not work if the key is  not  owned by  root  the user  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400814.1622037183000.42065.1622037660029%40Atlassian.JIRA.


Jira (FACT-3048) Incorrect usage of ffi_lib on Windows

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3048  
 
 
  Incorrect usage of ffi_lib on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.401085.1622153865000.43684.1622155020051%40Atlassian.JIRA.


Jira (PUP-11072) purge_ssh_keys does not work if the key file is not owned by the user

2021-05-28 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11072  
 
 
  purge_ssh_keys does not work if the key file is not owned by the user   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Labels: 
 community  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400814.1622037183000.42971.1622096160037%40Atlassian.JIRA.


Jira (FACT-3046) Facter 4 CLI does not accept concatenated short flags

2021-05-28 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3046  
 
 
  Facter 4 CLI does not accept concatenated short flags   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Labels: 
 jira_escalated  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400395.1621841877000.41897.1622016480050%40Atlassian.JIRA.


Jira (FACT-3048) Incorrect usage of ffi_lib on Windows

2021-05-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3048  
 
 
  Incorrect usage of ffi_lib on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Platform Core KANBAN  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.401085.1622153865000.43685.1622155020100%40Atlassian.JIRA.


Jira (FACT-3045) facter4 performance regression from facter3

2021-05-28 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3045  
 
 
  facter4 performance regression from facter3   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Labels: 
 community  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.400063.1621546219000.41898.1622016480108%40Atlassian.JIRA.


Jira (PUP-11072) purge_ssh_keys does not work if the key is owned by root

2021-05-28 Thread Martin Alfke (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Alfke created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11072  
 
 
  purge_ssh_keys does not work if the key is owned by root   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/05/26 6:53 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Martin Alfke  
 

  
 
 
 
 

 
 Puppet Version: any Puppet Server Version: unrelated OS Name/Version: any Linux system using SSH In a secured environment ssh keys may not be in users home, but must be located in root context (e.g. /etc/ssh/keys/ Besides this it is forbidden for a user to add a new key or remove an old key. Therefor the key files must be owned by root user using 0644 as access mode. When using purge_ssh_keys => ["/etc/ssh/keys/${user}"] the removal of ssh keys fails, as Puppet wants to delete the key using user privileges. Reason is a hard-coded setting in puppet type:  
 
 
 
 
 # lib/puppet/type/user.rb line 785 and following:  
 
 
 def find_unmanaged_keys  
 
 
   self[:purge_ssh_keys].  
 
 
 select { |f| File.readable?(f) }.  
 
 
 map { |f| unknown_keys_in_file(f) }.  
  

Jira (PDB-4871) Investigate queries using two Hikari connections per request

2021-05-28 Thread Austin Blatt (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Austin Blatt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-4871  
 
 
  Investigate queries using two Hikari connections per request   
 

  
 
 
 
 

 
Change By: 
 Austin Blatt  
 
 
Fix Version/s: 
 PDB 6.14.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370205.1598390523000.42666.1622058060031%40Atlassian.JIRA.