Jira (PUP-9561) puppet language functions are 11,350x slower than ruby functions
Title: Message Title
Josh Cooper commented on PUP-9561
Re: puppet language functions are 11,350x slower than ruby functions
Actually the type inference is much worse than I expected. Here are 3 manifests, using reduce, merge and merge2 which is the same as merge except the memo isn't passed to the block.
❯ cat reduce.pp
$test = generate('/bin/sh', '-c', 'seq 1 4000').split("\n")
$result = $test.reduce({}) |$memo,$value| { $memo + { "key $value" => "foo" } }
❯ cat merge.pp
$test = generate('/bin/sh', '-c', 'seq 1 4000').split("\n")
$result = merge($test) |$memo,$value| { { "key $value" => "foo" } }
❯ cat merge2.pp
$test = generate('/bin/sh', '-c', 'seq 1 4000').split("\n")
$result = merge($test) |$value| { { "key $value" => "foo" } }
Using puppet#3828aabe8d32368faa5cdc1a428189d0cb117e52, I get:
Jira (PUP-11163) Prevent thundering herd via deterministic run scheduling
Title: Message Title Reid Vandewiele commented on PUP-11163 Re: Prevent thundering herd via deterministic run scheduling Possibly. There are definitely similarities. If there's any difference, I think it would be that this ticket is more "smooth workload distribution is something I want; thundering herds shouldn't be possible", while 4212 may have taking the slightly different focus of "fix the acute problem / symptom thundering herds by breaking them up when they occur". The tighter you get to workload tolerances at scale, the less tolerable it is to have herds in the first place. Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.406175.1625677218000.141554.1632864180023%40Atlassian.JIRA.
Jira (PUP-11163) Prevent thundering herd via deterministic run scheduling
Title: Message Title Nick Walker commented on PUP-11163 Re: Prevent thundering herd via deterministic run scheduling I think this is basically the same request I made in the past via PUP-4212. Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.406175.1625677218000.141553.1632863520038%40Atlassian.JIRA.
Jira (PUP-9561) puppet language functions are 11,350x slower than ruby functions
Title: Message Title
Josh Cooper commented on PUP-9561
Re: puppet language functions are 11,350x slower than ruby functions
Bartosz Blizniak When using the merge function, the block just needs to return the value for that iteration, so you'll want to do:
$test = generate('/bin/seq', '1', '4000').split("\n")
$result = $test.merge |$memo,$value| { { "key $value" => "foo" } }
That said, it is still slow due to the amount of time puppet spends inferring the data type of the unused $memo parameter. I think there's a simple fix to the merge function for the typical case where the $memo is not needed/wanted:
$result = $test.merge |$value| { { "key $value" => "foo" } }
Doing that drops the time to merge 4000 elements from 13.2 sec to 3.8 sec:
❯ time bx puppet apply merge.pp
Notice: Compiled catalog for localhost in environment production in 9.48 seconds
Notice: Applied catalog in 0.01 seconds
bundle exec puppet apply merge.pp 12.90s user 0.24s system 99% cpu 13.244 total
Jira (PUP-11265) puppet-agent : Concat not respecting environments
Title: Message Title Josh Cooper commented on PUP-11265 Re: puppet-agent : Concat not respecting environments Merged to 6.x in https://github.com/puppetlabs/puppet/commit/5e9536c0ce1b31eb6c3740620c49cef33a9ab2b5 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413595.1630046552000.141110.1632846660032%40Atlassian.JIRA.
Jira (FACT-1902) Facter 3 should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Austin Boyd updated an issue Facter / FACT-1902 Facter 3 should validate that external/custom/executable facts output proper UTF-8 Change By: Austin Boyd Zendesk Ticket Count: 1 2 Zendesk Ticket IDs: 45908 ,45956 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290197.1546471789000.140984.1632843420038%40Atlassian.JIRA.
Jira (FACT-1902) Facter 3 should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Austin Boyd updated an issue Facter / FACT-1902 Facter 3 should validate that external/custom/executable facts output proper UTF-8 Change By: Austin Boyd Zendesk Ticket Count: 1 Zendesk Ticket IDs: 45908 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290197.1546471789000.140980.1632842820044%40Atlassian.JIRA.
Jira (FACT-1902) Facter 3 should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Austin Boyd updated an issue Facter / FACT-1902 Facter 3 should validate that external/custom/executable facts output proper UTF-8 Change By: Austin Boyd Labels: custom-facts jira_escalated utf-8 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290197.1546471789000.140978.1632842640099%40Atlassian.JIRA.
Jira (FACT-3076) Custom facts cannot reference external facts
Title: Message Title
Robert Berry created an issue
Facter / FACT-3076
Custom facts cannot reference external facts
Issue Type:
Bug
Affects Versions:
FACT 3.14.1
Assignee:
Unassigned
Components:
Facter 3
Created:
2021/09/28 5:24 AM
Priority:
Normal
Reporter:
Robert Berry
https://puppet.com/docs/puppet/6/external_facts.html says > Due to parse order, you can reference an external fact from a Ruby fact. But this does not seem to work: $ cat external/ext.yaml — shouting: 'HELLO' $ cat custom/cust.rb Facter.add('not_shouting') do setcode do Facter.value('shouting').downcase() end end $ facter --external-dir external shouting HELLO $ facter --external-dir external --custom-dir custom not_shouting 2021-09-28 05:08:08.686159 ERROR puppetlabs.facter - error while resolving custom fact "not_shouting": undefined method `downcase' for nil:NilClass The custom fact is loaded before external facts, and cannot resolve it: $ facter --debug --external-dir external --custom-dir custom not_shouting 2021-09-28 05:08:14.428428 INFO puppetlabs.facter - executed with command line: --debug --external-dir external --custom-dir custom not_shouting. 2021-09-28 05:08:14.428594 DEBUG leatherman.ruby:513 - ruby was found at "/usr/bin/ruby". 2021-09-28 05:08:14.428740 DEBUG leatherman.execution:93 - executing command: /usr/bin/ruby -e print(['libdir', 'archlibdir', 'sitearchlibdir', 'bindir'].find do |name|dir = RbConfig::CONFIG[name];next unless dir;file = File.join(dir, RbConfig::CONFIG['LIBRUBY_SO']);break file if File.exist? file;false end) 2021-09-28 05:08:14.498854 DEBUG | - /usr/lib/x86_64-linux-gnu/libruby-2.7.so.2.7.4 2021-09-28 05:08:14.499154 DEBUG leatherman.execution:610 - process exited with status code 0. 2021-09-28 05:08:14.501242 INFO leatherman.ruby:139 - ruby loaded from
Jira (PUP-9561) puppet language functions are 11,350x slower than ruby functions
Title: Message Title
Bartosz Blizniak commented on PUP-9561
Re: puppet language functions are 11,350x slower than ruby functions
Hi, we are currently seeing some performance issues with the "reduce" function performance and "merge". A customer provided sample code:
$test = generate('/bin/seq', '1', '2000').split("\n") $result = $test.reduce({}) |$memo,$value| { $memo + { "key $value" => "foo" } }
This took around 3 seconds. Increasing the generate line to 4000 will increase the runtime to 12 seconds which is more than double. Is this something that we can improve the performance on or is this expected?
Add Comment
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300276.1552587373000.140854.1632828180028%40Atlassian.JIRA.
Jira (PUP-11208) Puppet fails to install packages on Solaris if another pkg install is running
Title: Message Title Gabriel Nagy updated an issue Puppet / PUP-11208 Puppet fails to install packages on Solaris if another pkg install is running Change By: Gabriel Nagy Fix Version/s: PUP 7.12.0 Fix Version/s: PUP 6.25.0 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.412673.1629371858000.140836.1632825240033%40Atlassian.JIRA.
Jira (PUP-11265) puppet-agent : Concat not respecting environments
Title: Message Title Gabriel Nagy updated an issue Puppet / PUP-11265 puppet-agent : Concat not respecting environments Change By: Gabriel Nagy Fix Version/s: PUP 6.25.0 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413595.1630046552000.140820.1632823860078%40Atlassian.JIRA.
Jira (FACT-3075) Windows 2022 is detected as Windows 2019
Title: Message Title Gabriel Nagy updated an issue Facter / FACT-3075 Windows 2022 is detected as Windows 2019 Change By: Gabriel Nagy Affects Version/s: FACT 3.14.20 Affects Version/s: FACT 4.2.5 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.416781.1632314698000.140817.1632823800360%40Atlassian.JIRA.
Jira (FACT-3075) Windows 2022 is detected as Windows 2019
Title: Message Title Gabriel Nagy updated an issue Facter / FACT-3075 Windows 2022 is detected as Windows 2019 Change By: Gabriel Nagy Fix Version/s: FACT 3.14.20 Fix Version/s: FACT 4.2.5 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.416781.1632314698000.140816.1632823800315%40Atlassian.JIRA.
Jira (FACT-3058) Add DisplayVersion fact for Windows machines
Title: Message Title Gabriel Nagy updated an issue Facter / FACT-3058 Add DisplayVersion fact for Windows machines Change By: Gabriel Nagy Fix Version/s: FACT 4.2.5 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.408768.1627470358000.140818.1632823800404%40Atlassian.JIRA.
Jira (FACT-3075) Windows 2022 is detected as Windows 2019
Title: Message Title Gabriel Nagy assigned an issue to Luchian Nemes Facter / FACT-3075 Windows 2022 is detected as Windows 2019 Change By: Gabriel Nagy Assignee: Ciprian Badescu Luchian Nemes Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.416781.1632314698000.140810.1632823740357%40Atlassian.JIRA.
Jira (FACT-3058) Add DisplayVersion fact for Windows machines
Title: Message Title Gabriel Nagy assigned an issue to Luchian Nemes Facter / FACT-3058 Add DisplayVersion fact for Windows machines Change By: Gabriel Nagy Assignee: Luchian Nemes Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.408768.1627470358000.140803.1632823620166%40Atlassian.JIRA.
Jira (FACT-3073) Inconsistencies to set Facter::Core::Execution.execute timeout
Title: Message Title Dorin Pleava updated an issue Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout Change By: Dorin Pleava Fix Version/s: FACT 4.2.5 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.415028.1631164898000.140703.1632816360032%40Atlassian.JIRA.
Jira (PUP-11265) puppet-agent : Concat not respecting environments
Title: Message Title Gabriel Nagy assigned an issue to Gabriel Nagy Puppet / PUP-11265 puppet-agent : Concat not respecting environments Change By: Gabriel Nagy Assignee: Gabriel Nagy Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413595.1630046552000.140688.1632815760169%40Atlassian.JIRA.
Jira (FACT-3075) Windows 2022 is detected as Windows 2019
Title: Message Title Ciprian Badescu updated an issue Facter / FACT-3075 Windows 2022 is detected as Windows 2019 Change By: Ciprian Badescu Team: Night's Watch Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.416781.1632314698000.140678.1632815280050%40Atlassian.JIRA.
Jira (FACT-3058) Add DisplayVersion fact for Windows machines
Title: Message Title Ciprian Badescu assigned an issue to Unassigned Facter / FACT-3058 Add DisplayVersion fact for Windows machines Change By: Ciprian Badescu Assignee: Ciprian Badescu Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.408768.1627470358000.140679.1632815280097%40Atlassian.JIRA.
Jira (FACT-3058) Add DisplayVersion fact for Windows machines
Title: Message Title Ciprian Badescu updated an issue Facter / FACT-3058 Add DisplayVersion fact for Windows machines Change By: Ciprian Badescu Sprint: NW - 2021-10-06 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.408768.1627470358000.140677.1632815220034%40Atlassian.JIRA.
Jira (PUP-11265) puppet-agent : Concat not respecting environments
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11265 puppet-agent : Concat not respecting environments Change By: Ciprian Badescu Team: Night's Watch Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413595.1630046552000.140674.1632814860029%40Atlassian.JIRA.
Jira (PUP-11265) puppet-agent : Concat not respecting environments
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11265 puppet-agent : Concat not respecting environments Change By: Ciprian Badescu Sprint: NW - 2021-10-06 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413595.1630046552000.140673.1632814800044%40Atlassian.JIRA.
Jira (PDB-5262) Grouping by facts that contain "/" generates invalid SQL
Title: Message Title Sebastian Miclea assigned an issue to Sebastian Miclea PuppetDB / PDB-5262 Grouping by facts that contain "/" generates invalid SQL Change By: Sebastian Miclea Assignee: Sebastian Miclea Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.415600.1631630062000.140663.1632812100188%40Atlassian.JIRA.
