Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 In order to reduce potentially unnecessary network traffic and data that may be unused, Puppet should optionally allow the unchanged resource statuses and their events to not be serialized when the reports are generated:[https://github.com/puppetlabs/puppet/blob/948a4bec67def5244595a6f69976a9a2479f1df1/lib/puppet/transaction/report.rb#L326]*Details*The report contains an array of resource statuses {{Puppet::Resource::Status}}The status contains the result of managing a single resource {{Puppet::Type::}}There may be 0 or more events {{Puppet::Transaction::Event}} per resource status.Each event captures the current and desired values for each property, e.g. if puppet changes the {{owner}} property for the {{file}} type, then the event will contain the old and new values.Here's an example entry from the report in YAML:{code:yaml}  File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.002537417tags:- file- classtime: '2022-10-18T22:49:58.301897873+00:00'failed: falsefailed_to_restart: falsechanged: trueout_of_sync: trueskipped: falsechange_count: 2out_of_sync_count: 2events:- audited: false  property: owner  previous_value: 52  desired_value: 0  historical_value:   message: owner changed 'puppet' to 'root'  name: owner_changed  status: success  time: '2022-10-18T22:49:58.302133825+00:00'  redacted:   corrective_change: false- audited: false  property: group  previous_value: 52  desired_value: 0  historical_value:   message: group changed 'puppet' to 'root'  name: group_changed  status: success  time: '2022-10-18T22:49:58.303239684+00:00'  redacted:   corrective_change: falsecorrective_change: false{code}When the same file is "insync", then the report contains:{code:yaml}  File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.000237233tags:- file- classtime: '2022-10-18T22:57:32.999773271+00:00'failed: falsefailed_to_restart: falsechanged: falseout_of_sync: falseskipped: falsechange_count: 0out_of_sync_count: 0events: []corrective_change: false{code}I believe the {{Puppet::Resource::Status#out_of_sync?}} method can be used to filter which statuses to include/exclude. If it  results  returns  {{{}false{}}}, then no changes were necessary.For this ticket:1. Create a boolean puppet setting to exclude unchanged 

Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 needs-validation  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.471176.1665698711000.49006.1666136040054%40Atlassian.JIRA.


Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 In order to reduce potentially unnecessary network traffic and data that may be unused, Puppet should optionally allow the unchanged resource statuses and their events to not be serialized when the reports are generated: [ https://github.com/puppetlabs/puppet/blob/948a4bec67def5244595a6f69976a9a2479f1df1/lib/puppet/transaction/report.rb#L326 ] *Details*The report contains an array of resource statuses {{Puppet::Resource::Status}}The status contains the result of managing a single resource {{Puppet::Type::}}There may be 0 or more events {{Puppet::Transaction::Event}} per resource status.Each event captures the current and desired values for each property, e.g. if puppet changes the {{owner}} property for the {{file}} type, then the event will contain the old and new values.Here's an example entry from the report in YAML:  {code:yaml}    File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.002537417tags:- file- classtime: '2022-10-18T22:49:58.301897873+00:00'failed: falsefailed_to_restart: falsechanged: trueout_of_sync: trueskipped: falsechange_count: 2out_of_sync_count: 2events:- audited: false  property: owner  previous_value: 52  desired_value: 0  historical_value:   message: owner changed 'puppet' to 'root'  name: owner_changed  status: success  time: '2022-10-18T22:49:58.302133825+00:00'  redacted:   corrective_change: false- audited: false  property: group  previous_value: 52  desired_value: 0  historical_value:   message: group changed 'puppet' to 'root'  name: group_changed  status: success  time: '2022-10-18T22:49:58.303239684+00:00'  redacted:   corrective_change: falsecorrective_change: false{code}  When the same file is "insync", then the report contains:  {code:yaml}    File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.000237233tags:- file- classtime: '2022-10-18T22:57:32.999773271+00:00'failed: falsefailed_to_restart: falsechanged: falseout_of_sync: falseskipped: falsechange_count: 0out_of_sync_count: 0events: []corrective_change: false{code}  I believe  the   {{Puppet::Resource::Status#out_of_sync?}} method can be used to filter which statuses to include/exclude. If it results {{ {} false { }} } , then no changes were necessary.For this ticket:1. Create a boolean puppet setting to exclude 

Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 In order to reduce potentially unnecessary network traffic and data that may be unused, Puppet should optionally allow the unchanged resource statuses and their events to not be serialized when the reports are generated:[https://github.com/puppetlabs/puppet/blob/948a4bec67def5244595a6f69976a9a2479f1df1/lib/puppet/transaction/report.rb#L326]*Details*The report contains an array of resource statuses {{Puppet::Resource::Status}}The status contains the result of managing a single resource {{Puppet::Type::}}There may be 0 or more events {{Puppet::Transaction::Event}} per resource status.Each event captures the current and desired values for each property, e.g. if puppet changes the {{owner}} property for the {{file}} type, then the event will contain the old and new values.Here's an example entry from the report in YAML:{code:yaml}  File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.002537417tags:- file- classtime: '2022-10-18T22:49:58.301897873+00:00'failed: falsefailed_to_restart: falsechanged: trueout_of_sync: trueskipped: falsechange_count: 2out_of_sync_count: 2events:- audited: false  property: owner  previous_value: 52  desired_value: 0  historical_value:   message: owner changed 'puppet' to 'root'  name: owner_changed  status: success  time: '2022-10-18T22:49:58.302133825+00:00'  redacted:   corrective_change: false- audited: false  property: group  previous_value: 52  desired_value: 0  historical_value:   message: group changed 'puppet' to 'root'  name: group_changed  status: success  time: '2022-10-18T22:49:58.303239684+00:00'  redacted:   corrective_change: falsecorrective_change: false{code}When the same file is "insync", then the report contains:{code:yaml}  File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.000237233tags:- file- classtime: '2022-10-18T22:57:32.999773271+00:00'failed: falsefailed_to_restart: falsechanged: falseout_of_sync: falseskipped: falsechange_count: 0out_of_sync_count: 0events: []corrective_change: false{code}I believe the {{Puppet::Resource::Status#out_of_sync?}} method can be used to filter which statuses to include/exclude. If it results {{{}false{}}}, then no changes were necessary.For this ticket:1. Create a boolean puppet setting to exclude unchanged resources 

Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 In order to reduce potentially unnecessary network traffic and data that may be unused, Puppet should optionally allow the unchanged resource  statuses and their  events to not be serialized when the reports are generated:https://github.com/puppetlabs/puppet/blob/948a4bec67def5244595a6f69976a9a2479f1df1/lib/puppet/transaction/report.rb#L326 *Details*The report contains an array of resource statuses {{Puppet::Resource::Status}}The status contains the result of managing a single resource {{Puppet::Type::}}There may be 0 or more events {{Puppet::Transaction::Event}} per resource status.Each event captures the current and desired values for each property, e.g. if puppet changes the {{owner}} property for the {{file}} type, then the event will contain the old and new values.Here's an example entry from the report in YAML:{code:yaml}  File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.002537417tags:- file- classtime: '2022-10-18T22:49:58.301897873+00:00'failed: falsefailed_to_restart: falsechanged: trueout_of_sync: trueskipped: falsechange_count: 2out_of_sync_count: 2events:- audited: false  property: owner  previous_value: 52  desired_value: 0  historical_value:   message: owner changed 'puppet' to 'root'  name: owner_changed  status: success  time: '2022-10-18T22:49:58.302133825+00:00'  redacted:   corrective_change: false- audited: false  property: group  previous_value: 52  desired_value: 0  historical_value:   message: group changed 'puppet' to 'root'  name: group_changed  status: success  time: '2022-10-18T22:49:58.303239684+00:00'  redacted:   corrective_change: falsecorrective_change: false{code}When the same file is "insync", then the report contains:{code:yaml}  File[/tmp/file]:title: "/tmp/file"file: "/etc/puppetlabs/code/environments/production/manifests/site.pp"line: 2resource: File[/tmp/file]resource_type: Fileprovider_used: posixcontainment_path:- Stage[main]- Main- File[/tmp/file]evaluation_time: 0.000237233tags:- file- classtime: '2022-10-18T22:57:32.999773271+00:00'failed: falsefailed_to_restart: falsechanged: falseout_of_sync: falseskipped: falsechange_count: 0out_of_sync_count: 0events: []corrective_change: false{code}I believe  {{Puppet::Resource::Status#out_of_sync?}} method can be used to filter which statuses to include/exclude. If it results {{false}}, then no changes were necessary.For this ticket:1. Create a boolean puppet setting to exclude unchanged resources statuses and 

Jira (PUP-11657) General improvements on security

2022-10-18 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11657  
 
 
  General improvements on security   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Team: 
 Comply EMEA  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472282.1666040019000.48934.1666125960049%40Atlassian.JIRA.


Jira (FACT-3156) confine iterable/block incorrectly lowercases the value

2022-10-18 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3156  
 
 
  confine iterable/block incorrectly lowercases the value   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Epic Link: 
 PUP-11619  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.470512.1665091544000.48923.1666125300369%40Atlassian.JIRA.


Jira (PUP-11655) Move more platform specific code from defaults into RunMode

2022-10-18 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11655  
 
 
  Move more platform specific code from defaults into RunMode   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Labels: 
 needs-validation  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.471196.1665756416000.48898.1666124340047%40Atlassian.JIRA.


Jira (FACT-3051) Facter speed and usability improvements

2022-10-18 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3051  
 
 
  Facter speed and usability improvements   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Team/s: 
 Night's Watch Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.402831.1623245981000.48891.1666123980086%40Atlassian.JIRA.


Jira (PUP-11656) Investigate systemd rspec test failure and update tests

2022-10-18 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11656  
 
 
  Investigate systemd rspec test failure and update tests   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Epic Link: 
 PUP-11619  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.471554.1665783437000.48885.1666123620040%40Atlassian.JIRA.


Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 7.21.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.471176.1665698711000.48862.1666120860133%40Atlassian.JIRA.


Jira (PUP-11654) Make unchanged events in report optional

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11654  
 
 
  Make unchanged events in report optional   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.471176.1665698711000.48863.1666120860181%40Atlassian.JIRA.


Jira (PUP-10688) tidy resource does not honor schedule metaparameter

2022-10-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-10688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: tidy resource does not honor schedule metaparameter   
 

  
 
 
 
 

 
 Lukas Erlacher yes in general metaparameters should be copied from the parent to the child resource, except for the "alias" metaparameter. See my comment in https://tickets.puppetlabs.com/browse/PUP-11631?focusedCommentId=876236=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-876236 and related ticket PUP-10688.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.48695.1666110360039%40Atlassian.JIRA.