Jira (PUP-11689) Enable strict mode by default
Title: Message Title Josh Cooper commented on PUP-11689 Re: Enable strict mode by default Ah these are defined in the pdk-templates, see https://github.com/puppetlabs/pdk-templates/commit/192de183ec39420a7f018b1b2c3e6426aa26114a (in 2020) and https://github.com/puppetlabs/pdk-templates/commit/7b2647cfb75c94564084330a7c1e54dc296796d1 (in 2018) Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.476842.1670862344000.70278.1673066400092%40Atlassian.JIRA.
Jira (PUP-11689) Enable strict mode by default
Title: Message Title Josh Cooper commented on PUP-11689 Re: Enable strict mode by default Unfortunately, no. The adapter code just maps rspec config settings to puppet like: https://github.com/puppetlabs/rspec-puppet/blob/587617c7314e9ea26cb77eed66c08a756fd4f18a/lib/rspec-puppet/adapters.rb#L27-L32 The default for strict_varibles is defined in https://github.com/puppetlabs/rspec-puppet/blob/587617c7314e9ea26cb77eed66c08a756fd4f18a/lib/rspec-puppet.rb#L52 And I don't see one for strict so I assume it inherits the behavior from whatever puppet version is being used. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.476842.1670862344000.70277.1673065440028%40Atlassian.JIRA.
Jira (PUP-11649) Drop support for ruby < 2.7
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11649 Drop support for ruby < 2.7 Change By: Josh Cooper Update the gemspec to require ruby 2.7 or greaterUpdate ext/project_data.yaml to require ruby 2.7 or greaterUpdate the github actions to remove older ruby versionsUpdate branch protection rules Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.470537.1665159191000.70273.1673063820099%40Atlassian.JIRA.
Jira (FACT-3175) Remove sys-filesystem monkey patch
Title: Message Title Josh Cooper created an issue Facter / FACT-3175 Remove sys-filesystem monkey patch Issue Type: Task Assignee: Unassigned Created: 2023/01/06 12:40 PM Priority: Normal Reporter: Josh Cooper Facter monkey patches sys-filesystem due to FACT-2782. See https://github.com/puppetlabs/facter/commit/50e2d8fb8aba9fd775342f622f663b2f23161827 The fix was submitted upstream and merged (see https://github.com/djberg96/sys-filesystem/commit/47c0045e529fb7254e88e4167c66d5818763d18c), so we should be able to: 1. bump our minimum gem dependency in https://github.com/puppetlabs/facter/blob/main/facter.gemspec#L38 2. Remove the monkey patch from facter 3. Bump the sys-filesystem gem in puppet-runtime (for both agent-runtime-7.x and agent-runtime-main) see https://github.com/puppetlabs/puppet-runtime/blob/master/configs/components/rubygem-sys-filesystem.rb This should be fixed in both 7.x and main Add Comment
Jira (FACT-3174) Facter logging debugonce is O^2
Title: Message Title Josh Cooper created an issue Facter / FACT-3174 Facter logging debugonce is O^2 Issue Type: Bug Assignee: Unassigned Created: 2023/01/06 12:34 PM Priority: Normal Reporter: Josh Cooper The debugonce method scans an array to see if the message has already been logged. https://github.com/puppetlabs/facter/blob/ffc9febe3e6dad67891e0209782ced0c9fb6040b/lib/facter/framework/logging/logger.rb#L118 It should use a SortedSet instead. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
