Jira (FACT-1902) Confirm Facter 4 validates that external/custom/executable facts output proper UTF-8

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-1902  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Confirm Facter 4 validates that external/custom/executable facts output proper UTF-8   
 

  
 
 
 
 

 
 Facter 4:  
 
 
 
 
 $ bx facter --custom-dir ./custom_facts -j nullbyte  
 
 
 {  
 
 
   "nullbyte": "a\ub"  
 
 
 }
  
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from

Jira (FACT-2138) Facts passed via environment variables not parsed as array

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2138  
 
 
  Facts passed via environment variables not parsed as array   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11659  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336665.1574760303000.2379.1679451840020%40Atlassian.JIRA.


Jira (FACT-2138) Facts passed via environment variables not parsed as array

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-2138  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facts passed via environment variables not parsed as array   
 

  
 
 
 
 

 
 Facter doesn't accept structured environment variables, just string values. We don't have plans on changing that so I'm going to close this. The alternative is to create a structured fact, e.g. yaml, and point facter at that file/directory.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336665.1574760303000.2378.1679451780192%40Atlassian.JIRA.


Jira (FACT-3089) Processor ISA fact on Linux reports wrong data if the string contains a period

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3089  
 
 
  Processor ISA fact on Linux reports wrong data if the string contains a period   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal High  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.421525.1635492732000.2374.1679451660021%40Atlassian.JIRA.


Jira (FACT-3178) Facter `` ldom.domainrole.impl`` fails on Solaris 11, SPARC

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3178  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facter `` ldom.domainrole.impl`` fails on Solaris 11, SPARC   
 

  
 
 
 
 

 
 I verified that facter 4 resolves the value, but filters out the resolved value because of confusion with dots in the user query.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479125.1673888594000.2371.1679451600034%40Atlassian.JIRA.


Jira (FACT-3178) Facter `` ldom.domainrole.impl`` fails on Solaris 11, SPARC

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3178  
 
 
  Facter `` ldom.domainrole.impl`` fails on Solaris 11, SPARC   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 escalation jira_escalated needs-validation  regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479125.1673888594000.2372.1679451600097%40Atlassian.JIRA.


Jira (FACT-3178) Facter `` ldom.domainrole.impl`` fails on Solaris 11, SPARC

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3178  
 
 
  Facter `` ldom.domainrole.impl`` fails on Solaris 11, SPARC   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal High  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479125.1673888594000.2373.1679451600145%40Atlassian.JIRA.


Jira (FACT-3136) Bug in gce.project.attributes.sshKeys

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3136  
 
 
  Bug in gce.project.attributes.sshKeys   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal High  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.454867.1657650158000.2370.1679449860033%40Atlassian.JIRA.


Jira (FACT-3186) facter 4.2.13: bug "facter partitions"

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3186  
 
 
  facter 4.2.13: bug "facter partitions"   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal High  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.481372.1676386915000.2368.1679449680030%40Atlassian.JIRA.


Jira (PUP-11723) Revisit Concurrent::RubyThreadLocalVar

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11723  
 
 
  Revisit Concurrent::RubyThreadLocalVar   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal High  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479493.1674511008000.2369.1679449680093%40Atlassian.JIRA.


Jira (FACT-3192) Custom fact fails to appear when using some options like --no-external-facts

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3192  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Custom fact fails to appear when using some options like --no-external-facts   
 

  
 
 
 
 

 
 Raising the priority because this is the way we tell users to prevent recursion/fork bomb when calling facter from an external fact.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483146.1679060554000.2367.1679449380025%40Atlassian.JIRA.


Jira (FACT-3192) Custom fact fails to appear when using some options like --no-external-facts

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --no-external-facts   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Summary: 
 Custom fact fails to appear when using some options like -- json no-external-facts  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483146.1679060554000.2365.1679449320042%40Atlassian.JIRA.


Jira (FACT-3192) Custom fact fails to appear when using some options like --no-external-facts

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --no-external-facts   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal Major  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483146.1679060554000.2366.1679449320105%40Atlassian.JIRA.


Jira (FACT-3193) Delete facter-ng code/tests

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3193  
 
 
  Delete facter-ng code/tests   
 

  
 
 
 
 

 
Issue Type: 
  Task  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/03/21 6:38 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 Facter-ng was the name given to the facter 4 gem that shipped in the puppet 6 stream. Now that 6 is EOL we should delete references to facter-ng from facter#main branch.  
 
 
 
 
 .rubocop.yml  
 
 
 ./bin/facter-ng  
 
 
 ./agent/facter-ng.gemspec  
 
 
 ./agent/lib/facter-ng.rb  
 
 
 ./acceptance/tests/options/help.rb
  
 
 
 
  Also update CJC and remove facter-ng jobs & promotions.  
 

  
 
 

Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3192  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
  
 
 
 
 
 root@pe-server-238c28-1 development (development)$ facter --json | grep -E "(oslogin|[^/]bigbird)"  
 
 
 "oslogin": {
  
 
 
 
  This output (above) is expected because bigbird is a custom fact in a puppet module (so --puppet is required to load those facts)  
 
 
 
 
 root@pe-server-238c28-1 development (development)$ facter -p --no-external-facts | grep -E "(oslogin|[^/]bigbird)"  
 
 
 [2023-03-17 13:28:08.334765 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one 
  
 
 
 
  This output (above) is not expected and is a bug. The "--no-external-facts" command line option is important because it prevents recursion when external facts call facter. See FACT-1373 and that was added in Facter 3 and the same issue again in Facter 4 (FACT-2772)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
  

Jira (PUP-11718) Delete ruby < 3.1 specific code paths

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11718  
 
 
  Delete ruby < 3.1 specific code paths   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 This is a follow-on to PUP-11649 and  PUP-11716. Ruby 2.7 will be EOL before Puppet 8 ships, so we should more aggressively prune the list of supported ruby versions.Once  PUP-11716 is complete, we should be able to remove special cases in code and tests for older ruby versions like{noformat}Gemfile:  gem 'vcr', RUBY_VERSION.to_f >= 3.2 ? '~> 6.1' : '~> 5.0', require: falseGemfile:  gem 'webrick', '~> 1.7', require: false if RUBY_VERSION.to_f >= 3.0benchmarks/catalog_memory/benchmarker.rb:RUBYVER_ARRAY = RUBY_VERSION.split(".").collect {|s| s.to_i }lib/puppet.rb:if !defined?(JRUBY_VERSION) && Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new("2.7.0")lib/puppet.rb:  raise LoadError, "Puppet #{Puppet.version} requires Ruby 2.7.0 or greater, found Ruby #{RUBY_VERSION.dup}."lib/puppet.rb:Puppet::OLDEST_RECOMMENDED_RUBY_VERSION = '2.7.0'lib/puppet.rb:  if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new(Puppet::OLDEST_RECOMMENDED_RUBY_VERSION)lib/puppet.rb:Puppet.deprecation_warning(_("Support for ruby version %{version} is deprecated and will be removed in a future release. See https://puppet.com/docs/puppet/latest/system_requirements.html for a list of supported ruby versions.") % { version: RUBY_VERSION })lib/puppet/application.rb:  'ruby_version'   => RUBY_VERSION,lib/puppet/defaults.rb:  :default => "Puppet/#{Puppet.version} Ruby/#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL} (#{RUBY_PLATFORM})",lib/puppet/util.rb:  if RUBY_VERSION >= "2.6"lib/puppet/util/monkey_patches.rb:if RUBY_VERSION.to_f < 3.0spec/unit/http/factory_spec.rb:it "sets the minimum version to TLS 1.0", if: RUBY_VERSION.to_f >= 2.5 dospec/unit/network/http/connection_spec.rb:  puppet_ua = "Puppet/#{Puppet.version} Ruby/#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL} (#{RUBY_PLATFORM})"spec/unit/puppet_spec.rb:  context "Puppet::OLDEST_RECOMMENDED_RUBY_VERSION" dospec/unit/puppet_spec.rb:  expect(Puppet::OLDEST_RECOMMENDED_RUBY_VERSION).not_to be_nilspec/unit/puppet_spec.rb:  expect(Puppet::OLDEST_RECOMMENDED_RUBY_VERSION).to be_a_kind_of(String)spec/unit/puppet_spec.rb:  expect(SemanticPuppet::Version).to be_valid(Puppet::OLDEST_RECOMMENDED_RUBY_VERSION)spec/unit/reports/store_spec.rb:  if RUBY_VERSION < "3.0"spec/unit/util_spec.rb:  :if => Puppet::Util::Platform.windows? && RUBY_VERSION.to_f < 3 do{noformat}Also double check lib/puppet/util/monkey_patches.rb to see if any code is no longer relevant , especially if .Also  MRI 3.1  ships with the openssl 3.0.0 gem (https://github.com/ruby/ruby/blob/v3_1_0/NEWS.md#stdlib-updates) and that version  requires openssl 1.1.1 or  later  greater (https://github.com/ruby/openssl/blob/v3.0.0/History.md#version-300), so we can delete any code paths that are specific to openssl 1.0.2.  
 

  
 

Jira (PUP-11718) Delete ruby < 3.1 specific code paths

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11718  
 
 
  Delete ruby < 3.1 specific code paths   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Summary: 
 Drop support for Delete  ruby < 3.1  specific code paths  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479201.1673977006000.2357.1679444880025%40Atlassian.JIRA.


Jira (PUP-11783) Delete pson code from puppet

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11783  
 
 
  Delete pson code from puppet   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Phoenix 2023-03-29  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.482933.1678895719000.2355.1679444280021%40Atlassian.JIRA.


Jira (PUP-11783) Delete pson code from puppet

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11783  
 
 
  Delete pson code from puppet   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.482933.1678895719000.2354.1679444220023%40Atlassian.JIRA.


Jira (PDB-3171) query compilation is very slow for queries with giant arrays

2023-03-21 Thread Ingrida Cazers (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ingrida Cazers commented on  PDB-3171  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: query compilation is very slow for queries with giant arrays   
 

  
 
 
 
 

 
 In a Slack conversation today, Nick and I agreed on the following text: Improved performance when querying PuppetDB This enhancement helps to improve performance for PuppetDB queries that contain large arrays, for example, if many nodes are enumerated or many terms are joined by a single "and" or "or" element.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.159741.1478279255000.2304.1679438820021%40Atlassian.JIRA.


Jira (PUP-11785) Don't fallback to PSON

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11785  
 
 
  Don't fallback to PSON   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483276.1679434736000.2264.1679435760145%40Atlassian.JIRA.


Jira (PUP-11785) Don't fallback to PSON

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11785  
 
 
  Don't fallback to PSON   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/03/21 2:38 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 If puppetserver fails to serialize a catalog to JSON it will fallback to PSON, because there was a time where rich data wasn't supported end-to-end between server and agents. However, rich data is now enabled by default and supported end-to-end. And it required when using Deferred or Sensitive parameters. Therefore, if puppetserver downgrades to PSON it can lead to surprising behavior as described in PUP-10928. In Puppet 8, we will no longer fallback to PSON. If a user wants binary data in the catalog, such as a Kerberos keytab file, then they should use `content => binary_file(...)` in a file resource.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
  

Jira (FACT-3191) Allow Facter 4 to handle UTF-16

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3191  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow Facter 4 to handle UTF-16
 

  
 
 
 
 

 
 I think this is a regression from Facter 3 for YAML-based external facts. Facter 3 used yaml-cpp to parse external facts https://github.com/puppetlabs/facter/blob/6d7ffc6efdfbc3b1fc79311cdeb4581ac2098d9c/lib/src/facts/external/yaml_resolver.cc#L29 The yaml-cpp library examines the first several bytes of the stream to determine the encoding, see https://github.com/jbeder/yaml-cpp/blob/74f63c1181533923d5312596ba06b4fc8d10a387/src/stream.cpp#L198-L238 Facter 4 uses libyaml built into Ruby, which has similar logic for determining the encoding, though not exactly the same: https://github.com/yaml/libyaml/blob/f8f760f7387d2cc56a2fc7b1be313a3bf3f7f58c/src/reader.c#L51-L87. libyaml it assumes UTF-8 if the file does not have a BOM, whereas yaml-cpp always tries to detect the encoding. Note how these cases are different: https://github.com/jbeder/yaml-cpp/blob/74f63c1181533923d5312596ba06b4fc8d10a387/src/stream.cpp#L24-L26 That said we should still verify the regression and also check behavior with JSON, INI and external executable facts.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.482922.1678884274000.2230.1679433180025%40Atlassian.JIRA.


Jira (PUP-11763) Puppet resource can't load time object to YAML

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11763  
 
 
  Puppet resource can't load time object to YAML   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 The "file" resource now supports "puppet resource file  --to_yaml"  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.481712.1676662751000.2211.1679432160031%40Atlassian.JIRA.


Jira (FACT-3155) Remove timecop from spec tests

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3155  
 
 
  Remove timecop from spec tests   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 FACT 4.3.1  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.470510.1665091007000.2210.1679432040195%40Atlassian.JIRA.


Jira (PDB-5613) Drop PSON or at least don't call it by default

2023-03-21 Thread Austin Blatt (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Austin Blatt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5613  
 
 
  Drop PSON or at least don't call it by default   
 

  
 
 
 
 

 
Change By: 
 Austin Blatt  
 
 
Epic Link: 
 PE- 34946 34738  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483168.1679088965000.2184.1679431260090%40Atlassian.JIRA.


Jira (FACT-3191) Allow Facter 4 to handle UTF-16

2023-03-21 Thread Tony Vu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3191  
 
 
  Allow Facter 4 to handle UTF-16
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Labels: 
 jira_escalated  needs-validation  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.482922.1678884274000.2161.1679429940100%40Atlassian.JIRA.


Jira (PUP-11784) Running `puppet epp render` on a template fails subtemplates

2023-03-21 Thread Tony Vu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11784  
 
 
  Running `puppet epp render` on a template fails subtemplates   
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Labels: 
 needs-validation  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483160.1679074293000.2154.1679429460032%40Atlassian.JIRA.


Jira (PUP-11658) Puppet Maintenance CY23 Q1

2023-03-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11658  
 
 
  Puppet Maintenance CY23 Q1   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Status: 
 To Do Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472731.166628603.1993.1679415360024%40Atlassian.JIRA.