Jira (PUP-10054) Incorrect function in documentation examples for strip and rstrip functions

2019-09-30 Thread Brian Krische (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Brian Krische created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10054  
 
 
  Incorrect function in documentation examples for strip and rstrip functions   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Docs  
 
 
Created: 
 2019/09/30 7:27 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Brian Krische  
 

  
 
 
 
 

 
 In the documentation, the example usages for the functions strip and rstrip are wrong, they both seem to show usage of lstrip and not the appropriate function. 
 
strip shows usage of lstrip 
rstrip shows usage of lstrip 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  

Jira (BOLT-1524) Add parameters to apply_prep function

2019-08-20 Thread Brian Krische (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Brian Krische created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-1524  
 
 
  Add parameters to apply_prep function   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2019/08/20 7:02 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Brian Krische  
 

  
 
 
 
 

 
 The puppet_agent::install task has several useful parameters on it, such as the version to install and alternate sources to download from. However, it is currently not possible to specify those parameters to the apply_prep function. Workaround There is currently a workaround, and that is to call puppet_agent::install task with the run_task function; specifying the desired parameters. However, it is still necessary to run apply_prep afterwards, so that all the node's facts can be gathered. Expected Behavior I would expect that the apply_prep function can accept the same parameters as the puppet_agent::install task and use those parameter values when calling the task.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 
 

Jira (PUP-3533) File resource doesn't handle NTFS junctions well

2014-10-29 Thread Brian Krische (JIRA)
Title: Message Title










 

 Brian Krische commented on an issue


















  Re: File resource doesn't handle NTFS junctions well 










Josh Cooper Here is the trace output when trying to create a directory inside the junction (step 3 from description)

Error: Cannot create C:/junction/test; parent directory C:/junction does not exist C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/type/file/ensure.rb:83:in `block (2 levels) in module:Puppet' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/property.rb:197:in `call_valuemethod' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/property.rb:498:in `set' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/property.rb:581:in `sync' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/type/file/ensure.rb:183:in `sync' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction/resource_harness.rb:204:in `sync' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction/resource_harness.rb:128:in `sync_if_needed' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction/resource_harness.rb:81:in `perform_changes' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction/resource_harness.rb:20:in `evaluate' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction.rb:204:in `apply' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction.rb:217:in `eval_resource' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction.rb:147:in `call' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction.rb:147:in `block (2 levels) in evaluate' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/util.rb:327:in `block in thinmark' C:/Program Files (x86)/Puppet Labs/Puppet/sys/ruby/lib/ruby/1.9.1/benchmark.rb:295:in `realtime' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/util.rb:326:in `thinmark' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction.rb:147:in `block in evaluate' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/graph/relationship_graph.rb:118:in `traverse' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction.rb:138:in `evaluate' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/resource/catalog.rb:169:in `block in apply' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/util/log.rb:153:in `with_destination' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/transaction/report.rb:112:in `as_logging_destination' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/resource/catalog.rb:168:in `apply' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/indirector/resource/ral.rb:41:in `save' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/indirector/indirection.rb:283:in `save' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application/resource.rb:218:in `find_or_save_resources' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application/resource.rb:142:in `main' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application.rb:389:in `run_command' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application.rb:381:in `block (2 levels) in run' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application.rb:507:in `plugin_hook' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application.rb:381:in `block in run' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/util.rb:488:in `exit_on_fail' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/application.rb:381:in `run' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/util/command_line.rb:146:in `run' C:/Program Files (x86)/Puppet Labs/Puppet/puppet/lib/puppet/util/command_line.rb:92:in `execute' C:/Program Files (x86)/Puppet 

Jira (PUP-3533) File resource doesn't handle NTFS junctions well

2014-10-24 Thread Brian Krische (JIRA)
Title: Message Title










 

 Brian Krische created an issue


















 Puppet /  PUP-3533



  File resource doesn't handle NTFS junctions well 










Issue Type:

  Bug




Affects Versions:


 PUP 3.7.2




Assignee:


 Unassigned




Created:


 24/Oct/14 11:28 AM




Environment:


Windows Server 2012 R2




Priority:

  Normal




Reporter:

 Brian Krische










Puppet (specifically the file resource) doesn't seem to consistently handle NTFS folder junctions in Windows. Here are some steps to reproduce:


Create a directory and directory junction in Windows


mkdir C:\directory


mklink /J C:\junction C:\directory




Create a file inside the junction (this works)


 

Jira (PUP-3067) Windows Package provider should verify DisplayName after install

2014-08-15 Thread Brian Krische (JIRA)
Title: Message Title










 

 Brian Krische created an issue


















 Puppet /  PUP-3067



  Windows Package provider should verify DisplayName after install 










Issue Type:

  Improvement




Affects Versions:


 3.6.2




Assignee:

 Kylo Ginsberg




Components:


 Types and Providers




Created:


 15/Aug/14 7:46 AM




Labels:


 windows




Priority:

  Normal




Reporter:

 Brian Krische










I've noticed that some windows installation packages will return with an exit code of 0 if you screw up the command line arguments. In these scenarios, Puppet doesn't catch that the install actually didn't complete.
I thought it could be a good idea that Puppet could verify the DisplayName is now listed after it has finished installing a package. If it doesn't appear, then it would fail.