Jira (PUP-4708) Refresh Environment Variables during run
Title: Message Title Dima commented on PUP-4708 Re: Refresh Environment Variables during run I agree that this would be extremely useful. This annoyance in Windows makes it hard for us to complete things in 1 run or even at all without restarting the Puppet Agent as we have a dependency in a provider which requires some other module which installs an executable...the PATH variable needs to be updated for the provider to be able to continue. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-765) The gid fact is ill-constrained on Windows (ID.EXE is called if it exists)
Title: Message Title Dima commented on FACT-765 Re: The gid fact is ill-constrained on Windows (ID.EXE is called if it exists) We have this same problem on Puppet Enterprise agents (tested on 3.7.2 and 3.8.0), so it affects Enterprise customers as well. Looking forward to a fix. In this case we have id.exe from the gnu win32 utilities in the path; C:\ProgramData\PuppetLabs\puppet\puppet apply tests\init.pp C:\Some Path\id.EXE: cannot find name for group ID 0 Notice: Compiled catalog for mysystem.puppetpoc.local in environment production in 1.51 seconds Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4289) user type doesn't support Full Name on Windows
Title: Message Title Dima commented on PUP-4289 Re: user type doesn't support Full Name on Windows Yes, so how do you handle that as it happens with many common types I guess. For user there's all these feature things like feature :manages_aix_lam and feature :manages_solaris_rbac for which the last one seems to add a specific property ( newvalue(:role, :event = :role_created, :required_features = :manages_solaris_rbac) do...and that doesn't look agnostic. I have this full_name working perfectly by adding some small bits to the type; feature :manages_windows_fullname, The provider allows for setting Full Name for a user on windows newproperty(:fullname) do desc Full name of the user on Windows end and to the provider: def fullname user['FullName'] end def fullname=(value) user['FullName'] = value end I would be happy to make a PR for that, but would this be the way to go? There's a few other generic resource types that are missing some basic fields for windows specifics like group description and for the service type there's quite a few (like username, password, recovery actions) for which I would personally not prefer to use wrappers or custom types. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4287) scheduled_task type doesn't support comment/description field
Title: Message Title Dima created an issue Puppet / PUP-4287 scheduled_task type doesn't support comment/description field Issue Type: New Feature Assignee: Kylo Ginsberg Components: Types and Providers, Windows Created: 2015/03/25 12:22 AM Labels: windows scheduled_task Priority: Normal Reporter: Dima The current scheduled_task type and provider doesn't support managing the comment field. (In the GUI this is calls Comments on Windows 2003 and Description on higher Windows releases, but let's call it comment as in the API). The methods for managing the comment are already in the provider and adding support to it is trivial. Add Comment
Jira (PUP-4287) scheduled_task type doesn't support comment/description field
Title: Message Title Dima commented on PUP-4287 Re: scheduled_task type doesn't support comment/description field Support for this was already in https://github.com/puppetlabs/puppet/pull/3637 but as this was about repeat trigger support it was proposed to create a seperate ticket for this. You can check out Josh and my comments about the length of the comment field (proposal of 260 chars (MAX_PATH)) which should be checked by creating another PR related to https://tickets.puppetlabs.com/browse/PUP-3768 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4289) user type doesn't support Full Name on Windows
Title: Message Title Dima created an issue Puppet / PUP-4289 user type doesn't support Full Name on Windows Issue Type: New Feature Assignee: Kylo Ginsberg Components: Types and Providers, Windows Created: 2015/03/25 3:21 AM Labels: windows user Priority: Normal Reporter: Dima Windows has the Full Name field which should be manageable. The windows_adsi.rb and type doesn't support this currently. This is probably because Unix has the gecos field which often contains the full name, but this is the comment field and put into the description of the user...which is to be expected. Propose to add a full_name feature / field to the type and windows _adsi.rb Add Comment
Jira (PUP-4290) Group type doesn't support description/comment field on Windows
Title: Message Title Dima created an issue Puppet / PUP-4290 Group type doesn't support description/comment field on Windows Issue Type: New Feature Assignee: Kylo Ginsberg Components: Types and Providers, Windows Created: 2015/03/25 3:49 AM Labels: windows group Priority: Normal Reporter: Dima The group type doesn't support the description field in Windows which should be manageable. Unix doesn't have a comment field for groups so that's why it's probably not in the type/provider yet. Probably name it comment in the type just as in the user type and not description. Add Comment
Jira (PUP-1291) scheduled_task : add support for every X minutes or hours mode
Title: Message Title Dima commented on PUP-1291 Re: scheduled_task : add support for every X minutes or hours mode Ok, the newly and imroved pull request: https://github.com/puppetlabs/puppet/pull/3637 Includes some fixes on the old one, includes spec tests and a small bonus by adding support for managing the comment field of the scheduled task. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1291) scheduled_task : add support for every X minutes or hours mode
Title: Message Title
Dima commented on PUP-1291
Re: scheduled_task : add support for every X minutes or hours mode
Yes, it is trivial to support this, because all the stuff to configure it is already there, it's only the definitions which need to be accepted/taken from the type and using those values. I made a small diff (no support for the other stuff like end_year and end_day which is also already in there) There is 1 small, minor issue though (which I don't care about too much but which should take into account). If you have a scheduled task with repeat triggers and for example a start time. Then you start managing this scheduled task with puppet, leave out the minutes_interval and minutes_duration definition it won't change the repeat triggers when nothing changes (which is what you want because by not defining those optional properties you leave them unmanaged), but when for example the start time changes, the repeat triggers will dissapear because the provider uses a dummy_trigger definition in which they initialize the minutes_interval and minutes_duration to 0. They should take the current values in the scheduled task instead if repeat triggers aren't managed. Actually the current provider has the same issue I guess.
Here's a unified diff for the type and the provider, I hope Puppet can verify this patch and put support for repeat triggers in the next release. Sorry I can't provide a git pull request at this stage.
Type: (No code changes in the type, I only updated the comments and the example using repeat triggers)
diff -u scheduled_task.rb tasktype.rb — scheduled_task.rb 2015-02-13 09:48:29.0 +0100 +++ tasktype.rb 2015-02-13 09:49:56.0 +0100 @@ -100,6 +100,9 @@
`start_date` — The date when the trigger should first become active. Defaults to the current date. You should format dates as -MM-DD, although other date formats may work. (Under the hood, this uses `Date.parse`.) + * `minutes_interval` — The repeat interval in minutes. + * `minutes_duration` — The duration in minutes, needs to be greater or equal to + minutes_interval.
For daily triggers:
`every` — How often the task should run, as a number of days. Defaults to 1. (2 means every other day, 3 means every three days, etc.) @@ -138,7 +141,7 @@ }
Run at 8am on the first Monday of the month for January, March, and May,
# starting after August 31st, 2011. + # starting after August 31st, 2011. Repeat every 10 minutes for 50 minutes. trigger = { schedule = monthly, start_date = '2011-08-31', # Defaults to current date @@ -146,6 +149,8 @@ months = [1,3,5], # Defaults to all which_occurrence = first, # Must be specified day_of_week = [mon], # Must be specified + minutes_interval = 10, + minutes_duration = 60, }
Jira (PUP-1291) scheduled_task : add support for every X minutes or hours mode
Title: Message Title Dima commented on PUP-1291 Re: scheduled_task : add support for every X minutes or hours mode Sure, I created a pull request https://github.com/puppetlabs/puppet/pull/3610 Bare with me as this is the first github stuff for me... Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
