Jira (PUP-11655) Move more platform specific code from defaults into RunMode

2022-10-14 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11655  
 
 
  Move more platform specific code from defaults into RunMode   
 

  
 
 
 
 

 
Issue Type: 
  Task  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2022/10/14 7:06 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.goo

Jira (FACT-3129) Facter 4 is missing legacy ipaddress_$interface facts

2022-06-28 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  FACT-3129  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facter 4 is missing legacy ipaddress_$interface facts   
 

  
 
 
 
 

 
 Somehow I forgot to mention that it's FreeBSD. https://tickets.puppetlabs.com/browse/FACT-3130 was also created for the same thing and has a patch attached.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.453016.165598579.55463.1656451740031%40Atlassian.JIRA.


Jira (FACT-3129) Facter 4 is missing legacy ipaddress_$interface facts

2022-06-23 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3129  
 
 
  Facter 4 is missing legacy ipaddress_$interface facts   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Affects Versions: 
 FACT 4.2.10, FACT 4.0.5  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Facter 4  
 
 
Created: 
 2022/06/23 5:03 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 Looking in FacterDB the legacy ipaddress_$interface facts are missing. network_$interface and netmask_$interface are present and the IP is also in the modern networking.interfaces.$interface.ipaddress fact is also present. It was present in Facter 3.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
 

Jira (FACT-3102) Get tests passing on Ruby 3.1

2022-06-23 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  FACT-3102  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Get tests passing on Ruby 3.1   
 

  
 
 
 
 

 
 I opened https://github.com/puppetlabs/facter/pull/2496 but I don't know what the workflow is so perhaps the Ready for Review state is incorrect. It may also be that I actually should have referred to FACT-3123.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.429103.1641581665000.52783.1655985240033%40Atlassian.JIRA.


Jira (PUP-11552) Puppet on Ruby 3.1 warns about ERB passing safe_level as non-keyword argument

2022-06-15 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11552  
 
 
  Puppet on Ruby 3.1 warns about ERB passing safe_level as non-keyword argument   
 

  
 
 
 
 

 
Change By: 
 Ewoud Kohl van Wijngaarden  
 
 
Agent OS: 
 Other  
 
 
Environment: 
 {code:java}# cat /etc/fedora-release Fedora release 36 (Thirty Six)# ruby --versionruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]# puppet --version7.17.0{code}Note the dropdown in the Agent OS outdated and only lists very old Fedora versions  
 
 
Issue Type: 
 Improvement Bug  
 
 
Summary: 
 Puppet  on Ruby 3.1 warns about ERB passing safe_level as non-keyword argument  
 

  
 
 
 
 

 
 {code:java}/usr/share/ruby/vendor_ruby/puppet/face/help.rb:143: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments./usr/share/ruby/vendor_ruby/puppet/face/help.rb:143: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  

Jira (PUP-11552) Puppet

2022-06-15 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11552  
 
 
  Puppet   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2022/06/15 2:47 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.451982.1655286

Jira (FACT-3065) submit facts for new facter releases to facterdb

2021-12-14 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  FACT-3065  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: submit facts for new facter releases to facterdb   
 

  
 
 
 
 

 
 If we're going to upload facts per patch set (and I think there's value in that) it certainly makes sense. The code should already work with that since it's just a Dir.glob(File.join(facts_dir, "*", '.facts')) so you could even make it facts/4.2/4.2.6/myos.facts. I'm not saying we have to, but the code supports it. If we consistently have that, we can even optimize some things. We now query all facts even if we know a specific facter version is requested. We could do fact filtering prior to loading files. +1 from me on including the patch version, even bigger +1 if we modify the existing facterdb to include the patch level in the directory name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.412672.1629371747000.5160.1639500420027%40Atlassian.JIRA.


Jira (FACT-3039) Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25

2021-08-20 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  FACT-3039  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25   
 

  
 
 
 
 

 
 The alternative path would be for Facter itself to implement multiple backends, but that also feels very tricky. Without considering implementation time and complexities like migration to that and supporting older versions, I think `Puppet.runtime[:facter]` feels cleanest. It would be a very good way to really isolate the compiler from the system you run on which allows you to really pretend you're some other system (different OS, kernel etc). As for testing custom facts: I'd really like it if we could somehow make that work as well. Sadly, many custom facts use things like `Facter.value` directly. So then you're back to multiple backends in Facter itself. However, I think we can make it easier to test custom facts with better rspec-puppet integration instead.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.380977.1608048829000.112891.1629465180032%40Atlassian.JIRA.


Jira (FACT-3039) Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25

2021-08-19 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  FACT-3039  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25   
 

  
 
 
 
 

 
 Right, I missed that since it's a fairly long discussion by now. It feels weird that Puppet has a Fact indirector, but doesn't use it everywhere. I can also appreciate that a change in Puppet itself doesn't immediately solve it since we always want to be able to test on multiple versions.   We should be careful though. People do call Facter.value in their custom fact tests. Perhaps we should add first class custom fact support to rspec-puppet to provide a sane alternative. Perhaps even with let(:facts) support.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.380977.1608048829000.112029.1629381540026%40Atlassian.JIRA.


Jira (FACT-3039) Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25

2021-08-19 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  FACT-3039  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25   
 

  
 
 
 
 

 
 Would it make sense to make hooks in Puppet itself to say "use these as facts" and bypass Facter altogether? Perhaps as a fact indirector? It may need to be disabled for real fact testing, but on the other hand: that directly uses Facter APIs, not Puppet.   So then we would need to modify rspec-puppet to set a fact indirector in catalog compilation.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.380977.1608048829000.111938.1629365040027%40Atlassian.JIRA.


Jira (PUP-11050) Ruby 3 doesn't accept an opts hash

2021-04-30 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11050  
 
 
  Ruby 3 doesn't accept an opts hash   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/04/30 5:06 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 This code no longer works in Ruby 3:  
 
 
 
 
 FileUtils.install(mf, omf, {:mode => 0644, :preserve => true, :verbose => true})   
 
 
 
  This does:  
 
 
 
 
  FileUtils.install(mf, omf, mode: 0644, preserve: true, verbose: true)  
 
 
 
   
 

  
 
 
 
 

 
 
 


Jira (PUP-9473) Systemd daemon-reload doesn't get triggered for removal of unit file

2021-02-18 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-9473  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Systemd daemon-reload doesn't get triggered for removal of unit file   
 

  
 
 
 
 

 
 This showed up in https://github.com/puppetlabs/puppetlabs-postgresql/pull/1233 as well. From that PR, the root cause is that querying for the property failed:  
 
 
 
 
 # systemctl show --property=NeedDaemonReload -- postgresql  
 
 
 Failed to get properties: Access denied
  
 
 
 
  Perhaps the safest bet is to treat an access denied as needs reload.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA

Jira (PUP-2169) Not possible to manage SELinux file contexts via puppet in a sane way

2020-06-24 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-2169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Not possible to manage SELinux file contexts via puppet in a sane way   
 

  
 
 
 
 

 
 Thanks Adam Tkac! That was on my TODO list for a long time and it perfectly describes what I see with a nice minimal reproducer.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.31124.1396878028000.94545.1593021900075%40Atlassian.JIRA.


Jira (PDOC-297) Add tag for marking class parameters as "advanced"

2020-06-03 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PDOC-297  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add tag for marking class parameters as "advanced"   
 

  
 
 
 
 

 
 Initially I opened https://tickets.puppetlabs.com/browse/PDOC-267 which is more generic. Advanced is just one possible group. Should this be closed as a duplicate?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344978.1580827545000.78106.1591207800076%40Atlassian.JIRA.


Jira (PUP-2169) Not possible to manage SELinux file contexts via puppet in a sane way

2020-03-07 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-2169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Not possible to manage SELinux file contexts via puppet in a sane way   
 

  
 
 
 
 

 
 Correct. I can still reproduce this on the latest Puppet 6 RPMs (6.13.0 at the time of writing) in my acceptance tests. Those are based on beaker so using puppet apply. On the first run it applies the resources, then on the second run it runs with detailed exit codes and checks if the error code is 0. It is 2 meaning changes are applied.  
 
 
 
 
 centos7-64.example.com 20:28:34$ puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.VmGuLW  
 
 
   Info: Loading facts  
 
 
   Info: Loading facts  
 
 
   Info: Loading facts  
 
 
   Info: Loading facts  
 
 
   Info: Loading facts  
 
 
   Info: Loading facts  
 
 
   Info: Loading facts  
 
 
   Notice: Compiled catalog for centos7-64.example.com in environment production in 1.40 seconds  
 
 
   Info: Applying configuration version '1583522917'  
 
 
   Notice: /Stage[main]/Pulpcore::Install/Package[python3-pulpcore]/ensure: created  
 
 
   Notice: /Stage[ma

Jira (PUP-2169) Not possible to manage SELinux file contexts via puppet in a sane way

2020-03-06 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-2169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Not possible to manage SELinux file contexts via puppet in a sane way   
 

  
 
 
 
 

 
 Let's say I have a package foo-selinux that contains file contexts for the foo package, then the following code will not be idempotent because the cache is not refreshed:  
 
 
 
 
 package { 'foo-selinux':  
 
 
   ensure => installed,  
 
 
 }  
 
 
 -> file { '/etc/foo.conf':  
 
 
   ensure  => file,  
 
 
   content => 'The file contexts for this are in foo-selinux, but those can't be used in the same transaction',  
 
 
 }
  
 
 
 
  This can be seen with the Red Hat SCL packages (rh-redis5, rh-postgresql12) which are not in the base policy but also with our custom software (pulpcore-selinux, candlepin-selinux, foreman-selinux, katello-selinux). Our installer now has to pre-install those packages. It's made worse by the fact that puppetlabs-postgresql doesn't manage the file resource so on the first run it gets the incorrect file contexts and it's never corrected, not even on the second run.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

Jira (PUP-2169) Not possible to manage SELinux file contexts via puppet in a sane way

2020-03-06 Thread Ewoud Kohl van Wijngaarden (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-2169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Not possible to manage SELinux file contexts via puppet in a sane way   
 

  
 
 
 
 

 
 Since it's reverted, should this be opened again? This is really annoying and I'm starting to implement workarounds to get idempotency.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.31124.1396878028000.6276.1583489760033%40Atlassian.JIRA.


Jira (PUP-10101) Support EPP in PAL

2019-10-14 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10101  
 
 
  Support EPP in PAL   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2019/10/14 6:30 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 Within puppet-syntax there's functionality to validate .epp files. Currently this uses internal Puppet API's, but using a formal API in PAL would be more future proof. Quoting Henrik Lindberg from https://github.com/voxpupuli/puppet-syntax/pull/108#issuecomment-538759867 [quote] I do think PAL should support EPP as well with functionality for parse, validate, and evaluate just like for regular manifests. [/quote]  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#

Jira (PUP-10094) Implement a PAL parse() with custom validation handling

2019-10-06 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10094  
 
 
  Implement a PAL parse() with custom validation handling   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2019/10/06 3:26 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 The use case is puppet-syntax where it's desired to fully parse a file and show all warnings/errors. This is useful in CI or other systems. Currently it's using a Puppet face but this is deprecated. In https://github.com/voxpupuli/puppet-syntax/pull/108 I've investigated switching to Puppet PAL but ran into limitations. Internally it's using the IssueReporter class that's inflexible. Quoting Henrik Lindberg from https://github.com/voxpupuli/puppet-syntax/pull/108#issuecomment-538725665 
 
You are correct - there is no PAL parse() operation without validation. That means it will end up in the standard issueReporter (which is only somewhat configurable). The way to capture the output would be by having a logger - i.e. similar to logging to a file ending with .json which makes the logger write json instead of formatted text. I think it is reasonable to add a feature to PAL to make it possible to give parse a kind of "acceptor" to get warnings/errors etc. When implementing that we can make sure it only exposes public API. 
  
 

  
 
 
 
 

 
 
 

 
 
  

Jira (PDOC-267) Grouping of parameters

2019-05-29 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PDOC-267  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Grouping of parameters   
 

  
 
 
 
 

 
 Yes, this is still an important use case for us. I have played around a bit, but couldn't find an easy way to implement it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.275678.1536876963000.24309.1559117040145%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-523) Make it possible to declare classes, defines and functions (and more) as private to a module

2019-03-07 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-523  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make it possible to declare classes, defines and functions (and more) as private to a module   
 

  
 
 
 
 

 
 Perhaps it'd be a good idea to split the effort. Clearly there's already an existing workflow around private classes, so that could be formalized. Having private parameters could be considered out of scope. This would allow the ecosystem to standardize and improve.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-523) Make it possible to declare classes, defines and functions (and more) as private to a module

2019-03-04 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-523  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make it possible to declare classes, defines and functions (and more) as private to a module   
 

  
 
 
 
 

 
 From a Foreman perspective I'll second what Eric Sorenson said: 
 
FWIW the only part of this proposal I have heard users ask for is marking classes private, so they do not show up for assignment in the console classifier and are not enumerated with the environment_classes endpoint.
 Currently we provide an import regex filter, but obviously this is far from optimal. Module authors are in the best position to identify which classes are private and if the HTTP API would expose this information, then we could filter them out. When we think about backwards compatibility then there are 2 ways (that I know of) to make a class "private". 
 
Puppet Strings' @api private documentation marker 
puppetlabs-stdlib's assert_private() function 
 The function has the downside that you need stdlib to be present and the Puppetserver shouldn't code to specific modules. IMHO this isn't a realistic option. I don't know if Puppetserver currently parses Puppet Strings. If it doesn't, then that's a downside that. It could have an additional benefit of also exposing the parameter documentation. An ENC interface could use this to provide meaningful documentation to end users.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

 

Jira (PUP-9505) Fact yaml should quote mac addresses.

2019-02-20 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PUP-9505  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Fact yaml should quote mac addresses.   
 

  
 
 
 
 

 
 And Python does yet something else:  
 
 
 
 
 $ echo "import yaml ; print(yaml.load('macaddress: 52:54:00:44:49:56'))" | python  
 
 
 {'macaddress': 41135201396}  
 
 
 $ echo "import yaml ; print(yaml.load('macaddress: 52:54:00:44:49:56'))" | python3  
 
 
 {'macaddress': 41135201396}
  
 
 
 
  Long term it might be better to store this as JSON.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

   

Jira (PUP-9243) Puppet CA HTTP API does not include serial/not_before/not_after

2018-10-17 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9243  
 
 
  Puppet CA HTTP API does not include serial/not_before/not_after   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/10/17 6:46 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 In Puppet before version 6 puppet cert list would show serial/not_before/not_after. Within our tool we used to wrap the command line tools and used this information. We're now moving to the HTTP API (as we should have some time ago). Could these fields be added to the HTTP API? Note that Puppet 6 on the command also doens't list the fields.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  

Jira (PDOC-267) Grouping of parameters

2018-09-13 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Strings /  PDOC-267  
 
 
  Grouping of parameters   
 

  
 
 
 
 

 
Change By: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 Currently we have a [kafo_parsers gem|https://github.com/theforeman/kafo_parsers] that also has RDoc support. RDoc has the option to group parameters. In our installer we use this to hide advanced groups with --help but do show them with --full-help. I would like to fully move to puppet-strings so we can drop our RDoc backend but then we need such a feature.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDOC-267) Grouping of parameters

2018-09-13 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Strings /  PDOC-267  
 
 
  Grouping of parameters   
 

  
 
 
 
 

 
Issue Type: 
  New Feature  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/09/13 3:16 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group a

Jira (PDOC-168) drop requirement for RGen gem for Puppet 5.0.0

2018-03-01 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PDOC-168  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: drop requirement for RGen gem for Puppet 5.0.0   
 

  
 
 
 
 

 
 I have no problem with that. Now that the dependency is in the gemspec I can remove the manual specification from my gemfiles.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDOC-224) puppet-strings 1.2.0 breaks --emit-json-stdout

2018-03-01 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Strings /  PDOC-224  
 
 
  puppet-strings 1.2.0 breaks --emit-json-stdout   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/03/01 4:26 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ewoud Kohl van Wijngaarden  
 

  
 
 
 
 

 
 With puppet-strings 1.2.0  
 
 
 
 
 $ puppet strings generate --emit-json-stdout ~/dev/puppet-tftp/manifests/init.pp  
 
 
 WARNING: '--emit-json-stdout' is deprecated. Use '--format json' instead.  
 
 
 100.00% documented  
 
 
 
  With puppet-strings 1.1.0  
 
 
 
 
 $ puppet strings generate --emit-json-stdout ~/dev/puppet-tftp/manifests/init.pp  
 
 
 {  
 
  

Jira (PDOC-168) drop requirement for RGen gem for Puppet 5.0.0

2018-03-01 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ewoud Kohl van Wijngaarden commented on  PDOC-168  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: drop requirement for RGen gem for Puppet 5.0.0   
 

  
 
 
 
 

 
 1.2.0 at least added the rgen dependency.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDOC-168) drop requirement for RGen gem for Puppet 5.0.0

2017-09-07 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ewoud Kohl van Wijngaarden commented on  PDOC-168 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: drop requirement for RGen gem for Puppet 5.0.0  
 
 
 
 
 
 
 
 
 
 
Right now we add rdoc to our Gemfile if we need puppet-strings with Puppet 5 because puppet-strings does use it, but doesn't list it as a dependency. Until the dependency is no longer needed, it should be listed in puppet-strings dependencies. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDOC-168) drop requirement for RGen gem for Puppet 5.0.0

2017-09-07 Thread Ewoud Kohl van Wijngaarden (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ewoud Kohl van Wijngaarden commented on  PDOC-168 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: drop requirement for RGen gem for Puppet 5.0.0  
 
 
 
 
 
 
 
 
 
 
In the meantime it would be very helpful if a puppet-strings gem was released which depends on rgen. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.