Jira (PUP-3729) Puppet package incorrectly starts service on install
Title: Message Title James Shubin created an issue Puppet / PUP-3729 Puppet package incorrectly starts service on install Issue Type: Bug Affects Versions: PUP 3.7.3 Assignee: Unassigned Components: Puppet Server Created: 2014/12/03 5:46 AM Priority: Blocker Reporter: James Shubin The yum.puppetlabs rpm's contain the following: [root@puppet ~]# rpm -q --scripts puppet ... postinstall scriptlet (using /bin/sh): /bin/systemctl daemon-reload /dev/null 21 || : if [ $1 -ge 1 ]; then The pidfile changed from 0.25.x to 2.6.x, handle upgrades without leaving the old process running. oldpid=/var/run/puppet/puppetd.pid newpid=/var/run/puppet/agent.pid if [ -s $oldpid -a ! -s $newpid ]; then (kill $( $oldpid) rm -f $oldpid \ /bin/systemctl start puppet.service) /dev/null 21 || : fi fi ... [root@puppet ~]# rpm -qi puppet Name : puppet Version : 3.7.3 Release : 1.el7
Jira (PUP-3729) Puppet package incorrectly starts service on install
Title: Message Title James Shubin commented on PUP-3729 Re: Puppet package incorrectly starts service on install FYI: The EPEL package does not do this. CC: vkaig...@redhat.com please. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3404) helper functions in custom function
Title: Message Title
James Shubin commented on an issue
Re: helper functions in custom function
If you'll allow me a small rant:
This feature (allowing helper functions) somehow dissapeared, as it used to work just fine. I consider this a huge regression, and taking it out without notice, is no way to convince users that puppetlabs is able to maintain stable releases, if the upstream does this. It's also a very useful feature, so seeing this go is sad.
/rant
In reply to Andy Parker:
Please use PuppetX::ModuleOwnerName::ModuleName. This pattern will avoid collisions with other modules. For example at puppetlabs for the foo module we would put extra helpers in PuppetX::Puppetlabs::Foo.
DON'T do this. It will guarantee that your module is unforkable. binford2k agrees, and instead suggests: 13:48 @binford2k Maybe PuppetX::Modulename::Helpers then
Cheers, James
Add Comment
Puppet / PUP-3404
helper functions in custom function
Hi, I have a problem with helper functions in custom function My puppet-Version: v3.7.1 If you need more information, let me know. My custom function in very short from, but with the same error. {noformat} module Puppet::Parser::Functions newfunction(:httpd_modules, :type = :rvalue) do |args| def helper_function(value) value e...
This message was sent by Atlassian JIRA
Jira (PUP-3404) helper functions in custom function
Title: Message Title
James Shubin commented on an issue
Re: helper functions in custom function
RE: Charlie,
Interesting, I did not consider the ruby version differences, but I was fairly sure this was working with Ruby 2.0.0 at some point. In any case, this should work IMO, because the amount of boilerplate required to add a function is terrible. I also don't like the forced splitting up of different functions that should really be the same. The lambda approach works great, which is what I was using this as. Thanks for looking into this.
Add Comment
Puppet / PUP-3404
helper functions in custom function
Hi, I have a problem with helper functions in custom function My puppet-Version: v3.7.1 If you need more information, let me know. My custom function in very short from, but with the same error. {noformat} module Puppet::Parser::Functions newfunction(:httpd_modules, :type = :rvalue) do |args| def helper_function(value) value e...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from
Jira (PUP-3404) helper functions in custom function
Title: Message Title
James Shubin commented on an issue
Re: helper functions in custom function
RE: Henrik,
Sounds like an improvement! Is there any documentation on this that I can look at?
Thanks, James
Add Comment
Puppet / PUP-3404
helper functions in custom function
Hi, I have a problem with helper functions in custom function My puppet-Version: v3.7.1 If you need more information, let me know. My custom function in very short from, but with the same error. {noformat} module Puppet::Parser::Functions newfunction(:httpd_modules, :type = :rvalue) do |args| def helper_function(value) value e...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3404) helper functions in custom function
Title: Message Title
James Shubin commented on an issue
Re: helper functions in custom function
RE: Henrik,
Cool... So to confirm, would this be a valid function:
code Puppet::Functions.create_function(:foo) do def foo(bar, baz) def inner_foo(inner_bar, inner_baz) return inner_bar+inner_baz end return 42+inner_foo(bar, baz) end end /code ?
Thanks, James
Add Comment
Puppet / PUP-3404
helper functions in custom function
Hi, I have a problem with helper functions in custom function My puppet-Version: v3.7.1 If you need more information, let me know. My custom function in very short from, but with the same error. {noformat} module Puppet::Parser::Functions newfunction(:httpd_modules, :type = :rvalue) do |args| def helper_function(value) value e...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-2813) Puppet parser is totally broken in this weird way
Title: Message Title
James Shubin created an issue
Puppet / PUP-2813
Puppet parser is totally broken in this weird way
Issue Type:
Bug
Affects Versions:
3.6.2
Assignee:
Unassigned
Created:
20/Jun/14 12:04 AM
Environment:
GNU/Linux
Priority:
Critical
Reporter:
James Shubin
run this code:
exec { '/bin/echo aaa': alias = 'aaa', }
exec { '/bin/echo bbb': alias = 'bbb', }
$r1 = [ Exec['aaa'], Exec['bbb'], ]
$x = [Exec['xxx']] $r2 = concat($r1, $x)
exec { '/bin/echo ccc': alias = 'ccc', # note that $r2 is commented out... require = $r1, #require = $r2, }
exec { '/bin/echo xxx': alias = 'xxx', # if we are using $r2 this should be a dependency loop... BUT require = Exec['ccc'], }
LOL it is anyways...
Jira (PUP-2813) Puppet parser is totally broken in this weird way
Title: Message Title
James Shubin commented on an issue
Re: Puppet parser is totally broken in this weird way
It's late, so maybe I'm just doing something silly, otherwise the parser is doing some really strange things. This should give you enough to reproduce, and tracking down this bug will hopefully find some serious scary bug or programming error in puppet. Thanks and goodluck!
Add Comment
Puppet / PUP-2813
Puppet parser is totally broken in this weird way
# run this code: exec { '/bin/echo aaa': alias = 'aaa', } exec { '/bin/echo bbb': alias = 'bbb', } $r1 = [ Exec['aaa'], Exec['bbb'], ] $x = [Exec['xxx']] $r2 = concat($r1, $x) exec { '/bin/echo ccc': alias = 'ccc', # note that $r2 is commented out... require = $r1, #require = $r2, } exec { '/bin/echo xxx': ali...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at
