Jira (PUP-3930) Applying catalogs spends an inordinate amount of time checking for failed dependencies.
Title: Message Title Nelson Elhage created an issue Puppet / PUP-3930 Applying catalogs spends an inordinate amount of time checking for failed dependencies. Issue Type: Bug Assignee: Kylo Ginsberg Components: Catalog Application Created: 2015/01/30 10:36 AM Priority: Normal Reporter: Nelson Elhage I profiled `puppet agent --test` on one of my servers using stackprof [1] on Ruby 2.1. Something like 30% or more of the time was spent in `Puppet::Graph::SimpleGraph#upstream_from_vertex`, called from `Puppet::Transaction#failed_dependencies?` It turns out that, while evaluating the resource graph, when considering a resource, we look at the complete set of transitive dependencies to evaluate whether any of them have failed. This is hugely expensive, and moreover, is completely wasted work in the success case where no resources have failures. Add Comment
Jira (PUP-3930) Applying catalogs spends an inordinate amount of time checking for failed dependencies.
Title: Message Title Nelson Elhage commented on PUP-3930 Re: Applying catalogs spends an inordinate amount of time checking for failed dependencies. I have a proof-of-concept patch to fix this, but I'm waiting on approval from my legal team to sign the Puppet Labs CLA. I'll attach it once that's done. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3930) Applying catalogs spends an inordinate amount of time checking for failed dependencies.
Title: Message Title Nelson Elhage commented on PUP-3930 Re: Applying catalogs spends an inordinate amount of time checking for failed dependencies. PR: https://github.com/puppetlabs/puppet/pull/3591 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
