Jira (PUP-1707) Faces help sometimes blows up when descriptions are absent
Title: Message Title Nicholas Fagerlund created an issue Puppet / PUP-1707 Faces help sometimes blows up when descriptions are absent Issue Type: Bug Assignee: Nicholas Fagerlund Created: 14/Feb/14 12:01 PM Fix Versions: 3.5.0 Priority: Normal Reporter: Nicholas Fagerlund Right now, puppet man config will explode, because there's no description for the --section option. This isn't the intended behavior; it should devolve gracefully to the summary if the description is missing. We're navely doing gsub on a value that might be nil. Add Comment This message was
Jira (PUP-1618) Confusing valid values documentation for exec logoutput
Title: Message Title Nicholas Fagerlund assigned an issue to Nicholas Fagerlund Puppet / PUP-1618 Confusing valid values documentation for exec logoutput Change By: Nicholas Fagerlund Assignee: NicholasFagerlund Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-1618) Confusing valid values documentation for exec logoutput
Title: Message Title
Nicholas Fagerlund commented on an issue
Re: Confusing valid values documentation for exec logoutput
Yup, this sure seems to not accept valid log levels.
exec {/opt/local/bin/cowsay 'She only comes out at night / The lean and hungry type':
logoutput = 'debug',
}
Looking into the code now, try and figure out if it used to.
Add Comment
Puppet / PUP-1618
Confusing valid values documentation for exec logoutput
On the page http://docs.puppetlabs.com/references/latest/type.html#exec it says {quote}blogout/b ...In addition to the values below, you may set this attribute to any legal log level. Valid values are true, false, on_failure.{quote} Huh? So a legal log level is a value, but is not a valid value? ;-) Testing would indicate that log levels...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you
Jira (PUP-1618) Confusing valid values documentation for exec logoutput
Title: Message Title
Nicholas Fagerlund commented on an issue
Re: Confusing valid values documentation for exec logoutput
Found it. Up through 0.24.1:
newparam(:logoutput) do
desc Whether to log output. Defaults to logging output at the
loglevel for the ``exec`` element. Values are **true**, *false*,
and any legal log level.
values = [:true, :false]
# And all of the log levels
Puppet::Util::Log.eachlevel { |level| values level }
newvalues(*values)
end
Apparently this never actually worked, though! Or at least that's what Luke implied in commit bb8051bc406d1da67db8212e852bb36d1368e953 (between 0.24.1 and 0.24.2) when he removed it. He didn't update the parameter description string at the same time though, so it's stayed wrong since 2008.
Add Comment
Puppet / PUP-1618
Confusing valid values documentation for exec logoutput
On the page http://docs.puppetlabs.com/references/latest/type.html#exec it says {quote}blogout/b ...In addition to the values below, you may set this attribute to any legal log level. Valid values are true, false, on_failure.{quote} Huh? So a legal log level is a value, but is not a valid value? ;-) Testing would indicate that log levels...
Jira (PUP-1618) Confusing valid values documentation for exec logoutput
Title: Message Title
Nicholas Fagerlund commented on an issue
Re: Confusing valid values documentation for exec logoutput
Once the travis build finishes, I'm going to fast-track the merge. I'll also do a mass-fix on existing docs, since this is actively misleading instead of just vague.
Add Comment
Puppet / PUP-1618
Confusing valid values documentation for exec logoutput
On the page http://docs.puppetlabs.com/references/latest/type.html#exec it says {quote}blogout/b ...In addition to the values below, you may set this attribute to any legal log level. Valid values are true, false, on_failure.{quote} Huh? So a legal log level is a value, but is not a valid value? ;-) Testing would indicate that log levels...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit
Jira (PUP-1562) certnames with @ symbols don't pass through auth.conf
Title: Message Title Nicholas Fagerlund commented on an issue Re: certnames with @ symbols don't pass through auth.conf This had a pull request which was closed because Spencer was slammed and didn't have time to guide it through the last stages of review/revision. I also worked on identifying the problem and the possible fix. Add Comment Puppet / PUP-1562 certnames with @ symbols don't pass through auth.conf In lib/puppet/network/authstore.rb line 242ish a case statement deals with certnames with @ symbols in way that makes it so that they'll never match auth.conf rules for hosts. The easy workaround is, of course, not to use certnames with at symbols. We really ought to stop conflating host, name and certname in this area of code also, because it makes i... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at
Jira (PUP-1525) When extracting type docs for metadata.json, we should scrub leading whitespace
Title: Message Title Nicholas Fagerlund created an issue Puppet / PUP-1525 When extracting type docs for metadata.json, we should scrub leading whitespace Issue Type: Bug Assignee: Eric Sorenson Created: 27/Jan/14 2:29 PM Priority: Normal Reporter: Nicholas Fagerlund When building a module for publishing to the Forge, SOMETHING in the toolchain is extracting the doc strings from any native resource types in the module and inserting them into metadata.json. Unfortunately, it isn't running Puppet::Util::Docs.scrub on the fragments before storing them, so you end up with mangled display on the forge. For an example, see the Forge version of the docs for the file_line type in the stdlib module. We need to locate the place where these strings are being extracted for metadata.json, and insert a few judicious scrub calls. Anyone know where that thing is? I couldn't find it, the last time I went looking. Add Comment
Jira (PUP-640) Report format 4 docs should be updated for optional fields
Title: Message Title Nicholas Fagerlund commented on an issue Re: Report format 4 docs should be updated for optional fields Michelle Johansen Yes. Add Comment Puppet / PUP-640 Report format 4 docs should be updated for optional fields In PE 3.1.0/Puppet 3.3.1 the report format changed to include a new kind of event, which is not associated with a property, for some failures that previously did not have an event. This has caused a change in the report format because these events do not always have previous_value, property, desired_value, name, and historical_value. Some of these get tra... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
