Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title David Kramer assigned an issue to Unassigned Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: David Kramer Assignee: Kate Lopresti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Kate Lopresti updated an issue Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Kate Lopresti Labels: DOCS docs docs-reviewed feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Michael Smith assigned an issue to Kate Lopresti Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Michael Smith Assignee: Kate Lopresti Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Michael Smith Assignee: Alex Dreyer Michael Smith Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Alex Dreyer Fix Version/s: BOLT Next Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer commented on BOLT-454 Re: Plans should return undef without an explicit return I'd like us to have a larger conversations about what parts of the plan language belong in the bolt repo and what belong in puppet as we move toward 1.0 anyway. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Henrik Lindberg commented on BOLT-454 Re: Plans should return undef without an explicit return Oh - that is a bug actually - but it enables BOLT to fix that. Not sure if that is a happy path long term. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer commented on BOLT-454 Re: Plans should return undef without an explicit return :return is not caught in call_by_name_with_scope it bubbles up through the run_plan function. In order for us to handle the return value in run_plan we have to catch return there. https://github.com/puppetlabs/bolt/blob/master/bolt-modules/boltlib/lib/puppet/functions/run_plan.rb#L52 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Henrik Lindberg commented on BOLT-454 Re: Plans should return undef without an explicit return This ticket moved to a BOLT ticket. The change needs to be made in Puppet code base (as per my first comment) - so it needs a PUP ticket to be merged... How did you see this working otherwise? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Alex Dreyer Release Notes Summary: Plans will no longer return the value of the last line implicitly. They will return undef unless the return function is called. Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Michael Smith assigned an issue to Alex Dreyer Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Michael Smith Assignee: Michael Smith Alex Dreyer Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Michael Smith Assignee: Alex Dreyer Michael Smith Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title David Kramer assigned an issue to Alex Dreyer Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: David Kramer Assignee: Michael Smith Alex Dreyer Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title David Kramer assigned an issue to Michael Smith Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: David Kramer Assignee: Michael Smith Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer assigned an issue to Unassigned Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Alex Dreyer Assignee: Michal Ruzicka Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Alex Dreyer Since we can log intermediate results and error on failure returning the entirety of the last line often clutters and obscures meaningful output. Some users have reported returning static strings to prevent this. Plans that called from other plans may expose an unintentional and unstable API due to this as well.Solution:The result of a plan should be undef unless there is an explicit return statement in the plan.Questions:Is it useful in simple plans to return the last value? No, simple plans can rely on logging and default error handling.Is this too much of a differentiation from puppet functions? No, Plans are not functions and are usually run for side effects whereas functions are usually run for their return value in the plan language. Making this difference explicit makes it's clearer to users when to write a sub-plan vs a dsl function. Additional Scope:When the result of a plan is undef the human output format should print:"Plan completed successfully with no result" instead of null Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (BOLT-454) Plans should return undef without an explicit return
Title: Message Title Michal Ruzicka moved an issue Puppet Task Runner / BOLT-454 Plans should return undef without an explicit return Change By: Michal Ruzicka Key: PUP BOLT - 8608 454 Project: Puppet Task Runner Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
