Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Michael Smith updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Michael Smith Fix Version/s: FACT 3.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Phong Ly commented on FACT-1482 Re: mountpoints fact does not show mounts on tmpfs create FACT-1502 for the acceptance test for this. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Phong Ly assigned an issue to Phong Ly Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Phong Ly Assignee: qa Phong Ly Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title John Duarte assigned an issue to qa Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: John Duarte Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Michael Smith commented on FACT-1482 Re: mountpoints fact does not show mounts on tmpfs I'd like to see an acceptance test on this. We should be able to mount a tmpfs directory and check the fact. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Eric Thompson updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Eric Thompson QA Risk Assessment: High Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Andrew Henroid assigned an issue to Andrew Henroid Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Andrew Henroid Assignee: Andrew Henroid Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title David Kramer updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: David Kramer Sprint: Client 2016-09- 21 07 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title David Kramer updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: David Kramer Sprint: Client 2016-09- 07 21 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title David Kramer updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: David Kramer Sprint: Client Triage 2016-09-07 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title David Kramer updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: David Kramer Fix Version/s: FACT 3.4.1 Fix Version/s: FACT 3.4.2 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Ryan Whitehurst commented on FACT-1482 Re: mountpoints fact does not show mounts on tmpfs FWIW, I was really confused by a similar thing today when I was looking for nfs mounts and they weren't showing up. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Peter Huene updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Peter Huene Story Points: 1 Sprint: Client Triage Fix Version/s: FACT 3.4.1 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Peter Huene commented on FACT-1482 Re: mountpoints fact does not show mounts on tmpfs It's been a while, but I believe the check to filter out non-device mounts from mountpoints was to prevent lookup of partition data for mountpoints that don't map to physical device. It looks like the check was done in the wrong place, namely it should be when collecting the partition data and not when filtering the mountpoints themselves. I believe this should be addressed by moving this check https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L79-L82 to https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L140, prior to inserting the entry in the map. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Nick Walker updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Nick Walker Affects Version/s: FACT 3.4.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title Nick Walker updated an issue Facter / FACT-1482 mountpoints fact does not show mounts on tmpfs Change By: Nick Walker CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1482) mountpoints fact does not show mounts on tmpfs
Title: Message Title
Nick Walker created an issue
Facter / FACT-1482
mountpoints fact does not show mounts on tmpfs
Issue Type:
Bug
Assignee:
Unassigned
Created:
2016/08/09 8:57 AM
Labels:
tcse
Priority:
Normal
Reporter:
Nick Walker
The Problem
I expect the mountpoints fact to return all mounts not just those mapped to physical devices.
https://docs.puppet.com/facter/latest/core_facts.html#mountpoints
However it looks like we explicitly skip mounts that don't map to a device.
https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L79-L82
This came up when I was trying to discover if /tmp was mounted as noexec. During testing we tried to mount /tmp on tmpfs with noexec and it wasn't returned in the mountpoints fact.
Reproduction
mount { '/tmp' :
