Jira (FACT-1794) os.family.major incorrectly returns a number with a decimal point for Ubuntu
Title: Message Title Branan Riley commented on FACT-1794 Re: os.family.major incorrectly returns a number with a decimal point for Ubuntu In this case, I would expect os.realease.full to be "16.04.3", which would make having the two fields useful, and would make our interpretation of what's the "major" part make more sense. We likely won't fix this until Facter 4, since messing with fact values in stable releases is always frustrating to users. There was definitely an intentional decision to treat the date portion of an Ubuntu release as a single field for the sake of splitting up the version. If you think of a set of Red Hat releases like '7.1', '7.2', '7.3' all grouped as 'Red Hat 7', the same pattern for Ubuntus is '16.04.1', '16.04.2', '16.04.3' being grouped as 'Ubuntu 16.04' We want the major field to have the same semantics in both cases. Ubuntu's usage of a period in the date field is unfortunate, because it makes it look like it should be an X.Y.Z version. It is not. The correct way to parse it is [date].[patch]. Trying to report just the year from an Ubuntu release is of similar fragility to saying "Fedora 25 and 26 are similar enough that I can manage both with the same code - I want Facter to report version '2' to me". You're welcome to use a custom fact if you really, really need that capability, but it's not a pattern I would want to encourage most users to follow. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1794) os.family.major incorrectly returns a number with a decimal point for Ubuntu
Title: Message Title garrett honeycutt commented on FACT-1794 Re: os.family.major incorrectly returns a number with a decimal point for Ubuntu You can use os.release.full to get 16.04 or 16.10 so having .major mirror .full is not useful. I want to support Ubuntu x.04 LTS along with the x.10. In the past this was done with os.release.major and now that fails. It seems wrong to go back to using regex matching against the data instead of dictating that .major would just be number before a separator. This behavior is intuitive and the current behavior violates least surprise. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1794) os.family.major incorrectly returns a number with a decimal point for Ubuntu
Title: Message Title Michael Smith commented on FACT-1794 Re: os.family.major incorrectly returns a number with a decimal point for Ubuntu 16 is not an Ubuntu release, so that would be misleading. Ubuntu uses two-part codes to denote a release, i.e. 16.04 and 16.10. This was an intentional change as part of FACT-976 to treat e.g. 16.04 as the major release version for an Ubuntu release. Windows has similar constraints: Windows 8, 8.1, 2012, and 2012 R2 are all treated as major versions. Facter 3 does not provide a guarantee of the acceptance criteria you included. Is there some reason that's untenable? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1794) os.family.major incorrectly returns a number with a decimal point for Ubuntu
Title: Message Title
garrett honeycutt created an issue
Facter / FACT-1794
os.family.major incorrectly returns a number with a decimal point for Ubuntu
Issue Type:
Bug
Assignee:
Unassigned
Created:
2017/11/03 8:35 AM
Priority:
Normal
Reporter:
garrett honeycutt
os.release.major is used to determine the major release of a series and should never have a decimal place in it. So if os.release.full is 7.1 then major would be 7 and Ubuntu 16.04 would be 16.
facterversion => 3.6.7
os => {
architecture => "amd64",
distro => {
