Jira (FACT-2493) Test community supported modules with Facter 4

2020-03-25 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau commented on  FACT-2493  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Test community supported modules with Facter 4   
 

  
 
 
 
 

 
 for https://github.com/voxpupuli/puppet-prometheus the test_with_coveralls are passing with Facter 4:   
 
 
 
 
 Finished in 5 minutes 5 seconds (files took 17.56 seconds to load)  
 
 
 280 examples, 0 failuresCoverage report generated for (1/8), (2/8), (3/8), (4/8), (5/8), (6/8), (7/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-prometheus/coverage. 4 / 7 LOC (57.14%) covered.COVERAGE:  57.14% -- 4/7 lines in 1 files+--+-+---++-+  
 
 
 | coverage | file| lines | missed | missing |  
 
 
 +--+-+---++-+  
 
 
 |  57.14%  | lib/facter/alert_manager_running.rb | 7 | 3  | 7-8, 10 |  
 
 
 +--+-+---++-+2555 examples, 0 failuresTook 323 seconds (5:23)  
 
 
 [Coveralls] Outside the CI environment, not sending data.   
 
 
 
   
 
 
 
 
 mihai:puppet-prometheus mihai.buzgau$ bundle exec facter --version  
 
 
 4.0.12   
 
 

Jira (FACT-2493) Test community supported modules with Facter 4

2020-03-25 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau commented on  FACT-2493  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Test community supported modules with Facter 4   
 

  
 
 
 
 

 
 https://github.com/voxpupuli/puppet-zabbix test_with_coveralls are passing with Facter 4:  
 
 
 
 
 8 processes for 18 specs, ~ 2 specs per process  
 
 
 ...Finished in 6.91 seconds (files took 3.85 seconds to load)  
 
 
 139 examples, 0 failuresCoverage report generated for (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 71 / 548 LOC (12.96%) covered.COVERAGE:  12.96% -- 71/548 lines in 16 files+--+---+---++---  
 
 
 3 file(s) with 100% coverage not shown.Finished in 52.49 seconds (files took 2 minutes 23.7 seconds to load)  
 
 
 235 examples, 0 failures.Coverage report generated for (2/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 71 / 548 LOC (12.96%) covered.COVERAGE:  12.96% -- 71/548 lines in 16 files.+--+---+---++-+  
 
 

Jira (FACT-2493) Test community supported modules with Facter 4

2020-03-25 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau assigned an issue to Mihai Buzgau  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2493  
 
 
  Test community supported modules with Facter 4   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Assignee: 
 Mihai Buzgau  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.351076.1585132739000.20332.1585133580103%40Atlassian.JIRA.


Jira (FACT-2493) Test community supported modules with Facter 4

2020-03-25 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau commented on  FACT-2493  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Test community supported modules with Facter 4   
 

  
 
 
 
 

 
 https://github.com/voxpupuli/puppet-collectd The tests for test_with_coveralls pass using Facter 4:  
 
 
 
 
 ** Invoke parallel_spec_standalone (first_time)  
 
 
 ** Execute parallel_spec_standalone  
 
 
 8 processes for 113 specs, ~ 14 specs per process  
 
 
 No facts were found in the FacterDB for Facter v3.14.0, using v3.9.0 instead  
 
 
 ...Finished in 1 minute 26.83 seconds (files took 56.52 seconds to load)  
 
 
 230 examples, 0 

Jira (FACT-2493) Test community supported modules with Facter 4

2020-03-25 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau commented on  FACT-2493  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Test community supported modules with Facter 4   
 

  
 
 
 
 

 
 https://github.com/simp/pupmod-simp-simp has a dependency simp-rspec-puppet-facts: https://github.com/simp/pupmod-simp-simp/blob/master/Gemfile#L19 The simp-rspec-puppet-facts __ gem has a runtime dependency to Facter that locks the Facter gem to >= 2.5.0, < 3.0: https://github.com/simp/rubygem-simp-rspec-puppet-facts/blob/master/simp-rspec-puppet-facts.gemspec#L24 All the modules that use this gem will not get the Facter 4 bump.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.351076.1585132739000.20330.1585133340035%40Atlassian.JIRA.


Jira (FACT-2493) Test community supported modules with Facter 4

2020-03-25 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2493  
 
 
  Test community supported modules with Facter 4   
 

  
 
 
 
 

 
Issue Type: 
  Task  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Facter 4  
 
 
Created: 
 2020/03/25 3:38 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Mihai Buzgau  
 

  
 
 
 
 

 
 Test the following modules with Facter 4: - https://github.com/simp/pupmod-simp-simp - https://github.com/voxpupuli/puppet-collectd - https://github.com/voxpupuli/puppet-zabbix - https://github.com/voxpupuli/puppet-prometheus  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was