Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Josh Cooper Labels: regression Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70841.1673290620181%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper commented on FACT-2772 Re: Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Facter 3 correctly detects recursive invocations. It can be triggered by removing --no-custom-facts --no-external-facts from the external fact. # facter --version 3.14.24 (commit 91ed8a2de5c9d686345859fe12ea2914415758f0) # head -3 /opt/puppetlabs/facter/facts.d/fact.sh #!/usr/bin/env ruby require 'json' osfamily = %x(/opt/puppetlabs/bin/facter os.family).strip # puppet facts show packages Warning: Facter: external fact file "/opt/puppetlabs/facter/facts.d/fact.sh" had output on stderr: 2023-01-09 18:48:52.300856 WARN puppetlabs.facter - external fact file "/opt/puppetlabs/facter/facts.d/fact.sh" had output on stderr: 2023-01-09 18:48:51.842723 WARN puppetlabs.facter - Facter was called recursively, skipping external facts. Add '--no-external-facts' to silence this warning Facter 4 does not guard against recursion:
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Josh Cooper Component/s: Facter 4 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70840.1673290620134%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Josh Cooper updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Josh Cooper
After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion {noformat} #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom- fact facts --no-external-facts os.family).strip@data = ""> packages: {}}def parse_redhat packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endendif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debianendputs @data.to_json{noformat} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}
Add Comment
This message was sent
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Josh Cooper updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Josh Cooper
After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion { code:shell noformat } #!/usr/bin/env rubyrequire 'json' osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = ""> packages: {}}def parse_redhat packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip end endif endif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debian endputs endputs @data.to_json{ code noformat } I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}
Add Comment
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Josh Cooper updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Josh Cooper
After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion {code: java shell } #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = ""> packages: {}} def parse_redhat packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endendif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}
Add Comment
This message was sent
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Josh Cooper updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Josh Cooper
After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:shell} #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = ""> packages: {}}def parse_redhat packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endendif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}
Add Comment
This message was sent by
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Josh Cooper updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Josh Cooper
After updating puppet to verision 6.18.0-1, the following script, located in ` / opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:java}#!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = ""> packages: {}}def parse_redhat packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endendif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}
Add Comment
This message was sent by
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Ciprian Badescu updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Ciprian Badescu Labels: needs_repro Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.149732.1633598760820%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Gabriel Nagy commented on FACT-2772 Re: Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Boris I cannot reproduce this with the latest Facter 3. If I remove --no-external-facts from the facter call it shows a warning but still doesn't recurse: Warning: Facter: external fact file "/opt/puppetlabs/facter/facts.d/fact.rb" had output on stderr: 2021-10-04 10:38:30.349709 WARN puppetlabs.facter - external fact file "/opt/puppetlabs/facter/facts.d/fact.rb" had output on stderr: 2021-10-04 10:38:29.918306 WARN puppetlabs.facter - Facter was called recursively, skipping external facts. Add '--no-external-facts' to silence this warning Warning: Facter: external fact file "/opt/puppetlabs/facter/facts.d/fact.rb" had output on stderr: 2021-10-04 10:38:31.647756 WARN puppetlabs.facter - external fact file "/opt/puppetlabs/facter/facts.d/fact.rb" had output on stderr: 2021-10-04 10:38:31.219910 WARN puppetlabs.facter - Facter was called recursively, skipping external facts. Add '--no-external-facts' to silence this warning Same with Facter 4. I tested this both with facter -p and puppet facts. Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Ciprian Badescu updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Ciprian Badescu Labels: needs_repro Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.145664.164640090%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Ciprian Badescu updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Ciprian Badescu Sprint: ready for triage Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.137682.1632384120158%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper commented on FACT-2772 Re: Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) I missed that this is an issue in facter 3.x. It would be good to verify that facter 4.x also doesn't have this issue. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.108015.1609870320089%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Josh Cooper Labels: platform_7.2 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.108016.1609870320131%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Josh Cooper Priority: Normal Major Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.106587.1609784580051%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Josh Cooper updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Josh Cooper Labels: platform_7.2 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.106588.1609784580098%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Bogdan Irimie updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Bogdan Irimie Sprint: Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.72363.1604566262107%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Bogdan Irimie updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Bogdan Irimie Sprint: ready for triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.72391.1604566263275%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Mihai Buzgau updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Mihai Buzgau Sprint: PR - Triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.24161.1598428680040%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title Mihai Buzgau updated an issue Facter / FACT-2772 Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373) Change By: Mihai Buzgau Team: Night's Watch Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.24162.1598428680084%40Atlassian.JIRA.
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Boris updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Boris
After updating puppet to verision 6.18.0-1, the following script, located in `opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:java} #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = ""> packages: {}}def parse_redhat packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endendif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)] {quote} "@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?" {quote}
Add Comment
This message was sent by Atlassian Jira
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Boris updated an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Change By:
Boris
After updating puppet to verision 6.18.0-1, the following script, located in `opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:java} #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no- custom-fact --no- external-facts os.family).strip@data = ""> packages: {}}def parse_redhat packagelist = %x(rpm -qa --qf '% \ {NAME};% \ {VERSION}-% \ {RELEASE}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endenddef parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package|pname = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip endendif osfamily == 'RedHat' parse_redhatendif osfamily == 'Debian' parse_debianendputs @data.to_json {code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"
Add Comment
This message was sent by Atlassian Jira
Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Title: Message Title
Boris created an issue
Facter / FACT-2772
Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)
Issue Type:
Bug
Assignee:
Unassigned
Created:
2020/08/25 1:35 PM
Priority:
Normal
Reporter:
Boris
After updating puppet to verision 6.18.0-1, the following script, located in `opt/puppetlabs/facter/facts.d/` recurses into oblivion #!/usr/bin/env ruby require 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-external-facts os.family).strip @data = ""> packages: {} }def parse_redhat packagelist = %x(rpm qa --qf '%{NAME};%{VERSION}%{RELEASE}\n').split("\n") packagelist.each do |package| pname = package.split(';').first version = package.split(';').last @data[:packages][pname] = version.strip end end def parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package| pname = package.split(';').first version = package.split(';').last @data[:packages][pname] = version.strip end endif osfamily == 'RedHat' parse_redhat end if osfamily == 'Debian' parse_debian endputs @data.to_json I created this ticket after I talked to the slack community puppet guy Josh (https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500) "@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"
