Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title
Steve Traylen created an issue
Facter / FACT-3112
Stack trace on invalid facts.d entry
Issue Type:
Improvement
Affects Versions:
FACT 4.2.5
Assignee:
Unassigned
Components:
Facter 4
Created:
2022/03/31 12:50 AM
Environment:
CentOS 7 puppet-agent-7.12.0.7.g9fc268bde-4.config8s.x86_64
Priority:
Normal
Reporter:
Steve Traylen
We had a bad fact.s fact:
/etc/facter/facts.d/queue.py
{ "": }
That is invalid json:
# /etc/facter/facts.d
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Nirupama Mantha updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Nirupama Mantha Acceptance Criteria: The behavior should be the same as in Facter 3. We just want to surface a warning or error in line with how it's handles in Facter 3. Story Points: 3 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.7420.1649190600157%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Josh Cooper Sprint: Phoenix 2022-05-11 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.14953.1650467880277%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Josh Cooper Team: Phoenix Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.14952.1650467880231%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper commented on FACT-3112 Re: Stack trace on invalid facts.d entry Facter 3 detected if it failed to parse JSON and raised an exception with information about the parse error. Facter 4 should do the same. It seems it's swallowing the JSON parse error and then later tries to add a fact name, but the value is missing. Also check if Facter 4 has the same issue with YAML external facts Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.15964.1650564240102%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Josh Cooper Sprint: Phoenix 2022-05- 11 25 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.16075.1650570240169%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Tony Vu updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Tony Vu Sprint: Phoenix 2022- 05 06 - 25 08 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.27237.1652284560436%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Nirupama Mantha updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Nirupama Mantha Sprint: Phoenix 2022-06-08 , Phoenix 2022-06-22 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.45172.1654701180302%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Nirupama Mantha updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Nirupama Mantha Sprint: Phoenix 2022-06-08, Phoenix 2022- 06 07 - 22 06 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.45264.1654704480141%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Nirupama Mantha updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Nirupama Mantha Sprint: Phoenix 2022-06-08, Phoenix 2022-07- 06 20 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.51858.1655913000557%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Nirupama Mantha updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Nirupama Mantha Sprint: Phoenix 2022-06-08, Phoenix 2022- 07 08 - 20 03 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.58754.1657125240474%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Nirupama Mantha updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Nirupama Mantha Sprint: Phoenix 2022-06-08, Phoenix 2022-08- 03 17 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.1016.1658334240118%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Lisa Ross updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Lisa Ross Epic Link: FACT-3139 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.6750.1659530460030%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title
Josh Cooper commented on FACT-3112
Re: Stack trace on invalid facts.d entry
Steve Traylen Facter 4 behavior seems reasonable to me as it prints a warning with the path to the external fact:
$ cat ~/.facter/facts.d/queue.py
{ "": }
$ bundle exec puppet apply -e ''
Warning: Facter: Command /home/josh/.facter/facts.d/queue.py completed with the following stderr message: /home/josh/.facter/facts.d/queue.py: 2: Syntax error: end of file unexpected (expecting "}")
Notice: Compiled catalog for localhost in environment production in 0.01 seconds
Notice: Applied catalog in 0.01 seconds
Also puppet-agent-7.12.0.7.g9fc268bde-4.config8s.x86_64 is not a valid puppet-agent version (specifically 9fc268bde):
$ git show 9fc268bde
fatal: ambiguous argument '9fc268bde': unknown revision or path not in the working tree.
Perhaps you have a locally applied patch that's causing issues?
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Christopher Thorn updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Christopher Thorn Sprint: Phoenix 2022-06-08, Phoenix 2022-08-17 , Phoenix 2022-08-31 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.16934.1660752780357%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Morgan Rhodes updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Morgan Rhodes Sprint: Phoenix 2022-06-08, Phoenix 2022-08-17, Phoenix 2022- 08 09 - 31 14 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.17013.1660754760038%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Josh Cooper Epic Link: FACT-3139 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.21203.1661360520257%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper updated an issue Facter / FACT-3112 Stack trace on invalid facts.d entry Change By: Josh Cooper Sprint: Phoenix 2022-06-08, Phoenix 2022-08-17 , Phoenix 2022-09-14 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.21206.1661360580158%40Atlassian.JIRA.
Jira (FACT-3112) Stack trace on invalid facts.d entry
Title: Message Title Josh Cooper commented on FACT-3112 Re: Stack trace on invalid facts.d entry Since we haven't heard back, I'm going to close this. Feel free to reopen if you have steps to reproduce using a puppet-agent package built by Puppet. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.70910.1673294700040%40Atlassian.JIRA.
