Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-09-08 Thread Aria Li (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Aria Li commented on  FACT-3138  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
 Hello! Just an update on what Josh Cooper and I are planning on doing. We will be modifying the pre-existing fact blocking mechanism on Facter so users can block specific fact values from facts with structured data, like gce, which uses a hash for its values. Specifically, this will be done using the block list which will match a value in the fact's value hash and filter it out. For now, we will not be focusing on dynamic facts like network.interfaces.docker0 and instead we will focus on implementing this for static facts. If you're curious about the work we've done already, feel free to check out this link!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.29504.1662681720035%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-09-02 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3138  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
 Paired with Aria Li on this and the way facter works currently is the block list determines which facts should not be collected. But if a single fact like "gce" returns structured data, then the block list does not filter the data. The reason this works for other structured facts (for example, you can block "memory.swap" while allowing "memory.system") is because swap is an independent fact, which just happens to be "mounted" at that point in the fact tree.  That said, I think it would be possible to apply the block list to whatever structured data we collect. We probably want to filter that data before it is cached as well. Note there are some existing bugs around facter block lists being slow (FACT-2916, FACT-2954, FACT-3080) so we'll need to be mindful of that.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.27216.1662133200044%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-08-30 Thread Aria Li (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Aria Li assigned an issue to Aria Li  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Aria Li  
 
 
Assignee: 
 Aria Li  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.25009.1661885580050%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-08-17 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Sprint: 
 Phoenix 2022- 08 09 - 31 14  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.17012.1660754700606%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-08-03 Thread Nirupama Mantha (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nirupama Mantha updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Nirupama Mantha  
 
 
Sprint: 
 Phoenix 2022-08- 17 31  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.6941.1659545460185%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Nirupama Mantha (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nirupama Mantha updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Nirupama Mantha  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.4576.1659022500046%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Lisa Ross updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Lisa Ross  
 
 
Sprint: 
 Phoenix 2022-08-17  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.4535.1659018000212%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Lisa Ross updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Lisa Ross  
 

  
 
 
 
 

 
 SPIKE to capture investigation on: * Does Facter already support this? * Is it possible to create a new block list of GCE?   +Description of  bug  original ticket FACT-3126 +Currently, GCE facts in Facter are all lumped into one big fact group from a blocklist standpoint. From facter --list-block-groups{{GCE}}{{- gce}}This is problematic, as the data it pulls in is pretty wide ranging. Specifically, I'm experiencing an issue at work where one GCE project has a large number of SSH keys. These keys all get pulled into the GCE fact (gce.instance.project.attributes.ssh-keys) resulting in puppet complaining about a fact being larger than the maximum size (fortunately, this is a soft error at the moment). Since we don't actually use that fact, we would like to be able to disable it, as it just wastes resources (it is also not really a fact about the machine really, but I digress). Sadly, since GCE facts are currently all-or-nothing, we cannot blocklist it because we do use other GCE facts pretty widely.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Lisa Ross updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Lisa Ross  
 
 
Team: 
 Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.4536.1659018000260%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Lisa Ross updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Lisa Ross  
 

  
 
 
 
 

 
 SPIKE to capture investigation on: * Does Facter already support this? * Is it possible to create a new block list of GCE?   +Description of bug+ Currently, GCE facts in Facter are all lumped into one big fact group from a blocklist standpoint. From facter --list-block-groups{{GCE}}{{- gce}}This is problematic, as the data it pulls in is pretty wide ranging. Specifically, I'm experiencing an issue at work where one GCE project has a large number of SSH keys. These keys all get pulled into the GCE fact (gce.instance.project.attributes.ssh-keys) resulting in puppet complaining about a fact being larger than the maximum size (fortunately, this is a soft error at the moment). Since we don't actually use that fact, we would like to be able to disable it, as it just wastes resources (it is also not really a fact about the machine really, but I digress). Sadly, since GCE facts are currently all-or-nothing, we cannot blocklist it because we do use other GCE facts pretty widely.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

   

Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Lisa Ross updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Lisa Ross  
 
 
Reporter: 
 Ryan DeShone Lisa Ross  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.4529.1659017880101%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Lisa Ross updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Change By: 
 Lisa Ross  
 
 
Issue Type: 
 Improvement Task  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.456986.1659017708000.4526.1659017760277%40Atlassian.JIRA.


Jira (FACT-3138) SPIKE - Add Block Groups to GCE Facts

2022-07-28 Thread Lisa Ross (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ryan DeShone created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3138  
 
 
  SPIKE - Add Block Groups to GCE Facts   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Affects Versions: 
 FACT 4.2.10  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Facter 4  
 
 
Created: 
 2022/07/28 7:15 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Ryan DeShone  
 

  
 
 
 
 

 
 Currently, GCE facts in Facter are all lumped into one big fact group from a blocklist standpoint. From facter --list-block-groups GCE - gce This is problematic, as the data it pulls in is pretty wide ranging. Specifically, I'm experiencing an issue at work where one GCE project has a large number of SSH keys. These keys all get pulled into the GCE fact (gce.instance.project.attributes.ssh-keys) resulting in puppet complaining about a fact being larger than the maximum size (fortunately, this is a soft error at the moment). Since we don't actually use that fact, we would like to be able to disable it, as it just wastes resources (it is also not really a fact about the machine really, but I digress). Sadly, since GCE facts are currently all-or-nothing, we cannot blocklist it because we do use other GCE facts pretty widely.