Jira (FACT-3150) Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Title: Message Title Claudia Petty updated an issue Facter / FACT-3150 Facter doesn't support comments in /etc/os-release - one vendor embeds them. Change By: Claudia Petty Labels: new-feature Add Comment This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468332.1663490077000.1915.1687351381389%40Atlassian.JIRA.
Jira (FACT-3150) Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Title: Message Title Morgan Rhodes commented on FACT-3150 Re: Facter doesn't support comments in /etc/os-release - one vendor embeds them. Greg a PR against facter would be great, thanks. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468332.1663490077000.34496.1663771860109%40Atlassian.JIRA.
Jira (FACT-3150) Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Title: Message Title Greg commented on FACT-3150 Re: Facter doesn't support comments in /etc/os-release - one vendor embeds them. Submit a PR against https://github.com/puppetlabs/facter ? Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468332.1663490077000.34234.1663730280025%40Atlassian.JIRA.
Jira (FACT-3150) Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Title: Message Title Greg commented on FACT-3150 Re: Facter doesn't support comments in /etc/os-release - one vendor embeds them. Hi Morgan. . How would you like a fix submitted? (An updated ruby code that would resolve the issue was included when this ticket was opened). Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468332.1663490077000.34233.1663730220045%40Atlassian.JIRA.
Jira (FACT-3150) Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Title: Message Title Morgan Rhodes commented on FACT-3150 Re: Facter doesn't support comments in /etc/os-release - one vendor embeds them. Hi Greg ! Arista isn't one of our supported operating systems. At this time we don't likely have the bandwidth to do this work but would be happy to review a PR if you get one up. Thanks! Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468332.1663490077000.34040.1663704660167%40Atlassian.JIRA.
Jira (FACT-3150) Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Title: Message Title
Greg created an issue
Facter / FACT-3150
Facter doesn't support comments in /etc/os-release - one vendor embeds them.
Issue Type:
New Feature
Affects Versions:
FACT 4.2.12
Assignee:
Unassigned
Components:
Facter 4
Created:
2022/09/18 1:34 AM
Priority:
Normal
Reporter:
Greg
In the file " /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/resolvers/os_release.rb" in the function " read_and_parse_os_release_file" the "pairs" variable is constructed with a very simple parse of the file. Suggested fix is to strip white space from either side of each line string, and discard lines that are either empty or start with a '#': content.map { | line | line.strip }.select { | line | ! line.start_with?('#') and line.size > 0 }.each do |line| pairs << line.strip.delete('"').split('=', 2) end (The vendor is Arista, and the issue happens trying to get puppet7 running on their devices).
Add Comment
