Jira (HI-597) Hiera lookup must hard fail on invalid YAML

2018-03-12 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Thomas Hallgren  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Hiera /  HI-597  
 
 
  Hiera lookup must hard fail on invalid YAML   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Henrik Lindberg Thomas Hallgren  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-597) Hiera lookup must hard fail on invalid YAML

2018-03-12 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  HI-597  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Hiera lookup must hard fail on invalid YAML   
 

  
 
 
 
 

 
 It is an option to place it under the control of the --strict flag.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-597) Hiera lookup must hard fail on invalid YAML

2018-03-12 Thread Andrey Galkin (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrey Galkin commented on  HI-597  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Hiera lookup must hard fail on invalid YAML   
 

  
 
 
 
 

 
 I would say the behavior should be controlled by configuration option: ignore, warn and enforce. Puppet 5 may just warn about the problem, but Puppet 6 must hard fail by default.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-597) Hiera lookup must hard fail on invalid YAML

2018-03-11 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  HI-597  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Hiera lookup must hard fail on invalid YAML   
 

  
 
 
 
 

 
 The only reason it does not do that is because it has not done so in the past and fixing it introduces a breaking change. There are cases when work is required to determine why a parse fails - a common mistake is to have an empty file (which is actually illegal) and I believe that is a reason files that do not parse are simply skipped. Eric Sorenson Do you like this to be fixed in 5x or wait until Puppet 6? (I think skipping files that does not parse is quite bad, but it can also cause irritation in an upgrade if it starts to error out). (Not sure if we log warnings - need to check).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-597) Hiera lookup must hard fail on invalid YAML

2018-03-11 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Henrik Lindberg  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Hiera /  HI-597  
 
 
  Hiera lookup must hard fail on invalid YAML   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-597) Hiera lookup must hard fail on invalid YAML

2018-03-11 Thread Andrey Galkin (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrey Galkin created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Hiera /  HI-597  
 
 
  Hiera lookup must hard fail on invalid YAML   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 HI 3.4.2  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Community, PE  
 
 
Created: 
 2018/03/11 11:13 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Andrey Galkin  
 

  
 
 
 
 

 
 PuppetServer/Hiera just ignores broken YAML files instead of hard failing on them. The consequences can be as serious as compromised system and/or lost network access to host. I would consider that critical based on experience with the problem. Below is broken sample from hierarchy for tests:  
 
 
 
 
 ---  
 
 
 #classes:  
 
 
  - cls1  
 
 
  - cls2