Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title Steve Barlow updated an issue PuppetDB / PDB-1029 PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Change By: Steve Barlow Sprint: PuppetDB 2014-11-19 , PuppetDB 2014-12-03 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen pljenkinsro commented: Test PASSed. Refer to this link for build results (access rights to CI server needed): https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/200/ Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Pull request (PUP-3512) Use new Profiler API has been closed. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen fpringvaldsen commented: I'm closing this in favor of https://github.com/puppetlabs/puppetdb/pull/1157, which is rebased on top of and targeted at stable. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen cprice404 commented: @kbarber this doesn't change the logging behavior you're used to seeing in the Puppet ruby profiler code. The logging profiler in Puppet Server probably needs to be updated a bit to follow that same pattern; have been planning to do that but haven't gotten to it yet. Where this stuff really adds value is in PE when you are exporting the metrics to graphite; the new API allows us to provide hierarchy info to graphite and track counts/timing information at each level of the hierarchy. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen fpringvaldsen commented: @cprice404 I've addressed your comments. @kbarber I'll go ahead and rebase this onto stable now that I've addressed @cprice404's feedback. In terms of the metric ID, from what I understand it's used for grouping metrics together, and is sort of like a namespace. I'm not sure if we're still showing the stack level in the profile, but I think @cprice404 would be able to answer that. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1029 PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Change By: Kenneth Barber Affects Version/s: 2.2.2 Story Points: 0 Fix Version/s: 2.2.x Issue Type: Task Bug Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1029 PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Change By: Kenneth Barber Sprint: PuppetDB 2014-11-19 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title Kenneth Barber assigned an issue to Preben Ingvaldsen PuppetDB / PDB-1029 PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Change By: Kenneth Barber Assignee: Preben Ingvaldsen Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: @fpringvaldsen this will need a stable branch target. Feel free to fix these comments from @cprice404 first before rebasing. Can I ask you both a question, what does this hierarchy that is a metric_id mean? And what is its goal? In the Ruby puppet profiler, it has this capability to enumerate where in the stack tree the profile is being called from, looking at this new one: https://github.com/puppetlabs/puppet-server/blob/f833bf81498400517c7e1fa1eea1d7161b6c03cb/src/java/com/puppetlabs/puppetserver/LoggingPuppetProfiler.java, I can't see how it does it here. I guess what I'm trying to say is, are we still showing the stack level in the profile? Your request.key thing made me think about hierarchy thats all, but the previous system kind of did that automatically. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1029 Re: PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen pljenkinsro commented: Test PASSed. Refer to this link for build results (access rights to CI server needed): https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/189/ Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1029) PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot created an issue PuppetDB / PDB-1029 PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Issue Type: Task Assignee: Unassigned Created: 2014/11/13 4:18 PM Labels: github Priority: Normal Reporter: gepetto-bot (PUP-3512) Use new Profiler API Author: Preben Ingvaldsen Company: Puppet Labs Github ID: fpringvaldsen Pull Request 1156 Discussion Pull Request 1156 File Diff Pull Request Description This PR modifies PuppetDB to use the new Puppet Profiler API instead of the old one, in preparation for the removal of the old API. (webhooks-id: 38ed476c297298540179af957d539e14)
