Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1030 PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen Change By: Kenneth Barber Affects Version/s: 2.2.2 Story Points: 0 Fix Version/s: 2.2.x Issue Type: Task Bug Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1030 PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen Change By: Kenneth Barber Sprint: PuppetDB 2014-12-03 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: @fpringvaldsen #1160 might do it I think? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen fpringvaldsen commented: @kbarber Alright, I can implement an if-check that calls the old version of the profiler based on the arity in a new PR. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: @fpringvaldsen actually, we missed out adding our compatibility layer: https://jenkins.puppetlabs.com/job/PuppetDB-Specs/259/ ... so its failing now on 3.5.1. I'd suggest this as a fix way to look up the method arity before falling back to the single argument behaviour: http://ruby-doc.org/core-1.8.7/Method.html#method-i-arity Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen Pull request ( PUP-3512 ) Use new Profiler API has been closed. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen pljenkinsro commented: Test PASSed. Refer to this link for build results (access rights to CI server needed): https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/214/ Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen fpringvaldsen commented: @cprice404 @kbarber I've updated the PR based on @cprice404's feedback. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: > request.key refers to a property from the indirector request. In your case it should generally just be the node certname as a string. My mistake here was thinking this meant a per request key, now it makes more sense. @cprice404 @fpringvaldsen I say for now we update the PR based on the current comments and we should review this taxonomy properly later. Its going to take time to get a dev environment up, and we should get the tests passing again. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen cprice404 commented: `request.key` refers to a property from the indirector request. In your case it should generally just be the node certname as a string. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: One question, what does 'request.key' equate to? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: @cprice404 so I think we should leave this open, at least. We want this fixed, my gut says though we should check out how it visualizes in graphite. What's more, this would be a learning exercise for us. But I'm not in the position to work on this now anyway . Plan B might be merge it in as is, and raise a ticket to investigate later, true. Leave it open for now, I'll talk with the team. And we totally appreciate the work you guys have done here, goes without saying I hope. Its an awesome feature, one of my favourites, since I've wanted an alternate to just probing HTTP /metrics/mbean/bleah or directly via JMX for a long time. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen cprice404 commented: @kbarber I agree; I think the metric IDs warrant some thought and that you guys are much more qualified to decide what they should be than we are. The goal of this PR was just to get the ball rolling and get your terminus code into a state where it won't be broken against Puppet 4 (because the old profiler API has already been removed from Puppet 4: https://github.com/puppetlabs/puppet/commit/357cd6b4951dcda902d81ccd31d727b6641e19dc ). If you would prefer for us to close this out until such time as you guys have bandwidth to come up with metric ids that you are comfortable with, we can do so. Alternately, we could just tweak this a bit more to get it into the right ballpark, and you could go ahead and merge it so that your CI tests won't fail against the puppet master branch, and then you guys can polish them up before you do your next release? Happy to handle it however you like. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen kbarber commented: My concern is that this is a contract to our users, and a decision on the topology should be thought through. A breaking change later might upset people. I'd like to see this actually working somehow, before we make a decision on the topology to be honest. Has someone ran this through Graphite, and has some results for us to see? I see a bit of request.key being thrown around, but this isn't threaded throughout the entire request, (like munge_catalog doesn't have it) some parts are cumulative, other parts seem to be more like they are per request. We need to make sure our direction is clear and its consistent throughout. I'm almost tempted to make sure we understand the impact of per request metric storage, in a way we get per request in the log itself, does this also need to be expressed in graphite? Point being, do we need per request, can we make sure our topology design allows for per request when we go to add it later? Otherwise, can we get the best of both worlds, or at least have a clear way to get per request and cumulative stats. @cprice404's comments are alluding to this concern. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen senior commented: Looks good to me, @cprice404 are you ok with it? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot commented on PDB-1030 Re: PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen pljenkinsro commented: Test PASSed. Refer to this link for build results (access rights to CI server needed): https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/202/ Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1030) PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen
Title: Message Title gepetto-bot created an issue PuppetDB / PDB-1030 PR (1157): (PUP-3512) Use new Profiler API - fpringvaldsen Issue Type: Task Assignee: Unassigned Created: 2014/11/14 11:42 AM Labels: github Priority: Normal Reporter: gepetto-bot (PUP-3512) Use new Profiler API Author: Preben Ingvaldsen Company: Puppet Labs Github ID: fpringvaldsen Pull Request 1157 Discussion Pull Request 1157 File Diff Pull Request Description Change the `profile` function in PuppetDB to use the new Puppet Profiler API in preparation for removing the old API from Puppet. Modify all calls to the `profile` function in PuppetDB to pass in a metric ID.
