Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title Rob Browning updated an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: Rob Browning Fix Version/s: PDB2.3.0 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title John Duarte updated an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: John Duarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title Kenneth Barber assigned an issue to AJ Roetker PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: Kenneth Barber Assignee: KennethBarber AJRoetker Fix Version/s: PDB2.2.x Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: Kenneth Barber Fix Version/s: PDB3.0.0 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn Pull request NEEDS INFO: Allow tilde in resource name, like in puppet has been closed. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn kbarber commented: Since I haven't had a response on this for a while, I'm closing it out. @saimonn if you manage to reproduce it for us again, just open up a Jira ticket perhaps and we'll take a look. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn puppetcla commented: CLA signed by all contributors. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn kbarber commented: @saimonn any luck on reproducing this again? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title Ryan Senior updated an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: Ryan Senior Sprint: PuppetDB2014-12-17 ,PuppetDB2014-12-31 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn kbarber commented: @hlindberg thanks mate, I think its probably just a bug. I'll do more analysis. @saimonn I can't reproduce this: https://gist.github.com/kbarber/a1f47ce914b83c7cfd7e Can you look at how I did it, and provide a better transcript for me to reproduce this problem? As far as I can tell the tag isn't included as one would expect. This was using Puppet 3.7.2 Puppetdb 2.2.2. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn saimonn commented: The bug is corrected in our production environment, and the data used in the original exec resource can't be made public. I'll try to reproduce the bug with data that I can share here. By the way, we are using puppetserver 0.4.0, puppet 3.7.3 and puppetdb 2.2.2 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn hlindberg commented: @kbarber sorry no clue what is going on without setting this up and debugging. If the tilde is in a tag, and it is specified that tags cannot contain one then clearly it is a bug in Puppet. There has been recent changes on master in how tags are computed and set that the problem should be tested against. I suggest logging a jira ticket for puppet. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot created an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Issue Type: Task Assignee: Unassigned Created: 2014/12/10 3:54 AM Labels: github Priority: Normal Reporter: gepetto-bot Allow tilde in resource name, like in puppet Author: Simon Shier Company: camptocamp Github ID: saimonn Pull Request 1175 Discussion Pull Request 1175 File Diff Pull Request Description tilde character is allowed in the resource and tag names in puppet, but not in puppetdb. This PR fixes this. (webhooks-id: 01e064cb2330ad7c60930f3596853080)
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn pljenkinsro commented: Can one of the admins verify this patch? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title
gepetto-bot commented on PDB-1061
Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn
kbarber commented:
@saimonn you're assertion about tags supporting tilde does not seem to be true for Puppet 3.7.3. What version of Puppet are you running? Please note we only support 3.7.x for the master branch, and 3.5.x or the stable branch today, so anything older is outside our radar.
You also mention 'resource names' you mean types? Or the titles? Can you show me a breaking example?
``` [ken@kb puppetdb]# cat /tmp/foo.pp notify { foobar: tag = asdfasdf, }
[ken@kb puppetdb]# puppet apply /tmp/foo.pp Notice: Compiled catalog for kb.local in environment baza in 0.01 seconds Notice: foobar Notice: /Stage[main]/Main/Notify[foobar]/message: defined 'message' as 'foobar' Notice: Finished catalog run in 0.08 seconds [ken@kb puppetdb]# vi /tmp/foo.pp [ken@kb puppetdb]# puppet apply /tmp/foo.pp WARNING: Nokogiri was built against LibXML version 2.9.1, but has dynamically loaded 2.9.2 Error: Invalid tag 'asdf~asdf' at /tmp/foo.pp:3 on node kb.local Error: Invalid tag 'asdf~asdf' at /tmp/foo.pp:3 on node kb.local [ken@kb puppetdb]# puppet --version 3.7.2 ```
Add Comment
This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: Kenneth Barber Story Points: 0 Affects Version/s: PDB2.2.2 Fix Version/s: PDB3.0.0 Assignee: KennethBarber Issue Type: Task Bug Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-1061 PR (1175): Allow tilde in resource name, like in puppet - saimonn Change By: Kenneth Barber Sprint: PuppetDB2014-12-17 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title
gepetto-bot commented on PDB-1061
Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn
saimonn commented:
We use puppet version 3.7.2 and pupetdb version 2.2.2.
@kbarber the tag that cause problem comes from the title of an exec resource. In our case `exec { /bin/echo 'FOOBARBAZ' ~user/path/to/file: }
`
Here is the puppetdb error we get: precode ERROR [c.p.p.command] [deadbeef-uuid] [replace catalog] Fatal error on attempt 0 java.lang.IllegalArgumentException: Resource '{:type Exec, :title /bin/echo 'FOOBARBAZ\n' ~user/path/to/file}' has an invalid tag '/bin/echo 'foobarbaz\n' ~user/path/to/file'. Tags must match the pattern /\A[a-z0-9_][a-z0-9_:\-.]*\Z/. at com.puppetlabs.puppetdb.catalogs$validate_resources.invoke(catalogs.clj:331) ~[na:na] at clojure.core$comp$fn__4194.invoke(core.clj:2410) ~[puppetdb.jar:na] snip /code/pre
After deeper reading of the error, the tilde may not be the (only) source of the problem.
But still, my guess is we should not have this tag sent from puppet to PDB.
Add Comment
This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title
gepetto-bot commented on PDB-1061
Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn
kbarber commented:
@saimonn aah, I get it. Its not 'tags' its resource titles becoming tags ... well at least the workaround for you is easy:
``` exec { run_my_stuff: command = /bin/echo 'FOOBARBAZ' ~user/path/to/file, }
```
But it would seem to me this is a consistency problem with Puppet and our over-arching model here. I understand Puppet uses the title as a tag in some cases, but to then validate the tags with a higher order of validation at manifest time just seems wrong to me. They obviously should follow the same rules if we are going to continue to do this. I presume this is because tags are meant to be used on the command line that we validate more strictly for tags ... but if titles become tags ... well, we need to treat them the same.
I've tried looking through the specifications to find the place where this is declared: https://github.com/puppetlabs/puppet-specifications. Perhaps @hlindberg might have some thoughts on this problem. It would definitely seem true that we need to have the same validation for tags as we do for namevars today ... if thats what is supported in Puppet.
Add Comment
This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn saimonn commented: the Puppet::Util::Tagging module is supposed to silently ignore names not matching ValidTagRegex (= /^[0-9A-Za-z_][0-9A-Za-z_:.-]*$/ ), hence I still wonder why PDB receives this invalid tag. The proposed workaround is already deployed on our servers, but I thought you'd still be happy to know the problem we had. Anyway, this PR won't solve the consistency problem between puppet and PBD. Feel free to close it if it is appropriate. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-1061) PR (1175): Allow tilde in resource name, like in puppet - saimonn
Title: Message Title gepetto-bot commented on PDB-1061 Re: PR (1175): Allow tilde in resource name, like in puppet - saimonn kbarber commented: @saimonn lets keep it open until we decide where this goes, and I'll get @hlindberg's thoughts on it. Feels like a greater problem like you say. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
