Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title Elof Ofel created an issue PuppetDB / PDB-3063 latest_report_noop_pending=null, should be =true Issue Type: Bug Affects Versions: PDB 4.2.2 Assignee: Unassigned Components: PuppetDB Created: 2016/09/21 3:27 AM Priority: Normal Reporter: Elof Ofel Hmm, I think the changes with "noop_pending", intoduced in v4.2 ( PDB-2753 ) is buggy. latest_report_noop_pending is set to null even though the last noop run showed changes. Example: On node foo.bar.com I run 'puppet agent -t --noop'. It shows me there are changes to be made. In puppetdb however, it looks like this: curl -X GET http://127.0.0.1:8080/pdb/query/v4/nodes/foo.bar.com
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title
Elof Ofel updated an issue
PuppetDB / PDB-3063
latest_report_noop_pending=null, should be =true
Change By:
Elof Ofel
Hmm, I think the changes with "noop_pending", intoduced in v4.2 (PDB-2753) is buggy.latest_report_noop_pending is set to null even though the last noop run showed changes.Example:On node foo.bar.com I run 'puppet agent -t --noop'.It shows me there are changes to be made.In puppetdb however, it looks like this:{noformat}curl -X GET http://127.0.0.1:8080/pdb/query/v4/nodes/foo.bar.com{ "deactivated" : null, "latest_report_hash" : "114082ba90a7a0fc94580ffa520315d8d1f2723a", "facts_environment" : "production", "cached_catalog_status" : "not_used", "report_environment" : "production", "latest_report_corrective_change" : null, "catalog_environment" : "production", "facts_timestamp" : "2016-09-21T08:33:28.459Z", "latest_report_noop" : true, "expired" : null, "latest_report_noop_pending" : null, "report_timestamp" : "2016-09-21T08:33:31.811Z", "certname" : "foo.bar.com", "catalog_timestamp" : "2016-09-21T08:33:32.601Z", "latest_report_status" : "unchanged"}{noformat}{noformat}So... "report_timestamp" : "2016-09-21T08:33:31.811Z" Correct. That's the time I ran the noop. "latest_report_noop" : true Correct, I've run nothing else after the noop. "latest_report_status" : "unchanged" Correct, nothing was changed. "latest_report_noop_pending" : {color:red} null {color} Wrong!{noformat}I have a cron job that periodically do a noop-run on all my nodes.For nodes that are not "up to date", I get an email report.Also, in PuppetExplorer I list these "nodes with pending jobs" using a query like this:{noformat}#report { latest_report?=true and noop=true and status="unchanged" }{noformat}Since PuppetDB 4.2, this query doesn't work any more.The problem is that neither of these querys now show me the list of nodes with pending jobs:{noformat}#node { latest_report_noop_pending=true }#report { latest_report?=true and noop_pending=true }{noformat}Is my query wrong, or is there a bug in puppetdb?(Running the latest puppet on Debian 8.6: puppet-agent 1.6.2-1jessiepuppetdb 4.2.2-1puppetlabs1puppetdb-termini 4.2.2-1puppetlabs1puppetexplorer 2.0.0-62puppetlabs-release-pc1 1.1.0-2jessiepuppetserver 2.6.0-1puppetlabs1)
Add Comment
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title
Elof Ofel updated an issue
PuppetDB / PDB-3063
latest_report_noop_pending=null, should be =true
Change By:
Elof Ofel
Hmm, I think the changes with "noop_pending", intoduced in v4.2 (PDB-2753) is buggy.latest_report_noop_pending is set to null even though the last noop run showed changes.Example:On node foo.bar.com I run 'puppet agent -t --noop'.It shows me there are changes to be made.In puppetdb however, it looks like this:{noformat}curl -X GET http://127.0.0.1:8080/pdb/query/v4/nodes/foo.bar.com{ "deactivated" : null, "latest_report_hash" : "114082ba90a7a0fc94580ffa520315d8d1f2723a", "facts_environment" : "production", "cached_catalog_status" : "not_used", "report_environment" : "production", "latest_report_corrective_change" : null, "catalog_environment" : "production", "facts_timestamp" : "2016-09-21T08:33:28.459Z", "latest_report_noop" : true, "expired" : null, "latest_report_noop_pending" : null, "report_timestamp" : "2016-09-21T08:33:31.811Z", "certname" : "foo.bar.com", "catalog_timestamp" : "2016-09-21T08:33:32.601Z", "latest_report_status" : "unchanged"}{noformat}{noformat}So... "report_timestamp" : "2016-09-21T08:33:31.811Z" Correct. That's the time I ran the noop. "latest_report_noop" : true Correct, I've run nothing else after the noop. "latest_report_status" : "unchanged" Correct, nothing was changed. "latest_report_noop_pending" : null Wrong!{noformat} I have a cron job that periodically do a noop-run on all my nodes.For nodes that are not "up to date", I get an email report.Also, in PuppetExplorer I list these "nodes with pending jobs" using a query like this:{noformat}#report { latest_report?=true and noop=true and status="unchanged" }{noformat}Since PuppetDB 4.2, this query doesn't work any more.The problem is that neither of these querys now show me the list of nodes with pending jobs:{noformat}#node { latest_report_noop_pending=true }#report { latest_report?=true and noop_pending=true }{noformat}Is my query wrong, or is there a bug in puppetdb?(Running the latest puppet on Debian 8.6: puppet-agent 1.6.2-1jessiepuppetdb 4.2.2-1puppetlabs1puppetdb-termini 4.2.2-1puppetlabs1puppetexplorer 2.0.0-62puppetlabs-release-pc1 1.1.0-2jessiepuppetserver 2.6.0-1puppetlabs1)
Add Comment
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title
Elof Ofel updated an issue
PuppetDB / PDB-3063
latest_report_noop_pending=null, should be =true
Change By:
Elof Ofel
Hmm, I think the changes with "noop_pending", intoduced in v4.2 (PDB-2753) is buggy.latest_report_noop_pending is set to null even though the last noop run showed changes.Example:On node foo.bar.com I run 'puppet agent -t --noop'.It shows me there are changes to be made.In puppetdb however, it looks like this:{noformat}curl -X GET http://127.0.0.1:8080/pdb/query/v4/nodes/foo.bar.com{ "deactivated" : null, "latest_report_hash" : "114082ba90a7a0fc94580ffa520315d8d1f2723a", "facts_environment" : "production", "cached_catalog_status" : "not_used", "report_environment" : "production", "latest_report_corrective_change" : null, "catalog_environment" : "production", "facts_timestamp" : "2016-09-21T08:33:28.459Z", "latest_report_noop" : true, "expired" : null, "latest_report_noop_pending" : null, "report_timestamp" : "2016-09-21T08:33:31.811Z", "certname" : "foo.bar.com", "catalog_timestamp" : "2016-09-21T08:33:32.601Z", "latest_report_status" : "unchanged"}{noformat}{noformat}So... "report_timestamp" : "2016-09-21T08:33:31.811Z" Correct. That's the time I ran the noop. "latest_report_noop" : true Correct, I've run nothing else after the noop. "latest_report_status" : "unchanged" Correct, nothing was changed. "latest_report_noop_pending" : null Wrong!{noformat} \\ \\ \\ I have a cron job that periodically do a noop-run on all my nodes.For nodes that are not "up to date", I get an email report.Also, in PuppetExplorer I list these "nodes with pending jobs" using a query like this:{noformat}#report { latest_report?=true and noop=true and status="unchanged" }{noformat}Since PuppetDB 4.2, this query doesn't work any more.The problem is that neither of these querys now show me the list of nodes with pending jobs:{noformat}#node { latest_report_noop_pending=true }#report { latest_report?=true and noop_pending=true }{noformat} \\ \\ Is my query wrong, or is there a bug in puppetdb?(Running the latest puppet on Debian 8.6: puppet-agent 1.6.2-1jessiepuppetdb 4.2.2-1puppetlabs1puppetdb-termini 4.2.2-1puppetlabs1puppetexplorer 2.0.0-62puppetlabs-release-pc1 1.1.0-2jessiepuppetserver 2.6.0-1puppetlabs1)
Add Comment
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title
Elof Ofel updated an issue
PuppetDB / PDB-3063
latest_report_noop_pending=null, should be =true
Change By:
Elof Ofel
Hmm, I think the changes with "noop_pending", intoduced in v4.2 (PDB-2753) is buggy.latest_report_noop_pending is set to null even though the last noop run showed changes.Example:On node foo.bar.com I run 'puppet agent -t --noop'.It shows me there are changes to be made.In puppetdb however, it looks like this:{noformat}curl -X GET http://127.0.0.1:8080/pdb/query/v4/nodes/foo.bar.com{ "deactivated" : null, "latest_report_hash" : "114082ba90a7a0fc94580ffa520315d8d1f2723a", "facts_environment" : "production", "cached_catalog_status" : "not_used", "report_environment" : "production", "latest_report_corrective_change" : null, "catalog_environment" : "production", "facts_timestamp" : "2016-09-21T08:33:28.459Z", "latest_report_noop" : true, "expired" : null, "latest_report_noop_pending" : null, "report_timestamp" : "2016-09-21T08:33:31.811Z", "certname" : "foo.bar.com", "catalog_timestamp" : "2016-09-21T08:33:32.601Z", "latest_report_status" : "unchanged"}{noformat}{noformat}So... "report_timestamp" : "2016-09-21T08:33:31.811Z" Correct. That's the time I ran the noop. "latest_report_noop" : true Correct, I've run nothing else after the noop. "latest_report_status" : "unchanged" Correct, nothing was changed. "latest_report_noop_pending" : null Wrong!{noformat}\\I have a cron job that periodically do a noop-run on all my nodes.For nodes that are not "up to date", I get an email report.Also, in PuppetExplorer I list these "nodes with pending jobs" using a query like this:{noformat}#report { latest_report?=true and noop=true and status="unchanged" }{noformat}Since PuppetDB 4.2, this query doesn't work any more.The problem is that neither of these querys now show me the list of nodes with pending jobs:{noformat}#node { latest_report_noop_pending=true }#report { latest_report?=true and noop_pending=true } #report { latest_report?=true and noop=true and status="unchanged" }{ noformat}Is my query wrong, or is there a bug in puppetdb?(Running the latest puppet on Debian 8.6: puppet-agent 1.6.2-1jessiepuppetdb 4.2.2-1puppetlabs1puppetdb-termini 4.2.2-1puppetlabs1puppetexplorer 2.0.0-62puppetlabs-release-pc1 1.1.0-2jessiepuppetserver 2.6.0-1puppetlabs1)
Add Comment
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title Wyatt Alt commented on PDB-3063 Re: latest_report_noop_pending=null, should be =true Elof Ofel The new feature here is actually in the puppet agent – PuppetDB is simply passing it through. Can you confirm your agent version and that you're on the latest? PuppetDB will behave the way you're describing on versions prior to the introduction of the feature. I'm not sure I completely follow you on the second question. The behavior of the first query shouldn't have changed in 4.2, and the two involving noop_pending may be broken due to the agent version. Are you saying the first now returns incorrect data? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title
Elof Ofel commented on PDB-3063
Re: latest_report_noop_pending=null, should be =true
Wyatt Alt, Ah. Testing. Yes, from an updated Debian client (puppet agent --version: 4.6.2), I get "latest_report_noop" : true, "latest_report_noop_pending" : true, "latest_report_status" : "unchanged"
The 'null' values in my original post came from a FreeBSD client with v4.5.1. So, once all my clients are updated I can start using latest_report_noop_pending. Great.
—
Regarding section #2:
Prior to PuppetDB v4.2:
The query #report { latest_report?=true and noop=true and status="unchanged" }
matches clients with pending jobs. (the last performed puppet run is a noop run, and it reported changes)
Now after PuppetDB v4.2:
The query #report { latest_report?=true and noop=true and status="unchanged" }
matches *any and all nodes* that use the new version of the puppet client, wether they have pending jobs or not.
This is possibly bad, if there are applications out there who rely on the old logic. They must update their syntax.
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title Elof Ofel commented on PDB-3063 Re: latest_report_noop_pending=null, should be =true This ticket can be closed if you choose to ignore the changed logic, and instead urge users to upgrade and then use the new syntax in their queries. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title Wyatt Alt commented on PDB-3063 Re: latest_report_noop_pending=null, should be =true Elof Ofel Thanks – I'd like to verify the change first, just haven't had the time yet. It seems like something that might be worth documenting. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-3063) latest_report_noop_pending=null, should be =true
Title: Message Title Wyatt Alt commented on PDB-3063 Re: latest_report_noop_pending=null, should be =true I've updated the docs to provide a bit more info. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
