Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title Sean Millichamp commented on PDOC-266 Re: Getting "unexpected construct regexp_literal" when using resource API title_patterns No reason I have. Here is a PR: https://github.com/puppetlabs/puppet-strings/pull/189 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title David Schmitt commented on PDOC-266 Re: Getting "unexpected construct regexp_literal" when using resource API title_patterns That looks like a sensible approach to solve this. Anything speaking against getting that merged right now? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title Sean Millichamp commented on PDOC-266 Re: Getting "unexpected construct regexp_literal" when using resource API title_patterns Sure, here it is: https://github.com/seanmil/puppet-strings/commit/c0165422d677d0f861d6e889e3cc27f8cb109978 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title David Schmitt commented on PDOC-266 Re: Getting "unexpected construct regexp_literal" when using resource API title_patterns I'm glad it's not a "everything on fire" situation. That said, it should definitely not swallow the docs for types using title_patterns. Can you post the patch somewhere, even if we don't think it'll be the right solution. It's at least a pointer to the offending code Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title Sean Millichamp commented on PDOC-266 Re: Getting "unexpected construct regexp_literal" when using resource API title_patterns It breaks doc generation for the type containing title_patterns - nothing is generated. The other types generate okay. In order to try to ensure comprehensive documentation on everything that we release we do default our pipeline to prohibiting anything though where Strings reports any warnings or any missing coverage (classes, parameters, etc.), but we also have a toggle to enable docs with failures to continue though so I can work around that. I did fiddle around with Strings enough to get a patch that has it continue without any warning, but I wasn't sure if it was a valid approach or not so I stopped working on it. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title David Schmitt updated an issue Puppet Strings / PDOC-266 Getting "unexpected construct regexp_literal" when using resource API title_patterns Change By: David Schmitt Method Found: Needs Assessment Customer Feedback Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title David Schmitt updated an issue Puppet Strings / PDOC-266 Getting "unexpected construct regexp_literal" when using resource API title_patterns Sean Millichamp, how big is the impact here? Is this only annoying, or does it break doc generation? If the latter, how hard? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDOC-266) Getting "unexpected construct regexp_literal" when using resource API title_patterns
Title: Message Title Sean Millichamp created an issue Puppet Strings / PDOC-266 Getting "unexpected construct regexp_literal" when using resource API title_patterns Issue Type: Bug Assignee: Unassigned Created: 2018/09/12 2:26 PM Priority: Normal Reporter: Sean Millichamp When running Puppet Strings against a type/provider that uses the `title_parameters` option in the Resource API I get this message: [warn]: in PuppetStrings::Yard::Handlers::Ruby::RsapiHandler: Undocumentable unexpected construct regexp_literal at lib/puppet/type/mytype.rb:5 I've narrowed it down to not liking the `title_patterns` parameter and, in particular, the regex value in it. Add Comment This message was sent by Atlassian
