Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Mihai Buzgau created an issue Puppet / PUP-10477 Remove non-local return from agent.rb Issue Type: Task Assignee: Unassigned Created: 2020/04/29 1:22 AM Priority: Normal Reporter: Mihai Buzgau [TODO] Add description Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Gheorghe Popescu Ideally we should never do a non-local return. It was added by mistake in https://github.com/puppetlabs/puppet/commit/ce74cd97085c3d3bd7b4888c80bcbf14ebfdfa2, was made worse in https://github.com/puppetlabs/puppet/commit/10d89dc463ebe8d31cee3a3603e924ae614f754a and a "different but equally wrong" approach was taken in https://github.com/puppetlabs/puppet/commit/42f1f27d914576be95b8745b6015897993f9aea3.It would be great to clean that up so that nil is always returned due to an error, so that [ TODO Puppet::Application::Agent consistently exits with 1.|https://github.com/puppetlabs/puppet/blob/42f1f27d914576be95b8745b6015897993f9aea3/lib/puppet/application/agent.rb#L360-L374 ] Add description Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To uns
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Mihai Buzgau Story Points: 3 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357118.158814853.49905.1588148640050%40Atlassian.JIRA.
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Gheorghe Popescu Ideally we should never do a non-local return. Code to be assesed assessed :- https://github.com/puppetlabs/puppet/commit/ce74cd97085c3d3bd7b4888c80bcbf14ebfdfa2- https://github.com/puppetlabs/puppet/commit/10d89dc463ebe8d31cee3a3603e924ae614f754a- https://github.com/puppetlabs/puppet/commit/42f1f27d914576be95b8745b6015897993f9aea3.It would be great to clean that up so that nil is always returned due to an error, so that [Puppet::Application::Agent consistently exits with 1.|https://github.com/puppetlabs/puppet/blob/42f1f27d914576be95b8745b6015897993f9aea3/lib/puppet/application/agent.rb#L360-L374] Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsub
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Gheorghe Popescu Ideally we should never do a non-local return. It was added by mistake in Code to be assesed:- https://github.com/puppetlabs/puppet/commit/ce74cd97085c3d3bd7b4888c80bcbf14ebfdfa2 , was made worse in - https://github.com/puppetlabs/puppet/commit/10d89dc463ebe8d31cee3a3603e924ae614f754a and a "different but equally wrong" approach was taken in - https://github.com/puppetlabs/puppet/commit/42f1f27d914576be95b8745b6015897993f9aea3.It would be great to clean that up so that nil is always returned due to an error, so that [Puppet::Application::Agent consistently exits with 1.|https://github.com/puppetlabs/puppet/blob/42f1f27d914576be95b8745b6015897993f9aea3/lib/puppet/application/agent.rb#L360-L374] Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Gheorghe Popescu assigned an issue to Gheorghe Popescu Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Gheorghe Popescu Assignee: Gheorghe Popescu Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357118.158814853.50011.1588157580094%40Atlassian.JIRA.
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Gheorghe Popescu Fix Version/s: PUP 6.16.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357118.158814853.70765.1590573420049%40Atlassian.JIRA.
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Ciprian Badescu Fix Version/s: PUP 5.5.21 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357118.158814853.100434.1593684120347%40Atlassian.JIRA.
Jira (PUP-10477) Remove non-local return from agent.rb
Title: Message Title Adrian Parreiras Horta commented on PUP-10477 Re: Remove non-local return from agent.rb For posterity, this fixes these kind of forking errors when managing the state of the agent service using a `service` resource: Jun 25 15:41:37 pe-201970-compile puppet-agent[9133]: Run of Puppet configuration client already in progress; skipping (/opt/puppetlabs/puppet/cache/state/agent_catalog_run.lock exists) Jun 25 15:41:37 pe-201970-compile puppet: /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/agent.rb:94:in `fork': unexpected return Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. T
