Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title Claire Cadman assigned an issue to Claire Cadman Puppet / PUP-10642 Uppercase Default value in conditional documentation a typo? Change By: Claire Cadman Assignee: Claire Cadman Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370111.159834180.35073.1600076520075%40Atlassian.JIRA.
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title Claire Cadman commented on PUP-10642 Re: Uppercase Default value in conditional documentation a typo? Thanks Henrik Lindberg! Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370111.159834180.35071.1600076460035%40Atlassian.JIRA.
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title
Henrik Lindberg commented on PUP-10642
Re: Uppercase Default value in conditional documentation a typo?
There should be more examples showing those other types of matches.
case $x {
Integer: { ... } # x is an Integer value
String[10]: { ...}# x is a string 10 or more chars long
String: { ... } # x is a string short than 10 (since option above took the longer ones}case [$x, $y] { [String, Integer]: { ... } # x is String and y is an Integer [10, "hello"]: { ... } # x is the integer 10, and y the string "hello" [1, default]: { ... }# x is the integer 1, and y can be any value (could also have been written Any)}
if that is not already in the documentation, it should be.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title
Henrik Lindberg commented on PUP-10642
Re: Uppercase Default value in conditional documentation a typo?
The intention was probably to have this (with a lower case default:
case $facts['os']['name'] {
'Solaris': {
include role::solaris
}
'RedHat', 'CentOS': {
include role::redhat
}
/^(Debian|Ubuntu)$/: {
include role::debian
}
default: {
include role::generic
}
}
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title
Claire Cadman commented on PUP-10642
Re: Uppercase Default value in conditional documentation a typo?
Henrik Lindberg, so would you remove the entire case statement example: A case statement evaluates a list of cases against a control _expression_, and executes the first code block where the case value matches the control _expression_. This example declares a role class on a node, but which role class it declares depends on what operating system the node runs: {{}}
case $facts['os']['name'] {
'Solaris': {
include role::solaris
}
'RedHat', 'CentOS': {
include role::redhat
}
/^(Debian|Ubuntu)$/: {
include role::debian
}
Default: {
include role::generic
}
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title Henrik Lindberg commented on PUP-10642 Re: Uppercase Default value in conditional documentation a typo? The docs shows two examples; one with uppercase and one with lower case. Only the lower case is explained, and the other is quite advanced. Simply remove the example with the upper case Default to at least not make it confusing, but why the example outputs that it is using a "lowercase" default is a mystery. Would make sense if the first option was an os name in upper case, for example "Debian", with a notice "this is a debian", and the "default" says "this is not debian" - or something like that Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370111.159834180.29435.1599070980045%40Atlassian.JIRA.
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title Claire Cadman commented on PUP-10642 Re: Uppercase Default value in conditional documentation a typo? Josh Cooper just to confirm, `Default` should have a lower case `d`? Thanks! Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370111.159834180.29241.1599063480179%40Atlassian.JIRA.
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title Josh Cooper commented on PUP-10642 Re: Uppercase Default value in conditional documentation a typo? I think this is accidental in this case. We'll take a look, thanks for letting us know. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370111.159834180.23593.1598382600122%40Atlassian.JIRA.
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title Henrik Lindberg commented on PUP-10642 Re: Uppercase Default value in conditional documentation a typo? An uppercase bare word like Default is a reference to a datatype. There happens to be a datatype named Default and it matches the value that results when you type default. So - the example will either match a literal default (with the Default entry), or a missing value (the default entry). While not wrong per se. if that is what the documentation is trying to show it should say so, otherwise it is just cryptic. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370111.159834180.23067.1598354460036%40Atlassian.JIRA.
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title
Michael Krause updated an issue
Puppet / PUP-10642
Uppercase Default value in conditional documentation a typo?
Change By:
Michael Krause
*Puppet Version: 6.17* {{Starting with 6.x it seems the [documentation for case conditionals|https://puppet.com/docs/puppet/6.17/lang_conditional.html]}} shows an uppercase `Default` as catch-call value. Since this doesn't work and would also be inconsistent to the selector statement I'm carefully assuming it's a (grave) typo?{{This test seems to confirm:}} {code:java} class test { case $facts['os']['name'] {Default: { notify {'uppercase default':} } } case $facts['os']['name'] {default: { notify {'lowercase default':} } }}include test{code} {{And the log:}} { { noformat} root@host :~# puppet apply test.pp }}{{ {{ Notice: Compiled catalog for host in environment production in 0.02 seconds {{ {{ Notice: lowercase default {{ {{ Notice: /Stage[main]/Test/Notify[lowercase default]/message: defined 'message' as 'lowercase default' {{ {{ Notice: Applied catalog in 0.06 seconds {noformat } }}}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title
Michael Krause updated an issue
Puppet / PUP-10642
Uppercase Default value in conditional documentation a typo?
Change By:
Michael Krause
*Puppet Version: 6.17* ** ** {{Starting with 6.x it seems the [documentation for case conditionals }}{{ |https://puppet.com/docs/puppet/6.17/lang_conditional.html]}} {{ shows an uppercase `Default` as catch-call value. Since this doesn't work and would also be inconsistent to the selector statement I'm carefully assuming it's a (grave) typo? }} {{This test seems to confirm:}} {{class test {}}{{ case $facts['os']['name'] {}} {{ Default: \{ notify {'uppercase default':} }}} {{ }}} {{ case $facts['os']['name'] {}} {{ default: \{ notify {'lowercase default':} }}} {{ }}}{{}}}{{include test}} {{ And the log:}} {{root@host :~# puppet apply test.pp }}{{ {{ Notice: Compiled catalog for host in environment production in 0.02 seconds}} }} {{ {{ Notice: lowercase default}} }} {{ {{ Notice: /Stage[main]/Test/Notify[lowercase default]/message: defined 'message' as 'lowercase default'}} }} {{ {{ Notice: Applied catalog in 0.06 seconds}} }}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10642) Uppercase Default value in conditional documentation a typo?
Title: Message Title
Michael Krause created an issue
Puppet / PUP-10642
Uppercase Default value in conditional documentation a typo?
Issue Type:
Bug
Affects Versions:
PUP 6.y
Assignee:
Unassigned
Components:
Docs
Created:
2020/08/25 12:50 AM
Priority:
Major
Reporter:
Michael Krause
Puppet Version: 6.17 ** ** Starting with 6.x it seems the documentation for case conditionals}} shows an uppercase `Default` as catch-call value. Since this doesn't work and would also be inconsistent to the selector statement I'm carefully assuming it's a (grave) typo?}} This test seems to confirm: class test { case $facts['os']['name'] { {{ Default: { notify {'uppercase default':} }}} {{ }}} case $facts['os']['name'] { {{ default: { notify {'lowercase default':} }}} {{ }}} } include test And the log: {{root@host :~# puppet apply test.pp }} Notice: Compiled catalog for host in environment production in 0.02 seconds Notice: lowercase default Notice: /Stage[main]/Test/Notify[lowercase default]/message: defined 'message' as 'lowercase default' Notice: Applied catalog in 0.06 seconds
