Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Josh Cooper Fix Version/s: PUP 7.21.0 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.4379.1678403100021%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Lukas Erlacher commented on PUP-10688 Re: tidy resource does not honor schedule metaparameter I am very glad to see this has been picked up! Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.61679.1669690320042%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Michael Hashizume assigned an issue to Michael Hashizume Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Michael Hashizume Assignee: Michael Hashizume Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.61590.1669671840044%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Josh Cooper commented on PUP-10688 Re: tidy resource does not honor schedule metaparameter This should be trivial to fix now that PUP-11631 is resolved. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.58523.1668533160044%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Morgan Rhodes Story Points: 2 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.57475.1668103740065%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Morgan Rhodes Sprint: Phoenix 2022-12-7 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.57476.1668103740113%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Josh Cooper Sprint: Phoenix 2022-11-23 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.53350.1666889820044%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Josh Cooper Team: Phoenix Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.52796.1666806720028%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Josh Cooper Sprint: Phoenix 2022-11- 09 23 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.52795.1666806660059%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Morgan Rhodes Sprint: Phoenix 2022-11-09 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.49490.1666216020070%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Josh Cooper commented on PUP-10688 Re: tidy resource does not honor schedule metaparameter Lukas Erlacher yes in general metaparameters should be copied from the parent to the child resource, except for the "alias" metaparameter. See my comment in https://tickets.puppetlabs.com/browse/PUP-11631?focusedCommentId=876236=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-876236 and related ticket PUP-10688. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.48695.1666110360039%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Lukas Erlacher commented on PUP-10688 Re: tidy resource does not honor schedule metaparameter Poking this again since this is still an issue. Is anyone reading this? I tracked down the code: https://github.com/puppetlabs/puppet/blob/eb498be4bf7b4dbb326dbd479d01101f0b226abb/lib/puppet/type/tidy.rb#L243 And the root cause seems to be that the only metaparameter that is inherited into the file-to-delete resources is `noop`: https://github.com/puppetlabs/puppet/blob/eb498be4bf7b4dbb326dbd479d01101f0b226abb/lib/puppet/type/tidy.rb#L250 So, the `schedule` metaparameter should be added there, and more broadly, it should be checked whether other metaparameters should be added too. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.47228.1665968940047%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title
Lukas Erlacher commented on PUP-10688
Re: tidy resource does not honor schedule metaparameter
Are there any hacky workarounds for this, something like switching it to {{noop }}based on current time?
Add Comment
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.27687.1662432780044%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-10688 tidy resource does not honor schedule metaparameter Change By: Morgan Rhodes Epic Link: PUP-11619 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.374080.1602010849000.25130.1661891340055%40Atlassian.JIRA.
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title
Lukas Erlacher commented on PUP-10688
Re: tidy resource does not honor schedule metaparameter
Hi, I am using puppet 6 open source and just ran into this issue. My usecase is cleaning up old puppet report files. We have a large number of clients so cleaning up the report files creates a lot of log spam that I want to contain. This is my puppet code:
schedule { 'daily tidy':
period => daily,
range => '2-3',
}
tidy { '/opt/puppetlabs/server/data/puppetserver/reports':
recurse => true,
age => '90d',
type => mtime,
schedule => 'daily tidy',
}
This is the output:
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Michael Luck commented on PUP-10688 Re: tidy resource does not honor schedule metaparameter Josh Cooper Ran some debug runs on two computers...looks like it works properly on one but not another. Computer A: ... ←[0;36mDebug: Loaded state in 0.02 seconds←[0m ←[0;36mDebug: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\os_patching]: Tidying File[C:/ProgramData/os_patching/os_patching_fact_generation-2020_10_08-01_48_45.log]←[0m ←[0;36mDebug: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\os_patching]: Tidying File[C:/ProgramData/os_patching/os_patching_fact_generation-2020_10_08-13_46_10.log]←[0m ←[mNotice: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\os_patching]: Tidying 2 files←[0m ←[0;36mDebug: Loaded transaction store file in 0.04 seconds←[0m ←[0;32mInfo: Applying configuration version '1602700361'←[0m ... Computer B: ... Debug: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\InstalledUpdates]: Not scheduled Debug: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\InstalledUpdates]: Resource is being skipped, unscheduling all events Debug: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\os_patching]: Not scheduled Debug: /Stage[main]/Windows_patch_mgmt2/Tidy[C:\ProgramData\os_patching]: Resource is being skipped, unscheduling all events ... Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title Michael Luck commented on PUP-10688 Re: tidy resource does not honor schedule metaparameter Josh Cooper That is interesting...here is my output from Puppet DB. It should only be running on Sundays but it is not for some reason. Oct 14 2020 - 14:03:41 /Stage[main]/Windows_patch_mgmt/Tidy[C:\ProgramData\os_patching] notice, tidy, class, windows_patch_mgmt, node, default Tidying 1 files /etc/puppetlabs/code/environments/production/manifests/patch_mgmt.pp:84 Oct 14 2020 - 14:04:40 /Stage[main]/Windows_patch_mgmt/File[C:/ProgramData/os_patching/os_patching_fact_generation-2020_10_07-13_46_02.log]/ensure notice, file, tidy, class, windows_patch_mgmt, node, default removed Oct 14 2020 - 14:06:59 Puppet notice Applied catalog in 198.57 seconds Add Comment
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title
Josh Cooper commented on PUP-10688
Re: tidy resource does not honor schedule metaparameter
I can't reproduce this:
C:\Users\josh\projects\puppet>type tidy.pp
schedule { 'cleanup_window':
weekday => 'Sunday'
}
tidy { 'C:\tmp\tidy':
age => '1w',
matches => '*.log',
recurse => true,
schedule=> 'cleanup_window'
}
C:\Users\josh\projects\puppet>bundle exec puppet apply --debug tidy.pp
...
Debug: Creating default schedules
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title
Michael Luck updated an issue
Puppet / PUP-10688
tidy resource does not honor schedule metaparameter
Change By:
Michael Luck
When using schedule and recurse with the tidy resource, it will apply on every Puppet run rather than adhering to the given schedule. For example, I run this tidy resource to clean up log files on some Windows agents. I expected it to only run on Sundays as indicated by the schedule but it will execute on every Puppet run instead. {code:java} schedule { 'cleanup_window': weekday => 'Sunday' } tidy { 'C:\ProgramData\os_patching': age => '1w', matches => '*.log', recurse => true, schedule => 'cleanup_window' } {code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title
Michael Luck updated an issue
Puppet / PUP-10688
tidy resource does not honor schedule metaparameter
Change By:
Michael Luck
When using schedule and recurse with the tidy resource, it will apply on every Puppet run rather than adhering to the given schedule. For example, I run this tidy resource to clean up log files on some Windows agents. I expected it to only run on Sundays as indicated by the schedule but it will execute on every Puppet run instead. {{ schedule { 'cleanup_window': }} {{ weekday => 'Sunday' }} {{ } }} {{ tidy { 'C:\ProgramData\os_patching': }} {{ age => '1w', }} {{ matches => '*.log', }} {{ recurse => true, }} {{ schedule => 'cleanup_window' }} {{ } }}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-10688) tidy resource does not honor schedule metaparameter
Title: Message Title
Michael Luck created an issue
Puppet / PUP-10688
tidy resource does not honor schedule metaparameter
Issue Type:
Bug
Affects Versions:
PUP 6.18.0
Assignee:
Unassigned
Created:
2020/10/06 12:00 PM
Priority:
Normal
Reporter:
Michael Luck
When using schedule and recurse with the tidy resource, it will apply on every Puppet run rather than adhering to the given schedule. For example, I run this tidy resource to clean up log files on some Windows agents. I expected it to only run on Sundays as indicated by the schedule but it will execute on every Puppet run instead. {{ schedule { 'cleanup_window':}} {{ weekday => 'Sunday'}} {{ }}} tidy { 'C:\ProgramData\os_patching': age => '1w', matches => '*.log', recurse => true, schedule => 'cleanup_window' {{ }}}
Add Comment
