Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Kurt Wall updated an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Adrien Thebo commented on an issue Re: create_resources auto importing a manifest with a syntax error produce a bad error message Verified in master. Before: └ bundle exec puppet apply -e 'create_resources(kaboom, {foo = {}})' Error: exception object expected at line 1 on node grey.somethingsinistral.net Wrapped exception: exception object expected Error: exception object expected at line 1 on node grey.somethingsinistral.net After: └ bundle exec puppet apply -e 'create_resources(kaboom, {foo = {}})' Error: Syntax error at ','; expected '}' at /home/adrien/.puppet/modules/kaboom/manifests/init.pp:2 on node grey.somethingsinistral.net Error: Syntax error at ','; expected '}' at /home/adrien/.puppet/modules/kaboom/manifests/init.pp:2 on node grey.somethingsinistral.net Add Comment Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Given a module with this structure: {noformat} x └── manifests ├── init.pp └── y.pp {noformat} init.pp: {noformat} class x { $r = {one = {foo = bar}} create_resources(x::y, $r) } {noformat} and y.pp which has an obvious syntax error: {code} define x::y { obvious error should be obvious } {code} ...
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Adrien Thebo updated an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Adrien Thebo Fix Version/s: 3.7.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Andy Parker updated an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Andy Parker Component/s: DSL Component/s: Community Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Julien Pivotto commented on an issue Re: create_resources auto importing a manifest with a syntax error produce a bad error message See GH-2761 https://github.com/puppetlabs/puppet/pull/2761 Add Comment Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Given a module with this structure: {noformat} x └── manifests ├── init.pp └── y.pp {noformat} init.pp: {noformat} class x { $r = {one = {foo = bar}} create_resources(x::y, $r) } {noformat} and y.pp which has an obvious syntax error: {code} define x::y { obvious error should be obvious } {code} ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Julien Pivotto updated an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Julien Pivotto Assignee: JulienPivotto Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Julien Pivotto assigned an issue to Julien Pivotto Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Julien Pivotto Assignee: FelixFrank JulienPivotto Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Felix Frank updated an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Felix Frank Givenamodulewiththisstructure: pre {noformat} x└──manifests├──init.pp└──y.pp/preinit.pp:preclassx{$r={one={foo=bar}}create_resources(x::y,$r)} /pre {noformat} andy.ppwhichhasanobvioussyntaxerror: pre {code} definex::y{obviouserrorshouldbeobvious} /pre {code} Igetthefollowingerror: pre {noformat} %puppetapply--modulepath=`pwd`-e'includex'Error:exceptionobjectexpectedat/home/rip/temp/x/manifests/init.pp:4onnodedevco.netWrappedexception:exceptionobjectexpectedError:exceptionobjectexpectedat/home/rip/temp/x/manifests/init.pp:4onnodedevco.net /pre {noformat} What'shappeninghereisthey.pponlygetsimportedduringtheprocessingofcreate_resourcesandinsidecreate_resourcestheparseerrorisincorrectlyhandled.Inthiscasethefollowingcode: pre {code} beginresource.safeevaluate(self)rescuePuppet::ParseError=internal_errorraiseinternal_error.originalend /pre {code} hasanilfororiginalintheinternal_errorobjectandsoitfails. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Felix Frank updated an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Felix Frank Givenamodulewiththisstructure:{noformat}x└──manifests├──init.pp└──y.pp /pre {noformat} init.pp: pre {noformat} classx{$r={one={foo=bar}}create_resources(x::y,$r)}{noformat}andy.ppwhichhasanobvioussyntaxerror:{code}definex::y{obviouserrorshouldbeobvious}{code}Igetthefollowingerror:{noformat}%puppetapply--modulepath=`pwd`-e'includex'Error:exceptionobjectexpectedat/home/rip/temp/x/manifests/init.pp:4onnodedevco.netWrappedexception:exceptionobjectexpectedError:exceptionobjectexpectedat/home/rip/temp/x/manifests/init.pp:4onnodedevco.net{noformat}What'shappeninghereisthey.pponlygetsimportedduringtheprocessingofcreate_resourcesandinsidecreate_resourcestheparseerrorisincorrectlyhandled.Inthiscasethefollowingcode:{code}beginresource.safeevaluate(self)rescuePuppet::ParseError=internal_errorraiseinternal_error.originalend{code}hasanilfororiginalintheinternal_errorobjectandsoitfails. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title Felix Frank assigned an issue to Felix Frank Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Change By: Felix Frank Assignee: FelixFrank Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1100) create_resources auto importing a manifest with a syntax error produce a bad error message
Title: Message Title redmine.exporter created an issue Puppet / PUP-1100 create_resources auto importing a manifest with a syntax error produce a bad error message Issue Type: Bug Assignee: Unassigned Created: 16/Dec/13 11:45 AM Labels: redmine Priority: Normal Reporter: redmine.exporter Given a module with this structure: pre x └── manifests ├── init.pp └── y.pp /pre init.pp: pre class x { $r = {one = {foo = bar}} create_resources(x::y, $r) } /pre and y.pp which has an obvious syntax error: pre define x::y { obvious error should be obvious } /pre I get the following error: pre % puppet apply --modulepath=`pwd` -e 'include x' Error: exception object expected at /home/rip/temp/x/manifests/init.pp:4 on node devco.net Wrapped exception: exception object expected Error: exception object expected at /home/rip/temp/x/manifests/init.pp:4 on node devco.net /pre What's happening here is the y.pp only gets imported during the processing of create_resources and inside create_resources the parse error is incorrectly handled. In this case the following code: pre begin resource.safeevaluate(self) rescue Puppet::ParseError = internal_error raise internal_error.original end /pre has a nil for original in the internal_error object and so