Jira (PUP-11662) Allow legacy facts to be excluded

2022-12-07 Thread Parker Leach (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parker Leach updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Parker Leach  
 
 
Labels: 
 docs_reviewed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.64833.1670447640031%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-11-22 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Acceptance Criteria: 
 By default there should be no change in how the agent collects or sends facts (legacy, core, external or custom)If legacy facts are disabled,  via include_legacy_facts=false or --no-include_legacy_facts,  then the agent should not send legacy facts. However, types and providers that confine or set defaultsfor based on legacy facts should still work. Also custom and external facts should continue to be sent.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.60491.1669141440044%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-11-09 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Sprint: 
 Phoenix 2022-11-09 , Phoenix 2022-11-23  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.57122.1668017160261%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-11-02 Thread Tony Vu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Assignee: 
 Tony Vu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.55182.1667414640255%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-11-01 Thread Tony Vu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu assigned an issue to Tony Vu  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Assignee: 
 Tony Vu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.54589.1667318880209%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-11-01 Thread Tony Vu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Assignee: 
 Josh Cooper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.54588.1667318880159%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-31 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Puppet agents send core facts to puppetserver in two forms (legacy and structured). In a default agent install, legacy facts account for 25% of the overall fact data when serialized on the wire. The actual savings depends on the number of processors, block devices and network interfaces, because facter adds multiple legacy facts per instance:{noformat}blockdevice_sda_model => ...blockdevice_sda_size => 1024209543168blockdevice_sda_vendor => ..processor0 => 11th Gen ...processor1 => 11th Gen ..processorN => 11th Gen ..ipaddress6_lo => ::1ipaddress_lo => 127.0.0.1mtu_lo => 65536netmask6_lo => :::::::netmask_lo => 255.0.0.0network6_lo => ::1network_lo => 127.0.0.0scope6_lo => host{noformat}And legacy facts cause problems for puppetserver when using ERB templates because of the way top-scope variables are bound to instance variables in the scope. See PUP-9577Most of the puppet ecosystem has moved to structured facts, for example, there is a puppet-lint plugin to find and correct legacy fact usage in puppet modules: https://github.com/mmckinst/puppet-lint-legacy_facts-checkWhile it's possible to block legacy facts (using facter's block list)  it puts the burden , doing so breaks puppet's builtin providers, as they rely  on  users to make that change.  legacy facts for confining and defaulting providers, see PUP-11430 This ticket is to allow the agent to exclude legacy facts that it sends to puppetserver. The default behavior should remain the same in 7.x and in 8.0 we can exclude legacy facts by default (see PUP-11430).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
  

Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-27 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Acceptance Criteria: 
 By default there should be no change in how the agent collects or sends facts (legacy, core, external or custom)If legacy facts are disabled, then the agent should not send legacy facts. However, types and providers that confine or set defaultsfor based on legacy facts should still work. Also custom and external facts should continue to be sent.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.53286.1666885980060%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-26 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.52749.1666805160413%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-26 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Josh Cooper  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Josh Cooper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.52402.1666765920049%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-25 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes: 
 Enhancement  
 
 
Release Notes Summary: 
 Adds a puppet setting "include_legacy_facts" to control whether legacy facts are sent to puppetserver when requesting a catalog. By default, puppet continues to send legacy facts, but it can be disabled provided all puppet manifests, hiera.yaml and hiera configuration layers have been modified to no longer use legacy facts.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.52401.1666763520058%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-25 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Fix Version/s: 
 PUP 7.21.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.52268.1666729920042%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-25 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Sprint: 
 Phoenix 2022-11-09  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.52269.1666729920097%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-25 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 7.21.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.52116.1666716720050%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-24 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11619  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.51659.134880026%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-24 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 7.21.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472752.1666307268000.51655.134760137%40Atlassian.JIRA.


Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-20 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Puppet agents send core facts to puppetserver in two forms (legacy and structured). In a default agent install, legacy facts account for 25% of the overall fact data when serialized on the wire. The actual savings depends on the number of  mountpoints  processors ,  block devices and  network interfaces  and processors ,  since  because  facter adds  one  multiple  legacy  fact  facts  per instance :{noformat}blockdevice_sda_model => . ..  blockdevice_sda_size => 1024209543168  blockdevice_sda_vendor => ..processor0 => 11th Gen ...processor1 => 11th Gen ..processorN => 11th Gen ..ipaddress6_lo => ::1ipaddress_lo => 127.0.0.1mtu_lo => 65536netmask6_lo => :::::::netmask_lo => 255.0.0.0network6_lo => ::1network_lo => 127.0.0.0scope6_lo => host{noformat} And legacy facts cause problems for puppetserver when using ERB templates because of the way top-scope variables are bound to instance variables in the scope. See PUP-9577Most of the puppet ecosystem has moved to structured facts, for example, there is a puppet-lint plugin to find and correct legacy fact usage in puppet  code  modules : https://github.com/mmckinst/puppet-lint-legacy_facts-check While it's possible to block legacy facts (using facter's block list) it puts the burden on users to make that change. This ticket is to allow the agent to exclude legacy facts that it sends to puppetserver. The default behavior should remain the same in 7.x and in 8.0 we can exclude legacy facts by default (see PUP-11430).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 

Jira (PUP-11662) Allow legacy facts to be excluded

2022-10-20 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11662  
 
 
  Allow legacy facts to be excluded   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2022/10/20 4:07 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 Puppet agents send core facts to puppetserver in two forms (legacy and structured). In a default agent install, legacy facts account for 25% of the overall fact data when serialized on the wire. The actual savings depends on the number of mountpoints, network interfaces and processors, since facter adds one legacy fact per instance. And legacy facts cause problems for puppetserver when using ERB templates because of the way top-scope variables are bound to instance variables in the scope. See PUP-9577 Most of the puppet ecosystem has moved to structured facts, for example, there is a puppet-lint plugin to find and correct legacy fact usage in puppet code: https://github.com/mmckinst/puppet-lint-legacy_facts-check This ticket is to allow the agent to exclude legacy facts that it sends to puppetserver. The default behavior should remain the same in 7.x and in 8.0 we can exclude legacy facts by default (see PUP-11430).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment