Jira (PUP-1237) File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf

2014-06-20 Thread Alexander Birkner (JIRA)
Title: Message Title










 

 Alexander Birkner commented on an issue


















  Re: File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf 










Are there any updates?












   

 Add Comment

























 Puppet /  PUP-1237



  File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf 







 In the current 3.0.0 release, the file serving configuration parser incorrectly handles allow_ip statements in fileserver.conf. Both an allow and allow_ip statement will result in Puppet::FileServing::Configuration::Parser.allow being called, which again calls Puppet::Network::AuthStore.allow.   This will raise an AuthStoreError in case of an allow_ip ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1237) File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf

2014-01-11 Thread Pamela Harrison (JIRA)
Title: Message Title










 

 Pamela Harrison commented on an issue


















  Re: File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf 










Link to Red Mine contains diff file showing issue.












   

 Add Comment

























 Puppet /  PUP-1237



  File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf 







 In the current 3.0.0 release, the file serving configuration parser incorrectly handles allow_ip statements in fileserver.conf. Both an allow and allow_ip statement will result in Puppet::FileServing::Configuration::Parser.allow being called, which again calls Puppet::Network::AuthStore.allow.   This will raise an AuthStoreError in case of an allow_ip ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1237) File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf

2013-12-24 Thread redmine.exporter (JIRA)
Title: Message Title










 

 redmine.exporter created an issue


















 Puppet /  PUP-1237



  File-Serving Configuration parser does not implement allow_ip statements in fileserver.conf 










Issue Type:

  Bug




Assignee:


 Unassigned




Created:


 24/Dec/13 8:09 AM




Labels:


 redmine




Priority:

  Normal




Reporter:

 redmine.exporter










In the current 3.0.0 release, the file serving configuration parser incorrectly handles allow_ip statements in fileserver.conf. Both an allow and allow_ip statement will result in Puppet::FileServing::Configuration::Parser.allow being called, which again calls Puppet::Network::AuthStore.allow.
This will raise an AuthStoreError in case of an allow_ip statement, as Puppet::Network::AuthStore::Declaration.parse fails to parse the parameter. The fix is to call Puppet::Network::AuthStore.allow_ip instead in case an allow_ip statement is read, which will delegate the parsing to the correct method (Puppet::Network::AuthStore::Declaration.parse_ip)
The attached diff illustrates the issue and a possible fix.












   

 Add Comment