Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-27 Thread Tony Vu (JIRA)
Title: Message Title










 

 Tony Vu commented on an issue


















  Re: Puppet module tool should work with new directory environments 










I have confirmed that the puppet module command --environment direnv commands all respect the directory environment; I used the puppet man module to give a general suite of commands to test for this particular area. However, I do think that there should be a test plan developed around setting the environment directory, to ensure that PUP-1765 is not the only breakage around this change for environments. I'll create a QA ticket to track that.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-27 Thread Tony Vu (JIRA)
Title: Message Title










 

 Tony Vu commented on an issue


















  Re: Puppet module tool should work with new directory environments 










To clarify my expectation a bit; I would expect the --force option to look at all the directories that are a part of the environment direnv, not just the top level. For the directory environment direnv, the modulepath would have multiple locations:
modulepath = /etc/puppet/environments/direnv/modules:/etc/puppet/modules:/usr/share/puppet/modules
So maybe the issue more specifically is something like --force doesn't look in all module path directories. 
At any rate, this behavior is consistent with a similar situation with the default directory locations, /etc/puppet/modules and /usr/share/puppet/modules, so the issue I am describing existed before this environment directory change and doesn't hold up this ticket from exiting functional review.
I'll bring this issue up with the forge team.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-27 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow commented on an issue


















  Re: Puppet module tool should work with new directory environments 










I see what you are saying; the modulepath is not the target-dir and I think it's only looking in the target-dir (which ends up being the first element of modulepath). So that might be a clarification of the docs, or a change to the --force option.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-26 Thread Tony Vu (JIRA)
Title: Message Title










 

 Tony Vu assigned an issue to Tony Vu


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Tony Vu




Assignee:

 TonyVu












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-26 Thread Tony Vu (JIRA)
Title: Message Title










 

 Tony Vu commented on an issue


















  Re: Puppet module tool should work with new directory environments 










Testing has looked good so far, there is one test scenario that I tried that did not meet my expectations. Is my expectation correct in this situation?
Steps:
1. Create an environments/direnv/modules' in your puppet installation folder 2. Execute 'puppet module install saz/ntp' == this should put the module in /etc/puppet/modules 3. Execute 'puppet module install saz/ntp --environment direnv --force'
Expectation: The module should be reinstalled in /etc/puppet/modules
Result: The module is installed in the /etc/puppet/environments/direnv/modules.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-26 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow commented on an issue


















  Re: Puppet module tool should work with new directory environments 










I believe that --force just forces the installation into the current environment regardless of previous installation or conflicts. Since saz/ntp had not yet been installed in --envirionment direnv, it was installed there. If you repeated the command to install without --force, it should raise an error, with --force it should reinstall. But you might want to double check with someone on the forge team.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-20 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow assigned an issue to Unassigned


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Joshua Partlow




Assignee:

 JoshuaPartlow












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-19 Thread Kurt Wall (JIRA)
Title: Message Title










 

 Kurt Wall commented on an issue


















  Re: Puppet module tool should work with new directory environments 










Joshua Partlow I'd like to formalize the testing I've done for dir envs so far. I would like to write a full-on test plan for the directory environments work, so we should sit down to talk about use cases. I'll schedule a meeting...












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-18 Thread Andrew Parker (JIRA)
Title: Message Title










 

 Andrew Parker assigned an issue to Andrew Parker


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Andrew Parker




Assignee:

 AndrewParker












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-18 Thread Andrew Parker (JIRA)
Title: Message Title










 

 Andrew Parker assigned an issue to Joshua Partlow


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Andrew Parker




Assignee:

 AndrewParker JoshuaPartlow












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-18 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow commented on an issue


















  Re: Puppet module tool should work with new directory environments 










Merged to master in f102a1f












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-18 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow commented on an issue


















  Re: Puppet module tool should work with new directory environments 










Kurt Wall `puppet man module` lists several uses cases for the module tool actions with a specified environment. These should work both with a legacy and a directory environment. Some of the cases are covered (or should be) by the modified acceptance tests.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-12 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow commented on an issue


















  Re: Puppet module tool should work with new directory environments 










After talking with Andy, I'm moving the configprint issues out into their own ticket, because I have a separate fix specific to module tools and we discussed a different approach for the configprint problems.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 







 Given two environments, a legacy environment 'legacyenv' defined in puppet.conf and a 'direnv' directory in the established $environmentdir, `puppet module install --environment env` will respect the legacy environment but not the directory environment. This probably needs to be fixed for all the module functions, but I haven't tested everything yet.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at 

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-12 Thread Michelle Johansen (JIRA)
Title: Message Title










 

 Michelle Johansen updated an issue


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Michelle Johansen




Sprint:

 Week2014-2-5to2014-2-12 ,Week2014-2-12to2014-2-19












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-10 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow assigned an issue to Joshua Partlow


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Joshua Partlow




Assignee:

 EricSorenson JoshuaPartlow












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-10 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow commented on an issue


















  Re: Puppet module tool should work with new directory environments 










More fundamentally, given:



jpartlow@percival:~/work/puppet$ cat ~/.puppet/puppet.conf 
[legacy]
modulepath=/home/jpartlow/work/tmp/envs/legacy

jpartlow@percival:~/work/puppet$ tree ~/.puppet/environments/
/home/jpartlow/.puppet/environments/
└── direnv
└── modules

2 directories, 0 files



then



jpartlow@percival:~/work/puppet$ be puppet agent --configprint modulepath
/home/jpartlow/.puppet/modules:/usr/share/puppet/modules
jpartlow@percival:~/work/puppet$ be puppet agent --configprint modulepath --environment legacy
/home/jpartlow/work/tmp/envs/legacy



but



jpartlow@percival:~/work/puppet$ be puppet agent --configprint modulepath --environment direnv
/home/jpartlow/.puppet/modules:/usr/share/puppet/modules



because in https://github.com/puppetlabs/puppet/blob/master/lib/puppet/settings.rb#L1049-L1070 expects to find environment settings in a legacy puppet.conf section as provided by searchpath(environment).
Ultimately that's what is happening here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/module_tool.rb#L121 and with a directory environment, modulepath just gets set to the default.












   

 Add Comment

























 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 



  

Jira (PUP-1584) Puppet module tool should work with new directory environments

2014-02-04 Thread Joshua Partlow (JIRA)
Title: Message Title










 

 Joshua Partlow updated an issue


















 Puppet /  PUP-1584



  Puppet module tool should work with new directory environments 










Change By:

 Joshua Partlow




Sprint:

 Week2014-2-5to2014-2-12












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.