Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title
Eric Thompson commented on an issue
Re: Remove 1.8.7 multibyte string support in Lexer2
verified that multibyte still works on fedora20 at SHA 07e25c5
puppet apply -e "notify { 'Iñtërnâtiônàlizætiøn': }"
Notice: Compiled catalog for hpe6fecl2h9sx8p.delivery.puppetlabs.net in environment production in 0.01 seconds
Notice: Iñtërnâtiônàlizætiøn
Notice: /Stage[main]/Main/Notify[Iñtërnâtiônàlizætiøn]/message: defined 'message' as 'Iñtërnâtiônàlizætiøn'
Notice: Finished catalog run in 0.02 seconds
Add Comment
Puppet / PUP-2411
Remove 1.8.7 multibyte string support in Lexer2
There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed.
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Eric Thompson commented on an issue Re: Remove 1.8.7 multibyte string support in Lexer2 interesting. does this imply the need for integration level tests? i don't understand the lexer enough to evaluate what type of spec could cover this. opinion? i'll FR this and put some notes in here for any future integration test. i'm assuming low priority on frequency of use on multibyte strings in manifests? Add Comment Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Andy Parker commented on an issue Re: Remove 1.8.7 multibyte string support in Lexer2 Eric Thompson, one thing that I notice from this is that we have no automated test failures and the PR didn't remove any test coverage. That makes me think that there isn't good/any coverage around multibyte characters in manifests. Add Comment Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Eric Thompson commented on an issue Re: Remove 1.8.7 multibyte string support in Lexer2 doesn't look like this needs FR, particularly... comments? i'll check it out and spit some various smoke manifests at it... Add Comment Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Eric Thompson updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Eric Thompson QA Contact: Kurt Wall Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Joshua Partlow commented on an issue Re: Remove 1.8.7 multibyte string support in Lexer2 Merged to puppet-4 branch in 7b871c00 Add Comment Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Joshua Partlow assigned an issue to Joshua Partlow Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Joshua Partlow Assignee: Joshua Partlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Joshua Partlow assigned an issue to Unassigned Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Joshua Partlow Assignee: Joshua Partlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Joshua Partlow assigned an issue to Joshua Partlow Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Joshua Partlow Assignee: Joshua Partlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Henrik Lindberg Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Steve Barlow updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Steve Barlow Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Henrik Lindberg Story Points: 2 1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg commented on an issue Re: Remove 1.8.7 multibyte string support in Lexer2 Hm... the StringScanner.charpos method was not added in 1.9.3 as I though, it is not available until Ruby 2.0.0. It is also slower to use character positions throughout the lexer implementation. Instead I propose the following: Add information to the Program model element that encodes if the content's offset values is measured in bytes or in chars. The offset value is opaque and must be given to a Locator to get the correct char offsets. The Ruby based parser simply uses the scheme it has now If something else parses and sends a serialized Program with char offsets, the only thing that is needed is to use the Locator18 which is for Ruby 1.8.7 where 1 byte == 1 char. That locator naturally also works when the offsets are already measured in chars. The implementation is a small change to the API of the Locator, and an extra attribute in the Program object. Changing story points to 1. Add Comment Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Henrik Lindberg Story Points: 1 2 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg commented on an issue Re: Remove 1.8.7 multibyte string support in Lexer2 This should also make it possible to specify that the offsets used in the Program's line index (and what is recorded as offset in all model elements is measured in characters and not in bytes. This may have performance implications since it is actually faster to use the offsets than the character based support added in Ruby 1.9 - unsure how much this was though; if it is fractional it is worth making the change anyway. Add Comment Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit thi
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Henrik Lindberg Sprint: 2014-09- 03 17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Joshua Partlow updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Joshua Partlow Sprint: 2014- 08 09 - 20 03 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Kenn Hussey Sprint: Week 2014- 7 08 - 23 06 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Henrik Lindberg Sprint: Week 2014-7- 9 23 to 2014- 7 8 - 23 6 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Andy Parker updated an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Change By: Andy Parker Sprint: Week 2014-7-9 to 2014-7-23 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2411) Remove 1.8.7 multibyte string support in Lexer2
Title: Message Title Henrik Lindberg created an issue Puppet / PUP-2411 Remove 1.8.7 multibyte string support in Lexer2 Issue Type: Improvement Assignee: Andy Parker Components: DSL Created: 01/May/14 5:20 AM Fix Versions: 4.0.0 Priority: Normal Reporter: Henrik Lindberg There is support for Ruby 1.8.7 multibyte strings in the Lexer. Since Suport for Ruby 1.8.7 is being dropped for 4.0 (PUP-1805). This logic can be removed. Add Comment
