Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Jorie Tappa Labels: redmine resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Moses Mendoza Labels: redmine triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title
Eric Thompson commented on PUP-25
Re: Resource defaults aren't completely evaluated by the compiler
validated on el7 at puppet-agent master sha: e749206bc4be4c81b604c305ce7550bf36f54524
[root@ggwhe623t52b1vp ~]# puppet apply apply.pp
Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Notify[a] is already declared in file /root/apply.pp:2; cannot redeclare at /root/apply.pp:2 at /root/apply.pp:2:3 at /root/apply.pp:7 on node ggwhe623t52b1vp.delivery.puppetlabs.net
[root@ggwhe623t52b1vp ~]# cat apply.pp
define x($v) {
notify { $v: }
}
X { tag => 't1' }
@x {
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title John Duarte updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: John Duarte QA Risk Assessment: Manual Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Josh Cooper assigned an issue to qa Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Josh Cooper Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title
Thomas Hallgren commented on PUP-25
Re: Resource defaults aren't completely evaluated by the compiler
Josh Cooper, you asked for a sample manifest that would break under the new behavior. Here is one:
define x($v) {
notify { $v: }
}
X { tag => 't1' }
@x {
x1: v => 'a';
x2: v => 'a', tag => 't2';
}
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Sprint: PDE 2017-05-03 , PDE 2017-05-31 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-25
Resource defaults aren't completely evaluated by the compiler
Change By:
Henrik Lindberg
Release Notes Summary:
Puppet has since the beginning evaluated collections before applying default values defined via resource type defaults, thereby making it impossible to use such values when performing collection. This is now changed and an example like below now works as expected:{code}File { tag => 'sc_test' }File { '/tmp/test': ensure => present }File <<| tag == 'sc_test' |>>{code} This change will affect existing logic where it was assumed that default values were set via resource type defaults were *not* present at the time of collection.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-25
Resource defaults aren't completely evaluated by the compiler
Change By:
Henrik Lindberg
Release Notes Summary:
Puppet has since the beginning evaluated collections before applying default values defined via resource type defaults, thereby making it impossible to use such values when performing collection. This is now changed and an example like below now works as expected:{code}File { tag => 'sc_test' }File { '/tmp/test': ensure => present }File <<| tag == 'sc_test' |>>{code}
Release Notes:
Bug Fix
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Eric Sorenson commented on PUP-25 Re: Resource defaults aren't completely evaluated by the compiler Looks like it's in Ready for Merge, so let's get it in. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Sprint: PDE 2017-05-03 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg commented on PUP-25 Re: Resource defaults aren't completely evaluated by the compiler Thomas Hallgren There is a reproducer in the linked RedMine ticket. Eric Sorenson Do you want this for Puppet 5.0.0? Strong suspicion that the fix for this could be seen as backwards incompatible as behavior will be altered - so, will slip to 6.0.0 if not for 5.0.0. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Thomas Hallgren commented on PUP-25 Re: Resource defaults aren't completely evaluated by the compiler A reproducer for the problem described in this ticket would be very helpful. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Component/s: Server Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Assignee: Eric Sorenson Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Story Points: 8 4 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg commented on PUP-25 Re: Resource defaults aren't completely evaluated by the compiler What was said still applies, but replace 3.x with 4.x and 4.0.0 with 5.0.0. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Change By: Henrik Lindberg Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg commented on an issue Re: Resource defaults aren't completely evaluated by the compiler We have recently discussed this and have come to the conclusion that we would like to apply default values eagerly instead of towards the end of the compilation. This would cure several reported issues and confusion. We took this issue to the dev mailing list for discussion with the hope of people reporting corner cases, and commenting in general. We think we can do this in a way that it behaves differently when using the future parser until 4.0 is released. We believe that the lazy evaluation of defaults is due to the old dynamic scoping making it required, but do not know for sure. Add Comment Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Resource defaults are merged in when [finish is called on resources|https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/compiler.rb#L358] by the compiler [which leads to|https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/resource.rb#L107] the [add_defaults method|https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parse... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title Henrik Lindberg commented on an issue Re: Resource defaults aren't completely evaluated by the compiler In 4.0 this will continue to work as it does in 3x. New catalog builder not until Puppet 5.0. Add Comment Puppet / PUP-25 Resource defaults aren't completely evaluated by the compiler Resource defaults are merged in when [finish is called on resources|https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/compiler.rb#L358] by the compiler [which leads to|https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/resource.rb#L107] the [add_defaults method|https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parse... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-25) Resource defaults aren't completely evaluated by the compiler
Title: Message Title
Charlie Sharpsteen updated an issue
Puppet / PUP-25
Resource defaults aren't completely evaluated by the compiler
Change By:
Charlie Sharpsteen
Resourcedefaultsaremergedinwhen[finishiscalledonresources ]( | https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/compiler.rb#L358 ) ] bythecompiler[whichleadsto ]( | https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/resource.rb#L107 ) ] the[add_defaultsmethod ]( | https://github.com/puppetlabs/puppet/blob/3.2.0/lib/puppet/parser/resource.rb#L236-L244 ) ] inparser/resource.rb:{code}defadd_defaultsscope.lookupdefaults(self.type).eachdo|name,param|unless@parameters.include?(name)self.debugAddingdefaultfor#{name}@parameters[name]=param.dupendendend{code}Thismethodloopsovereachdefaultandaddsvaluestothe@parametershashiftheyareunset.Nomore,noless.Theproblemisthatsimplyalteringthe@parametershashisn'tsufficienttotriggerthefulleffectofaresourceparameter---thevaluemustbepresentinthehashwhentheresourceisevaluatedbythecompiler.
Add Comment
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
