Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Ethan Brown commented on PUP-2788
Re: Puppet package source check fails with DFS share
I believe that this was fixed as part of
PUP-6025
in https://github.com/puppetlabs/puppet/commit/7a5e7d99a8969b072f3c0b7fc8b38217df4fae1e for Puppet 4.4.2 (released around 4/26/2016).
With the help of Glenn Sarti we got a DFS share setup internally, and I used the following manifest:
package { 'Java':
ensure => installed,
source => '//dfsn/Ethan/Target1/jre-8u121-windows-x64.exe',
install_options => ['/s'],
}
I ran Puppet 4.9.2 against the manifest, important output being:
[0;36mDebug: Package source parameter contained /s - replaced with \s [0m
[0;36mDebug: Executing: 'cmd.exe /c start "puppet-install" /w \\dfsn\Ethan\Target1\jre-8u121-windows-x64.exe /s' [0m
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Moses Mendoza Labels: manage-package windows Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Kenaz Kwa updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Kenaz Kwa Team: Agent & Platform Support Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Craig Gomes updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Craig Gomes Labels: windows wintern Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Glenn Sarti Labels: windows wintern Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Ethan Brown commented on PUP-2788 Re: Puppet package source check fails with DFS share Ping Kurt Gardiner for any additional feedback on this issue. We're scoping releases, and would consider including a fix here if we can get some more details. Thanks! Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Ethan Brown updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Ethan Brown Fix Version/s: PUP 4.x Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Kurt Gardiner commented on PUP-2788 Re: Puppet package source check fails with DFS share Sorry, been a while getting back to this. I'll have to pencil some time in over the next few days & get back to you. Thanks for the help! Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Ethan Brown commented on PUP-2788 Re: Puppet package source check fails with DFS share Kurt Gardiner we'd like to help you out and we'd like to fix this - still hoping you can provide the contents of REPARSE_DATA_BUFFER Thanks! Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Eric Sorenson commented on PUP-2788 Re: Puppet package source check fails with DFS share Kurt Gardiner could you please provide the info ethan requested? put the ticket back into "Ready for Engineering" when you've gotten it. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Eric Sorenson updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Eric Sorenson Assignee: Kylo Ginsberg Kurt Gardiner Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Eric Sorenson updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Eric Sorenson Fix Version/s: PUP 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Ethan Brown updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Ethan Brown Fix Version/s: PUP 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Ethan Brown commented on an issue
Re: Puppet package source check fails with DFS share
Ping Kurt Gardiner - any luck debugging to inspect the contents of REPARSE_DATA_BUFFER?
Add Comment
Puppet / PUP-2788
Puppet package source check fails with DFS share
{noformat} package { 'NetFx452': ensure => installed, source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe', install_options => ['/q'], } {noformat} fails with error {noformat} Error: The source does not exist: '//dfs_share/software/dotNetFx452_Full_x86_x64.exe' {noformat} Digging through th...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Kurt Gardiner commented on an issue Re: Puppet package source check fails with DFS share Not entirely sure what we're expecting to see with Junction, couldn't see the source code link through the corporate firewall, here's the output from what I ran for what it's worth: PS C:\Program Files (x86)\Junction> ./junction '\\dfs_share\public' Junction v1.06 - Windows junction creator and reparse point viewer Copyright (C) 2000-2010 Mark Russinovich Sysinternals - www.sysinternals.com No matching files were found. PS C:\Program Files (x86)\Junction> ./junction '\\dfs_share\public\software'
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Ethan Brown commented on an issue
Re: Puppet package source check fails with DFS share
Great work Kurt Gardiner
So from what I understand, DFS paths are represented as links in the file system, but don't have anything to resolve to when sending FSCTL_GET_REPARSE_POINT to DeviceIoControl.
It would also be helpful to run the SysInternals Junction tool against that DFS path just to see that properly reports that it is DFS, etc. You can download it from here: http://technet.microsoft.com/en-us/sysinternals/bb896768.aspx You can see in line 216 where DFS is ferreted out: http://read.pudn.com/downloads37/sourcecode/windows/123015/junction.c__.htm
While debugging, you should see IO_REPARSE_TAG_DFS with a value of 0x800A appear in the ReparseTag field of the REPARSE_DATA_BUFFER (MSDN docs are unclear about whether or not this is always the case based on Windows version?) As Josh suggested, it would be great to get a dump of that struct during a debugging session. https://github.com/puppetlabs/puppet/blob/14645e300e3d86763e8908896eba5a6097e8a1a5/lib/puppet/util/windows/file.rb#L389 http://msdn.microsoft.com/en-us/library/dd541667.aspx
In any event, this is interesting, and thanks for discovering this issue.
For Josh Cooper and Rob Reynolds, I also see that we can use FSCTL_LMR_GET_LINK_TRACKING_INFORMATION to determine up front if the path is DFS or not. Would have to evaluate if that's a quicker short circuit or not (I suspect not): http://msdn.microsoft.com/en-us/library/windows/hardware/ff545447(v=vs.85).aspx
Add Comment
Puppet / PUP-2788
Puppet package source check fails with DFS share
{noformat} package { 'NetFx452': ensure => installed, source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe', install_options => ['/q'], } {no
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Josh Cooper commented on an issue
Re: Puppet package source check fails with DFS share
Kurt Gardiner Thanks for your detailed report. The msi packages work, because puppet just calls msiexec passing along the source parameter, and windows is able to resolve the DFS share. The exe case works in 3.2.3, but fails in 3.6.1, because our file system abstraction layer behaves differently as you pointed out:
irb(main):004:0> Puppet::FileSystem::exist?('//dfs_share/software/jdk6/jdk-6u45-windows-x64.exe')
=> false
irb(main):005:0> File.exist?('//dfs_share/software/jdk6/jdk-6u45-windows-x64.exe')
=> true
And we changed the windows package provider to call it in the commit you specified.
It does appear that ruby's File.exists? follows symlinks on non-windows platforms, but on Windows it just gets attributes of the link, not the target:
if (GetFileAttributesExW(path, GetFileExInfoStandard, (void*)&wfa)) {
Kurt Gardiner could you dig into the Puppet::Util::Windows::File.readlink method. When it calls resolve_symlink, can you dump the resulting REPARSE_DATA_BUFFER structure? Since it's binary data, you'll need to encode it or dump to a file.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Kurt Gardiner commented on an issue Re: Puppet package source check fails with DFS share Thanks for following up, further details: I am testing by running administrator powershell prompt logged in as my user, I can access and execute the files in question. Puppet Version .msi .exe 3.2.3 Works Works 3.6.1 Works Does Not work Add Comment Puppet / PUP-2788
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Luis Fernandez commented on an issue
Re: Puppet package source check fails with DFS share
Also, just for checking... does it work if you call MSI installers instead of .exe?
Add Comment
Puppet / PUP-2788
Puppet package source check fails with DFS share
{noformat} package { 'NetFx452': ensure => installed, source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe', install_options => ['/q'], } {noformat} fails with error {noformat} Error: The source does not exist: '//dfs_share/software/dotNetFx452_Full_x86_x64.exe' {noformat} Digging through th...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Luis Fernandez commented on an issue
Re: Puppet package source check fails with DFS share
Kurt Gardiner, if you're running a standard installation of puppet (and the agent is running as SYSTEM), has the computer account in your AD been granted with permissions in your DFS folder?
I'm using this mechanism on 3.4.3 and it works fine for me (host joined to domain + DFS share).
Add Comment
Puppet / PUP-2788
Puppet package source check fails with DFS share
{noformat} package { 'NetFx452': ensure => installed, source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe', install_options => ['/q'], } {noformat} fails with error {noformat} Error: The source does not exist: '//dfs_share/software/dotNetFx452_Full_x86_x64.exe' {noformat} Digging through th...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Rob Reynolds Component/s: PE Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Kurt Gardiner commented on an issue
Re: Puppet package source check fails with DFS share
Rob Reynolds We started with backslashes, same deal:
PS C:\Windows\system32> puppet resource package 'krut' ensure=installed source='\\dfs_share\software\jdk6\jdk-6u45-windows-x64.exe'
Error: The source does not exist: '\\dfs_share\software\jdk6\jdk-6u45-windows-x64.exe'
Error: /Package[krut]/ensure: change from absent to present failed: The source does not exist: '\\dfs_share\software\jdk6\jdk-6u45-windows-x64.exe'
package { 'krut':
ensure => 'absent',
}
PS C:\Windows\system32> puppet resource package 'krut' ensure=installed source='dfs_share\\software\\jdk6\\jdk-6u45-windows-x64.exe'
Error: The source does not exist: 'dfs_share\\software\\jdk6\\jdk-6u45-windows-x64.exe'
Error: /Package[krut]/ensure: change from absent to present failed: The source does not exist: 'dfs_share\\software\\jdk6\\jdk-6u45-windows-x64.exe'
package { 'krut':
ensure => 'absent',
Add Comment
Puppet / PUP-2788
Puppet package source check fails with DFS share
{noformat} package { 'NetFx452': ensure => installed, source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe', install_options => ['/q'], } {noformat} fails with error {noformat} Error: The source does not exist: '//dfs_share/software/dotNetFx452_Full_x86_x64.exe' {noformat} Digging through th...
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Rob Reynolds commented on an issue
Re: Puppet package source check fails with DFS share
Kurt Gardiner can you try backslashes in your source instead? I think this leans to a documentation issue.
package { 'NetFx452':
ensure => installed,
source => '\\dfs_share\software\dotNetFx452_Full_x86_x64.exe',
install_options => ['/q'],
}
Add Comment
Puppet / PUP-2788
Puppet package source check fails with DFS share
{noformat} package { 'NetFx452': ensure => installed, source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe', install_options => ['/q'], } {noformat} fails with error {noformat} Error: The source does not exist: '//dfs_share/software/dotNetFx452_Full_x86_x64.exe' {noformat} Digging through th...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Rob Reynolds Component/s: Client Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-2788 Puppet package source check fails with DFS share Change By: Rob Reynolds Labels: windows Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2788) Puppet package source check fails with DFS share
Title: Message Title
Kurt Gardiner created an issue
Puppet / PUP-2788
Puppet package source check fails with DFS share
Issue Type:
Bug
Affects Versions:
3.6.2
Assignee:
Kylo Ginsberg
Components:
Types and Providers
Created:
16/Jun/14 8:57 PM
Environment:
All open source edition
Client: Windows Server 2012 R2 Puppet 3.6.2 ruby 1.9.3p484 (2013-11-22) [i386-mingw32]
Master: CentOS Puppet 3.6.2
Priority:
Normal
Reporter:
Kurt Gardiner
package { 'NetFx452':
ensure => installed,
source => '//dfs_share/software/dotNetFx452_Full_x86_x64.exe',
install_options => ['/q'],
}
fails with error
Error: The source does not exist: '//dfs_share/software/dot
