Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Rahul Gopinath created an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Issue Type: Improvement Affects Versions: 4.x Assignee: Unassigned Created: 08/Jul/14 1:09 PM Environment: All Labels: github Priority: Normal Reporter: Rahul Gopinath Enable Rubocop static verification and linting in puppet Add Comment
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Andy Parker updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Andy Parker Affects Version/s: 4.x Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Andy Parker commented on an issue Re: Incorporate linting and static verification with rubocop Rahul Gopinath, do you have any ideas about what rules it should enforce or when it should enforce those rules? Add Comment Puppet / PUP-2909 Incorporate linting and static verification with rubocop Enable Rubocop static verification and linting in puppet This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Andy Parker assigned an issue to Rahul Gopinath Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Andy Parker Assignee: Rahul Gopinath Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Rahul Gopinath commented on an issue Re: Incorporate linting and static verification with rubocop Andy Parker See my [pull request](https://github.com/puppetlabs/puppet/pull/2855). I have enabled four checkers which found some real problems in the code base. We also have a small number of good-to-have checkers which are not yet enabled due to the high number of violations found. I do not think that we should adopt all of the rules provided by rubocop. I think that the right place to run it would be before commit. Add Comment Puppet / PUP-2909 Incorporate linting and static verification with rubocop Enable Rubocop static verification and linting in puppet This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Andy Parker commented on an issue Re: Incorporate linting and static verification with rubocop Rahul Gopinath, I saw the PR, which was excellent work. I'm looking for more of an overview here of the approach that is being taken to adding this in. What problems does it solve, how should we maintain it, what is the process around dealing with non-compliant code, how should we go about adding new rules. I don't want to shut this down, but I also want to make sure that it doesn't end up being a great idea that ends up sitting off in a corner because nobody is paying attention to it. It needs to be incorporated into the team's process somehow. Add Comment Puppet / PUP-2909 Incorporate linting and static verification with rubocop Enable Rubocop static verification and linting in puppet This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Kylo Ginsberg Sprint: Week 2014-7-9 to 2014-7-23 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Kylo Ginsberg Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Rahul Gopinath updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Rahul Gopinath Affects Version/s: 4.x Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Kylo Ginsberg commented on an issue Re: Incorporate linting and static verification with rubocop Totally agree on including this in the team's process, or it would certainly wither. A followon task here should be adding travis and/or jenkins jobs to enforce the state of .rubocop.yml. My proposal would be that non-compliant code is treated as a build failure and thus isn't merged. As to how we add new rules, my proposal would be that rules changes are introduced via PR (including changes to the rubocop configuration and complementary fixes to the code), and thus are reviewed by the team or a subset of the team. To that end, it'd be great to get review of this initial proposal for rules from some of the people who've played with rubocop in the past, e.g. Adrien Thebo, Charlie Sharpsteen, Andy Parker. Add Comment Puppet / PUP-2909 Incorporate linting and static verification with rubocop Enable Rubocop static verification and linting in puppet This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subsc
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Applying the Client tag for tracking purposes. Don't let that confuse anyone though - this support is puppet-wide. Change By: Kylo Ginsberg Component/s: Client Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Kylo Ginsberg commented on an issue Re: Incorporate linting and static verification with rubocop Moved this to Ready for CI. But to be clear this is only needs to pass regular, existing CI. PUP-2949 is the follow-on ticket to add a CI Jenkins job. Add Comment Puppet / PUP-2909 Incorporate linting and static verification with rubocop Enable Rubocop static verification and linting in puppet This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Rahul Gopinath updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Rahul Gopinath Enable [ Rubocop ](https://github.com/bbatsov/rubocop) is a static verification and linting tool for ruby. It tries to look for violations of [ruby-style-guide](https://github.com/bbatsov/ruby-style-guide), which is useful to avoid common programming errors that can be caught before runtime. The particular restrictions enabled are called `Cops` in Rubocop parlance.We have a [thread in puppet -dev mailing list](https://groups.google.com/forum/#!topic/puppet-dev/Yy6i2AGw66o) which will be used to evolve consensus regarding the particular cops to be enabled for puppet codebase. As of now, we have consensus on enabling these cops immediately```Lint/UnreachableCodeLint/ConditionPositionLint/UselessComparisonLint/LiteralInterpolationLint/ElseLayout```and `Style/AndOr` to be taken up later.Our plan involves incorporating rubocop as a puppet rake task `rake rubocop`, and invoke it as a job from travisCI during pull requests, and also run the task using Jenkins. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Josh Cooper updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Josh Cooper Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Josh Cooper updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Josh Cooper Scrum Team: Client Platform Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2909) Incorporate linting and static verification with rubocop
Title: Message Title Sean Griffin updated an issue Puppet / PUP-2909 Incorporate linting and static verification with rubocop Change By: Sean Griffin QA Risk Assessment: Low QA Status: Reviewed QA Contact: Erik Dasher Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
