Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Austin Boyd (Jira)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Austin Boyd updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-3116  
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.   
 

  
 
 
 
 

 
Change By: 
 Austin Boyd  
 
 
Zendesk Ticket Count: 
 1  
 
 
Zendesk Ticket IDs: 
 47725  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.48712.1408567085000.5882.1648860960054%40Atlassian.JIRA.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Austin Boyd (Jira)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Austin Boyd updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-3116  
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.   
 

  
 
 
 
 

 
Change By: 
 Austin Boyd  
 
 
Labels: 
 file  jira_escalated  linux optimization platform-os selinux type_and_provider  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.48712.1408567085000.5883.1648860960153%40Atlassian.JIRA.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Josh Cooper (Jira)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-3116  
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11132  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.48712.1408567085000.5881.1648859880170%40Atlassian.JIRA.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Geoff Nichols (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Geoff Nichols assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-3116  
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.   
 

  
 
 
 
 

 
Change By: 
 Geoff Nichols  
 
 
Assignee: 
 Eric Sorenson  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Branan Riley (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley assigned an issue to Eric Sorenson  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-3116  
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.   
 

  
 
 
 
 

 
Change By: 
 Branan Riley  
 
 
Assignee: 
 Trevor Vaughan Eric Sorenson  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Branan Riley (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-3116  
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.   
 

  
 
 
 
 

 
Change By: 
 Branan Riley  
 
 
Labels: 
 file linux optimization selinux  triaged type_and_provider  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Moses Mendoza (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Moses Mendoza updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3116 
 
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Moses Mendoza 
 
 
 

Labels:
 
 optimization selinux  triaged 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Rob Browning (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Browning updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3116 
 
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Rob Browning 
 
 
 

Team:
 
 Agent 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Rob Browning (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Browning updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3116 
 
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Rob Browning 
 
 
 

Labels:
 
 optimization selinux  triaged 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Henrik Lindberg (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3116 
 
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Scrum Team:
 
 Client Platform 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Re: Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Trevor Vaughan]

Ok, that's fine. I need to think of the best way to do this.

On Tue, Nov 11, 2014 at 6:31 PM, Josh Cooper (JIRA) <
issue-upda...@puppetlabs.com> wrote:

>   Josh Cooper
> 
> *updated* an issue   Puppet
>  / [image: Bug]
>  PUP-3116
>    The read_mounts
> function reads /proc/mounts for every file call and should instead cache.
>   Change By:  Josh
> Cooper 
> Assignee:  Trevor Vaughan[image: Add Comment]
>   Add Comment
> 
> This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)   [image:
> Atlassian logo]
>
> --
> You received this message because you are subscribed to the Google Groups
> "Puppet Bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to puppet-bugs+unsubscr...@googlegroups.com.
> To post to this group, send email to puppet-bugs@googlegroups.com.
> Visit this group at http://groups.google.com/group/puppet-bugs.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaug...@onyxpoint.com

-- This account not approved for unencrypted proprietary information --

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Josh Cooper (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-3116 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: The read_mounts function reads /proc/mounts for every file call and should instead cache.  
 
 
 
 
 
 
 
 
 
 
Trevor Vaughan reassigning this ticket to you based on the last PR comment https://github.com/puppetlabs/puppet/pull/3043#issuecomment-59127354 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Josh Cooper (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3116 
 
 
 
  The read_mounts function reads /proc/mounts for every file call and should instead cache.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Assignee:
 
 Trevor Vaughan 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Henrik Lindberg (JIRA)]

Title: Message Title










 

 Henrik Lindberg commented on an issue











 






  Re: The read_mounts function reads /proc/mounts for every file call and should instead cache. 










The use of global variables, and the fact that the fix does not address the masterless case of "puppet apply" made me move this to "needs information". I think it would be best to use a file as a cache instead of keeping it in memory since that would make the caching work for apply and remove the need of using global variables. (Yes, it means reading the file several times, but this is a vetted file that should be fast to read).












   

 Add Comment











 













 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 







 During a puppet run, the read_mounts function in util/selinux is called for each file that it managed on the system.   As currently implemented, the system will read /proc/mounts for each file.   While initially being unwanted due to unnecessary file IO, certain systems that use namespacing, such as OpenShift, create potentially thousands of redundant m...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are sub

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Kylo Ginsberg (JIRA)]

Title: Message Title










 

 Kylo Ginsberg updated an issue











 






 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 










Change By:

 Kylo Ginsberg




Component/s:

 Community












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Trevor Vaughan (JIRA)]

Title: Message Title










 

 Trevor Vaughan commented on an issue











 






  Re: The read_mounts function reads /proc/mounts for every file call and should instead cache. 










PR Added at https://github.com/puppetlabs/puppet/pull/3043












   

 Add Comment











 













 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 







 During a puppet run, the read_mounts function in util/selinux is called for each file that it managed on the system.   As currently implemented, the system will read /proc/mounts for each file.   While initially being unwanted due to unnecessary file IO, certain systems that use namespacing, such as OpenShift, create potentially thousands of redundant m...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Trevor Vaughan (JIRA)]

Title: Message Title










 

 Trevor Vaughan commented on an issue











 






  Re: The read_mounts function reads /proc/mounts for every file call and should instead cache. 










Added a pull request but forgot to tag. In theory, it'll show up soon-ish.












   

 Add Comment











 













 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 







 During a puppet run, the read_mounts function in util/selinux is called for each file that it managed on the system.   As currently implemented, the system will read /proc/mounts for each file.   While initially being unwanted due to unnecessary file IO, certain systems that use namespacing, such as OpenShift, create potentially thousands of redundant m...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/o

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Kylo Ginsberg (JIRA)]

Title: Message Title










 

 Kylo Ginsberg commented on an issue











 






  Re: The read_mounts function reads /proc/mounts for every file call and should instead cache. 










Trevor Vaughan can you turn that patch into a PR? We can discuss at weekly PR triage. Thanks!












   

 Add Comment











 













 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 







 During a puppet run, the read_mounts function in util/selinux is called for each file that it managed on the system.   As currently implemented, the system will read /proc/mounts for each file.   While initially being unwanted due to unnecessary file IO, certain systems that use namespacing, such as OpenShift, create potentially thousands of redundant m...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://gro

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Trevor Vaughan (JIRA)]

Title: Message Title










 

 Trevor Vaughan commented on an issue











 






  Re: The read_mounts function reads /proc/mounts for every file call and should instead cache. 










Any love here? I'm hoping to not roll a custom version of Puppet if possible.












   

 Add Comment











 













 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 







 During a puppet run, the read_mounts function in util/selinux is called for each file that it managed on the system.   As currently implemented, the system will read /proc/mounts for each file.   While initially being unwanted due to unnecessary file IO, certain systems that use namespacing, such as OpenShift, create potentially thousands of redundant m...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/

Jira (PUP-3116) The read_mounts function reads /proc/mounts for every file call and should instead cache.

[Trevor Vaughan (JIRA)]

Title: Message Title










 

 Trevor Vaughan created an issue











 






 Puppet /  PUP-3116



  The read_mounts function reads /proc/mounts for every file call and should instead cache. 










Issue Type:

  Bug




Affects Versions:


 3.6.2, 2.7.25




Assignee:

 Kylo Ginsberg




Attachments:


 selinux_mount.patch




Components:


 Catalog Application




Created:


 20/Aug/14 1:38 PM




Environment:


Any system with SELinux enabled




Labels:


 selinux optimization




Priority:

  Major




Reporter:

 Trevor Vaughan










During a puppet run, the read_mounts function in util/selinux is called