Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title Chris Spence commented on PUP-3859 Re: Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes) I can confirm this behaviour on 3.7.4 also: c877wysdas02b:~ # puppet apply /tmp/apply_manifest.pp.PlMT1T Warning: Change notice: purging cron entries will be more aggressive in future versions, take care when updating your agents. See http://links.puppetlabs.com/puppet-aggressive-cron-purge (at /usr/lib/ruby/site_ruby/1.8/puppet/type/resources.rb:140:in `deprecate_params') Notice: Compiled catalog for c877wysdas02b in environment production in 4.77 seconds Warning: The package type's allow_virtual parameter will be changing its default value from false to true in a future release. If you do not want to allow virtual packages, please explicitly set allow_virtual to false. (at /usr/lib/ruby/site_ruby/1.8/puppet/type/package.rb:430:in `default') Error: Could not apply complete catalog: Found 1 dependency cycle: (File[/platform/puppet/hieradata/production] = File[/platform/puppet/hieradata/production]) Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz Notice: Finished catalog run in 0.45 seconds c877wysdas02b:~ # echo $? 0 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title Henrik Lindberg commented on PUP-3859 Re: Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes) This looks like a duplicate of PUP-3042 (albeit it being reported against the agent application). Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-3859 Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes) Change By: Henrik Lindberg Scrum Team: ClientPlatform Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title
Peter Souter commented on PUP-3859
Re: Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
It's all around `puppet/lib/puppet/graph/relationship_graph.rb`, which raises the error:
def report_cycles_in_graph
cycles = find_cycles_in_graph
n = cycles.length # where is pluralize? --daniel 2011-01-22
return if n == 0
s = n == 1 ? '' : 's'
message = Found #{n} dependency cycle#{s}:\n
cycles.each do |cycle|
paths = paths_in_cycle(cycle)
message += paths.map{ |path| '(' + path.join( = ) + ')'}.join(\n) + \n
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title
Peter Souter created an issue
Puppet / PUP-3859
Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Issue Type:
Bug
Affects Versions:
PUP 3.7.3
Assignee:
Unassigned
Created:
2015/01/16 10:20 AM
Priority:
Normal
Reporter:
Peter Souter
I noticed when running a beaker test that a puppet apply wasn't being caught as an error https://github.com/puppetlabs/beaker/issues/629
Example:
Dependancy cycle manifest foo.pp class a { notify { 'foo':}
}
class b { notify { 'bar':}
}
class include_first { contain a contain b } class include_second { contain a contain b }
include include_first include include_second
Class['include_first'] - Class ['include_second'] $ puppet apply foo.pp Notice: Compiled catalog for peters-mbp.corp.puppetlabs.net in environment production in 0.05 seconds Error: Could not apply complete catalog: Found 1 dependency cycle: (Notify[bar] = Class[B] = Class[Include_first] = Class[Include_second] = Class[B] = Notify[bar]) Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz Notice: Finished catalog run in 0.02 seconds ➜ ~
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title
Peter Souter updated an issue
Puppet / PUP-3859
Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Change By:
Peter Souter
Inoticedwhenrunningabeakertestthatapuppetapplywasn'tbeingcaughtasanerrorhttps://github.com/puppetlabs/beaker/issues/629Example: #Dependancycyclemanifest {code:title= foo.pp |borderStyle=solid} classa{notify{'foo':}}classb{notify{'bar':}}classinclude_first{containacontainb}classinclude_second{containacontainb}includeinclude_firstincludeinclude_secondClass['include_first']-Class['include_second'] {code}{code} $puppetapplyfoo.ppNotice:Compiledcatalogforpeters-mbp.corp.puppetlabs.netinenvironmentproductionin0.05secondsError:Couldnotapplycompletecatalog:Found1dependencycycle:(Notify[bar]=Class[B]=Class[Include_first]=Class[Include_second]=Class[B]=Notify[bar])Trythe'--graph'optionandopeningtheresulting'.dot'fileinOmniGraffleorGraphVizNotice:Finishedcatalogrunin0.02seconds➜~echo$!0puppetapplyfoo.pp--detailed-exitcodeNotice:Compiledcatalogforpeters-mbp.corp.puppetlabs.netinenvironmentproductionin0.05secondsError:Couldnotapplycompletecatalog:Found1dependencycycle:(Notify[bar]=Class[B]=Class[Include_first]=Class[Include_second]=Class[B]=Notify[bar])Trythe'--graph'optionandopeningtheresulting'.dot'fileinOmniGraffleorGraphVizNotice:Finishedcatalogrunin0.01seconds➜~echo$!0 {code}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title
Peter Souter updated an issue
Puppet / PUP-3859
Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Change By:
Peter Souter
Inoticedwhenrunningabeakertestthatapuppetapplywasn'tbeingcaughtasanerrorhttps://github.com/puppetlabs/beaker/issues/629Example:{code:title=foo.pp|borderStyle=solid}classa{notify{'foo':}}classb{notify{'bar':}}classinclude_first{containacontainb}classinclude_second{containacontainb}includeinclude_firstincludeinclude_secondClass['include_first']-Class['include_second']{code}{code}$puppetapplyfoo.ppNotice:Compiledcatalogforpeters-mbp.corp.puppetlabs.netinenvironmentproductionin0.05secondsError:Couldnotapplycompletecatalog:Found1dependencycycle:(Notify[bar]=Class[B]=Class[Include_first]=Class[Include_second]=Class[B]=Notify[bar])Trythe'--graph'optionandopeningtheresulting'.dot'fileinOmniGraffleorGraphVizNotice:Finishedcatalogrunin0.02seconds➜~echo$!0 $ puppetapplyfoo.pp--detailed-exitcodeNotice:Compiledcatalogforpeters-mbp.corp.puppetlabs.netinenvironmentproductionin0.05secondsError:Couldnotapplycompletecatalog:Found1dependencycycle:(Notify[bar]=Class[B]=Class[Include_first]=Class[Include_second]=Class[B]=Notify[bar])Trythe'--graph'optionandopeningtheresulting'.dot'fileinOmniGraffleorGraphVizNotice:Finishedcatalogrunin0.01seconds➜~echo$!0{code}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-3859) Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes)
Title: Message Title Peter Souter commented on PUP-3859 Re: Puppet Apply dependancy cycle error exits 0 (even on detailed exit codes) So this is causing issues with detecting failures in beaker, as beaker tests will show as green when applying manifests. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
