Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-03-05 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3861 
 
 
 
  Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Fix Version/s:
 
 PUP 4.0.0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-29 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-3861 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 
 
Merged in e3900ef8 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-28 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3861 
 
 
 
  Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Scrum Team:
 
 Release Engineering 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-27 Thread Christopher Barbour (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Christopher Barbour commented on  PUP-3861 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 
 
You can probably reproduce this issue by giving your CentOS base repository an extremely long name. 
If no one else can test, I can spin up a new OEL VM (which is where I originally encountered the issue.) In my case, I ran into the problem while developing an extremely customized version of the YUM provider based on the code in HEAD. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-27 Thread Charlie Sharpsteen (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Charlie Sharpsteen commented on  PUP-3861 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 
 
I don't have a RPM on hand that contains a package name long enough to trigger the behavior described here, so I can't test the PR. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-27 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-3861 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 
 
Christopher Barbour, Charlie Sharpsteen could you give the PR a try and see if it resolves the issue? I would hate to release puppet 4 with a regression like this in the yum provider. /cc Kylo Ginsberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-27 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-3861 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 
 
I've submitted a PR https://github.com/puppetlabs/puppet/pull/3526 based on https://github.com/adrienthebo/puppet/commit/2d9624e2360073c978ce94a9038d475a69509ddb. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-27 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3861 
 
 
 
  Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Affects Version/s:
 
 PUP M 
 
 
 

Affects Version/s:
 
 PUP 4.0.0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-20 Thread Adrien Thebo (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Adrien Thebo commented on  PUP-3861 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 
 
https://github.com/puppetlabs/puppet/pull/2670#issuecomment-62093402 discussed using repoquery over directly invoking yum, but it was decided against as we would have to add yum-utils as a hard dependency. As it turns out, I actually had fixed this but I didn't push my patch and so it didn't get merged. Good times. 
This is part of the patch that will fix this; I'll add more information later. /cc Charlie Sharpsteen feel free to bug me on this more if I don't respond in a timely manner. 
Anywho, patch: 
 
 
 
 
 
 
diff --cc lib/puppet/provider/package/yum.rb 
 
 
 
 
index 0c0ac2a,4a9f06b..000 
 
 
 
 
--- i/lib/puppet/provider/package/yum.rb 
 
 
 
 
+++ w/lib/puppet/provider/package/yum.rb 
 
 
 
 
@@@ -63,28 -62,26 +63,49 @@@ Puppet::Type.type(:package).provide :yu 
 
 
 
 
# @api private 
 
 
 
 
# @param enablerepo [Array] A list of repositories to enable for this query 
 
 
 
 
# @param disablerepo [Array] A list of repositories to disable for this query 
 
 
 
 

Jira (PUP-3861) Pull request #2670 will break yum provider with long package names

2015-01-17 Thread Christopher Barbour (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Christopher Barbour created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3861 
 
 
 
  Pull request #2670 will break yum provider with long package names  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 PUP M 
 
 
 

Assignee:
 
 Kylo Ginsberg 
 
 
 

Components:
 

 Types and Providers 
 
 
 

Created:
 

 2015/01/17 10:36 PM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Christopher Barbour 
 
 
 
 
 
 
 
 
 
 
Pull request #2670 replaces yumhelper with a direct call to yum check-update. The output is then parsed line by line for package update information. 
https://github.com/puppetlabs/puppet/commit/8b18639427dbeb17c262f9a459f4d1b6c0380b40#diff-d66f8a2f004447ff56ddba30c0b9161d 
Unfortunately, YUM the yum binary performs line wrapping on all output at 80 characters when piped to an external command. Lines may not contain the expected fields if any long package names are present on the system. This can result in a parse error when the provider is invoked. 
While this is not in keeping with the unix philosophy, the YUM authors have no plans to change the behavior. 
https://bugzilla.redhat.com/show_bug.cgi?id=584525 
The workaround is either to invoke YUM using the Python API calls, or to use repoquery instead. Repoquery is part of the yum-utils package, which may or