Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Ethan Brown commented on PUP-3915 Re: Remove win32console for Windows Ruby 2.1.5 Merged to master in https://github.com/puppetlabs/puppet/commit/52a701107c843cc0201d6c59137ba0248c1d8cfc Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-3915 Remove win32console for Windows Ruby 2.1.5 Change By: Ethan Brown Assignee: EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Rob Reynolds commented on PUP-3915 Re: Remove win32console for Windows Ruby 2.1.5 Passed CI at https://jenkins.puppetlabs.com/view/Puppet/view/Master/job/platform_puppet_specs_windows-master/795/ Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Ethan Brown commented on PUP-3915 Re: Remove win32console for Windows Ruby 2.1.5 Acceptance has passed CI with https://jenkins.puppetlabs.com/view/Puppet/view/Master/job/Puppet-Acceptance-Windows-master/447/ Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Ethan Brown commented on PUP-3915 Re: Remove win32console for Windows Ruby 2.1.5 Note that the puppet-win32-ruby branches for 2.1.x-x64 and 2.1.x-x86 never had this gem to begin with, and PRs are not necessary there. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Rob Reynolds commented on PUP-3915 Re: Remove win32console for Windows Ruby 2.1.5 Ethan Brown I forgot to point that out but yes, thanks for adding that to the ticket. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Rob Reynolds commented on PUP-3915 Re: Remove win32console for Windows Ruby 2.1.5 This is ready for merge but blocked by other tickets. Moving it to blocked status until those are resolved. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-3915 Remove win32console for Windows Ruby 2.1.5 Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title
Rob Reynolds updated an issue
Puppet / PUP-3915
Remove win32console for Windows Ruby 2.1.5
Change By:
Rob Reynolds
RemoveallremnantsofWin32ConsolefromPuppet-Win32-Ruby(ifitisstillthereinthe2.1.5branches),removethegemfromthelistforx86from {{ project_data.yaml }}- https://github.com/puppetlabs/puppet/blob/master/ext/project_data.yaml#L37andremovefrom{{lib/puppet/util/colors.rb}}.FromPUP-3837:h3.3rdPartyGemsincludedwithPuppet*{{win32console}}gem[looksupcurrentcodepagefromtheregistry|https://github.com/luislavena/win32console/blob/49ec9177bf08deb32bdfdb9c9c74fa8c5db23ad9/lib/Win32/Console/ANSI.rb#L51-L54].Notonlyisthisvaluenumeric,butsincethereisnoenumerationofkeys/valuesor{{REG_EXPAND_SZ}}expansiontakingplace,thisisnotaproblem.[~josh]mentionedinacomment:{quote}win32consoleiscurrentlyonlyusedinruby1.9,asruby2.0andupcorrectlyhandlesunicodeconsoleoutput.Inthemoveto2.1.5weshouldmakesuretoremoveallremnantsofwin32consoleinthe{{Gemfile}}andin{{lib/puppet/util/colors.rb}}{quote}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title
Rob Reynolds updated an issue
Puppet / PUP-3915
Remove win32console for Windows Ruby 2.1.5
Change By:
Rob Reynolds
RemoveallremnantsofWin32ConsolefromPuppet-Win32-Ruby(ifitisstillthereinthe2.1.5branches),removethegemfromthelistforx86fromproject_data.yamlhttps://github.com/puppetlabs/puppet/blob/master/ext/project_data.yaml#L37andremovefrom{{lib/puppet/util/colors.rb}}. FromPUP-3837 : h3.3rdPartyGemsincludedwithPuppet*{{win32console}}gem[looksupcurrentcodepagefromtheregistry|https://github.com/luislavena/win32console/blob/49ec9177bf08deb32bdfdb9c9c74fa8c5db23ad9/lib/Win32/Console/ANSI.rb#L51-L54].Notonlyisthisvaluenumeric,butsincethereisnoenumerationofkeys/valuesor{{REG_EXPAND_SZ}}expansiontakingplace,thisisnotaproblem.[~josh]mentionedinacomment:{quote}win32consoleiscurrentlyonlyusedinruby1.9,asruby2.0andupcorrectlyhandlesunicodeconsoleoutput.Inthemoveto2.1.5weshouldmakesuretoremoveallremnantsofwin32consoleinthe{{Gemfile}}andin{{lib/puppet/util/colors.rb}}{quote}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-3915 Remove win32console for Windows Ruby 2.1.5 Change By: Rob Reynolds Thereisalotofencodingissuessurrounding FromPUP-38373rdPartyGemsincludedwithPuppetwin32consolegemlooksupcurrentcodepagefrom the useofwin32/ registry. rbfromRubyv2.1andabove.Priorto2.1 Notonlyisthisvaluenumeric , therewassomecraziness, but itdidn'taffectusinanegativeway.Therecommendation sincethere is thatwestopusingthatandinsteadmakethecallstotheregistrydirectlyusingFFI.Quiteabit noenumeration of backgroundisonthePRforPUP-3779-https: keys / /github valuesorREG_EXPAND_SZexpansiontakingplace,thisisnotaproblem . com/puppetlabs/puppet/pull/3459#discussion_r22838455 Theissuessurroundingruby'swin32/registry.rbcouldalsoimpact:*registrymodule*Anycustomfactsthatmakeregistrycalls Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-3915 Remove win32console for Windows Ruby 2.1.5 Change By: Rob Reynolds Sprint: Windows2015- 01 02 - 28 11 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title
Rob Reynolds updated an issue
Puppet / PUP-3915
Remove win32console for Windows Ruby 2.1.5
Change By:
Rob Reynolds
FromPUP-3837 h2 h3 .3rdPartyGemsincludedwithPuppet*{{win32console}}gem[looksupcurrentcodepagefromtheregistry|https://github.com/luislavena/win32console/blob/49ec9177bf08deb32bdfdb9c9c74fa8c5db23ad9/lib/Win32/Console/ANSI.rb#L51-L54].Notonlyisthisvaluenumeric,butsincethereisnoenumerationofkeys/valuesor{{REG_EXPAND_SZ}}expansiontakingplace,thisisnotaproblem.[~josh]mentionedinacomment: {quote} win32consoleiscurrentlyonlyusedinruby1.9,asruby2.0andupcorrectlyhandlesunicodeconsoleoutput.Inthemoveto2.1.5weshouldmakesuretoremoveallremnantsofwin32consoleinthe{{Gemfile}}andin{{lib/puppet/util/colors.rb}} {quote}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3915) Remove win32console for Windows Ruby 2.1.5
Title: Message Title
Rob Reynolds updated an issue
Puppet / PUP-3915
Remove win32console for Windows Ruby 2.1.5
Change By:
Rob Reynolds
FromPUP-3837 h2. 3rdPartyGemsincludedwithPuppet *{{ win32console }} gem [ looksupcurrentcodepagefromtheregistry |https://github . com/luislavena/win32console/blob/49ec9177bf08deb32bdfdb9c9c74fa8c5db23ad9/lib/Win32/Console/ANSI.rb#L51-L54]. Notonlyisthisvaluenumeric,butsincethereisnoenumerationofkeys/valuesor {{ REG_EXPAND_SZ }} expansiontakingplace,thisisnotaproblem. [~josh]mentionedinacomment:win32consoleiscurrentlyonlyusedinruby1.9,asruby2.0andupcorrectlyhandlesunicodeconsoleoutput.Inthemoveto2.1.5weshouldmakesuretoremoveallremnantsofwin32consoleinthe{{Gemfile}}andin{{lib/puppet/util/colors.rb}}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
