subject:"Jira \(PUP\-4486\) Add a JSON data provider"

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 

And you're OK with 'scope' being the default? Keeping it that way will be more backward compatible but having 'lookup' be the default seems more logical.
 
'scope' should be default, yes. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
The lookup part can be qualified in the Puppet way with double colons, but from a hiera perspective the double colons are just part of the key - there is no difference in semantics between x::y::z and say xaayaaz except for the final step of directing a fully qualified key to the corresponding module data provider - e.g. x::a is directed to module a's provider if the global and environment providers did not find a resolution for the full key.  
The operations of applying dot notation expressions comes after the resolution of the name. Don't see why we need two lookup mechanisms? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
 Another detail that we need to sort out is the Hiera qualified lookup using dot-separated names. Do we want two types of qualified names? 
Not sure what you mean by that, can you clarify? The format should be compatible with current hiera data. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
We use double colon to access module data a::b and in Hiera we recently introduced dot notation to navigate in hashes and arrays. We now face the possibility of names like a::b.c.d or a::b.3. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
No need to have two mechanisms. Just wanted to assert that we do intend to use names that have both double colons and dot-notations in them. There are alternatives such as allowing a name to be separated by either dots or double colon (but not both in the same name). Another thing to have in mind is that a JSON or YAML provider doesn't necessarily imply a hiera provider (or does it?).  
I intend to make the concept of interpolation available to all providers b.t.w. Not just by Hiera with JSON and YAML. I see that as implied when weaving this together. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title

Henrik Lindberg commented on PUP-4486

Re: Add a JSON data provider

The providers we are doing now are hiera specific data providers following the current hiera scheme as much as possible. I can imagine supporting a different version of that format some time in the future - to clean up and make the format sane. I think it may be premature to try to implement general json/yaml backends, or to think too much about what a better format should be (except possibly where there are implementation concerns we want to address) - for now just do what is required for backward compatible hiera data.
Not sure about what bringing interpolation to all implementations means in the context of say the function data provider. Does that mean that users can get interpolation by returning interpolation expressions in strings? When using the function provider, there is also the opportunity to use more advanced lookup semantics - e.g. specify deep merge etc, but we have no way of making such calls be lazy. I see such functionality as a stretch goal and not covered by this ticket.
Regarding names - we have keys, they follow puppet naming (no dots), and navigation of a resulting value of a lookup (has dots). You cannot lookup a value for a key with dots in it - it is an illegal puppet name anyway.

Add Comment

This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)

--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
Another detail that we need to sort out is the Hiera qualified lookup using dot-separated names. Do we want two types of qualified names? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
And you're OK with 'scope' being the default? Keeping it that way will be more backward compatible but having 'lookup' be the default seems more logical. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

2015-07-22 Thread Steve Barlow (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Steve Barlow updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-4486 
 
 
 
  Add a JSON data provider  
 
 
 
 
 
 
 
 
 

Change By:
 
 Steve Barlow 
 
 
 

Sprint:
 
 Language2015-08- 05 19 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

2015-07-11 Thread Thomas Hallgren (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
So perhaps we should introduce a synonym the synonym for 'scope' like 'fact' or something that is more to the point? I really don't like 'scope'. It being the default in Hiera is also a real problem. I think one would assume that an interpolation performed in a data provider would do a real lookup by default, not just look at facts. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

2015-07-11 Thread Henrik Lindberg (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
Scope gets you all top scope variables - from facts (regular and trusted), server settings, as well as variables set in top scope. For that reason I think 'scope' is not too bad. I am more concerned about 'hiera' (implies a particular kind of lookup, but it isn't) - there I want the synonym 'lookup'.  
I can imagine that we create a better 'hiera' data format, and better interpolation at some point. For a first release I want things to be as compatible as possible. Maybe the format-version of data files is configurable in the 'hiera.yaml' as a backend parameter?  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-4486 
 
 
 
  Add a JSON data provider  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Assignee:
 
 ThomasHallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title

Thomas Hallgren commented on PUP-4486

Re: Add a JSON data provider

Regarding interpolation.

In order to prevent endless recursion, we need to pass a recursion guard somehow. Hiera does this in a 'context'. What mechanism do we want to use for the data provider implementation? A KISS approach is to extend the DataProvider.lookup with a fourth argument but I recall discussions about traversing stack frames.

Hiera has the concept of interpolation method. Instead of just writing %{foo}, one can use the syntax %{method('foo')} where method is one of scope (the default), hiera, literal, or alias. Their mapping is not self evident.

I will make the following assumptions for now:

We add a recursion guard to the lookup call.

If we have module binding to a 'hiera' data provider that in turn makes use of a JSON data provider (the one discussed here), then I assume that the hiera interpolation method should use that module specific data provider. Same thing would be true for an environment_data_provider bound to 'hiera'. This implies that the data_providers below the hiera data_provider must know their parent. What should happen if the JSON provider is used as a stand-alone?

The scope method will result in a global lookup (like calling the lookup function).

Add Comment

This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)

Jira (PUP-4486) Add a JSON data provider

2015-07-10 Thread Henrik Lindberg (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
'scope' is an access to a variable in puppet's scope - has nothing to do with lookup and data binding (neither in current hiera, nor in what we are now building). It is basically for interpolating facts. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
Using a 'data in modules' lookup implies that the name is qualified, i.e. module_name::key. That won't fly very well if we're trying to simulate legacy hiera behavior. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

2015-07-10 Thread Henrik Lindberg (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
No, you can use lookup without a qualified name; it should work just like all other lookups, first look in global hiera, then in the environment data provider, and then (if the name is qualified) in the module data provider for that name space. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider

2015-07-10 Thread Henrik Lindberg (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4486 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Add a JSON data provider  
 
 
 
 
 
 
 
 
 
 
Interpolation 'hiera' means lookup (data in modules), and 'scope, means looking up a variable in puppets global scope. 
Passing around a guard is ok in first implementation, but does not fully solve the problem since you can end up in a function data provider that calls back in. We cannot pass the guard around everywhere. 
We could keep it in the puppet context instead now that we know that it is always there. Global hiera cannot call any function (nor find anything from data in modules, so it can continue to work the way it does. 
 

henrik
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4486) Add a JSON data provider