Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Josh Cooper Comment: 4.2.1 with ENC:Debug: compiler: 15.775227 s (16 calls)Debug: compiler -> compile: 3.339482 s (1 calls)Debug: compiler -> compile -> production: 3.339482 s (1 calls)Debug: compiler -> compile -> production -> arcturus.delivery.puppetlabs.net: 3.339482 s (1 calls)Debug: compiler -> evaluate_generators: 3.028134 s (1 calls)Debug: compiler -> iterate_on_generators: 3.02789897 s (2 calls)Debug: compiler -> evaluate_definitions: 3.027682 s (2 calls)Debug: compiler -> evaluate_resource: 3.027471 s (1 calls)Debug: compiler -> evaluate_resource -> Class[Common]: 3.027471 s (1 calls)Debug: compiler -> find_node: 0.294042 s (1 calls)Debug: compiler -> init_server_facts: 0.012917 s (1 calls)Debug: compiler -> find_facts: 0.010516 s (1 calls)Debug: compiler -> create_settings_scope: 0.004485 s (1 calls)Debug: compiler -> evaluate_main: 0.001235 s (1 calls)Debug: compiler -> set_node_params: 0.000984 s (1 calls)Debug: compiler -> finish_catalog: 0.000205 s (1 calls)Debug: compiler -> evaluate_node_classes: 0.000163 s (1 calls)Debug: compiler -> evaluate_ast_node: 1.2e-05 s (1 calls)4.2.1 without ENC:Debug: compiler: 6.399003 s (13 calls)Debug: compiler -> compile: 3.335047 s (1 calls)Debug: compiler -> compile -> production: 3.335047 s (1 calls)Debug: compiler -> compile -> production -> arcturus.delivery.puppetlabs.net: 3.335047 s (1 calls)Debug: compiler -> evaluate_ast_node: 3.022928 s (1 calls)Debug: compiler -> find_node: 0.013113 s (1 calls)Debug: compiler -> init_server_facts: 0.011573 s (1 calls)Debug: compiler -> find_facts: 0.009464 s (1 calls)Debug: compiler -> create_settings_scope: 0.004326 s (1 calls)Debug: compiler -> evaluate_main: 0.001022 s (1 calls)Debug: compiler -> set_node_params: 0.000719 s (1 calls)Debug: compiler -> evaluate_generators: 0.00032 s (1 calls)Debug: compiler -> finish_catalog: 0.000246 s (1 calls)Debug: compiler -> iterate_on_generators: 0.000201 s (1 calls)Debug: compiler -> evaluate_node_classes: 2.8e-05 s (1 calls)Debug: compiler -> evaluate_definitions: 1.6e-05 s (1 calls)stable with ENC:Debug: compiler: 15.7821448 s (17 calls)Debug: compiler -> compile: 3.338612 s (1 calls)Debug: compiler -> compile -> production: 3.338612 s (1 calls)Debug: compiler -> compile -> production -> arcturus.delivery.puppetlabs.net: 3.338612 s (1 calls)Debug: compiler -> evaluate_resource: 3.027264 s (2 calls)Debug: compiler -> evaluate_resource -> Class[Common]: 3.026291 s (1 calls)Debug: compiler -> evaluate_resource -> Class[main]: 0.000973 s (1 calls)Debug: compiler -> evaluate_generators: 3.026983 s (1 calls)Debug: compiler -> iterate_on_generators: 3.026738 s (2 calls)Debug: compiler -> evaluate_definitions: 3.026493 s (2 calls)Debug: compiler -> find_node: 0.307516 s (1 calls)Debug: compiler -> init_server_facts: 0.01131 s (1 calls)Debug: compiler -> find_facts: 0.01059 s (1 calls)Debug: compiler -> create_settings_scope: 0.004362 s (1 calls)Debug: compiler -> evaluate_main: 0.00116 s (1 calls)Debug: compiler -> set_node_params: 0.000731 s (1 calls)Debug: compiler -> finish_catalog: 0.00021 s (1 calls)Debug: compiler -> evaluate_node_classes: 0.000165 s (1 calls)Debug: compiler -> evaluate_ast_node: 1.1e-05 s (1
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Josh Cooper commented on PUP-5013 Re: Improve the code for profiling resource evaluation? 4.2.1 with ENC: Debug: compiler: 15.775227 s (16 calls) Debug: compiler -> compile: 3.339482 s (1 calls) Debug: compiler -> compile -> production: 3.339482 s (1 calls) Debug: compiler -> compile -> production -> arcturus.delivery.puppetlabs.net: 3.339482 s (1 calls) Debug: compiler -> evaluate_generators: 3.028134 s (1 calls) Debug: compiler -> iterate_on_generators: 3.02789897 s (2 calls) Debug: compiler -> evaluate_definitions: 3.027682 s (2 calls) Debug: compiler -> evaluate_resource: 3.027471 s (1 calls) Debug: compiler -> evaluate_resource -> Class[Common]: 3.027471 s (1 calls) Debug: compiler -> find_node: 0.294042 s (1 calls) Debug: compiler -> init_server_facts: 0.012917 s (1 calls) Debug: compiler -> find_facts: 0.010516 s (1 calls) Debug: compiler -> create_settings_scope: 0.004485 s (1 calls) Debug: compiler -> evaluate_main: 0.001235 s (1 calls) Debug: compiler -> set_node_params: 0.000984 s (1 calls) Debug: compiler -> finish_catalog: 0.000205 s (1 calls) Debug: compiler -> evaluate_node_classes: 0.000163 s (1 calls) Debug: compiler -> evaluate_ast_node: 1.2e-05 s (1 calls) 4.2.1 without ENC: Debug: compiler: 6.399003 s (13 calls) Debug: compiler -> compile: 3.335047 s (1 calls) Debug: compiler -> compile -> production: 3.335047 s (1 calls) Debug: compiler -> compile -> production -> arcturus.delivery.puppetlabs.net: 3.335047 s (1 calls) Debug: compiler -> evaluate_ast_node: 3.022928 s (1 calls) Debug: compiler -> find_node: 0.013113 s (1 calls) Debug: compiler -> init_server_facts: 0.011573 s (1 calls) Debug: compiler -> find_facts: 0.009464 s (1 calls) Debug: compiler -> create_settings_scope: 0.004326 s (1 calls) Debug: compiler -> evaluate_main: 0.001022 s (1 calls) Debug: compiler -> set_node_params: 0.000719 s (1 calls) Debug: compiler -> evaluate_generators: 0.00032 s (1 calls) Debug: compiler -> finish_catalog: 0.000246 s (1 calls) Debug: compiler -> iterate_on_generators: 0.000201 s (1 calls) Debug: compiler -> evaluate_node_classes: 2.8e-05 s (1 calls) Debug: compiler -> evaluate_definitions: 1.6e-05 s (1 calls) stable with ENC: Debug: compiler: 15.7821448 s (17 calls) Debug: compiler -> compile: 3.338612 s (1 calls) Debug: compiler -> compile -> production: 3.338612 s (1 calls) Debug: compiler -> compile -> production -> arcturus.delivery.puppetlabs.net: 3.338612 s (1 calls) Debug: compiler -> evaluate_resource: 3.027264 s (2 calls) Debug: compiler -> evaluate_resource -> Class[Common]: 3.026291 s (1 calls) Debug: compiler -> evaluate_resource -> Class[main]: 0.000973 s (1 calls) Debug: compiler -> evaluate_generators: 3.026983 s (1 calls) Debug: compiler -> iterate_on_generators: 3.026738 s (2 calls) Debug: compiler -> evaluate_definitions: 3.026493 s (2 calls) Debug: compiler -> find_node: 0.307516 s (1 calls) Debug: compiler -> init_server_facts: 0.01131 s (1 calls) Debug: compiler -> find_facts: 0.01059 s (1 calls) Debug: compiler -> create_settings_scope: 0.004362 s (1 calls) Debug: compiler -> evaluate_main: 0.00116 s (1 calls) Debug: compiler -> set_node_params: 0.000731 s (1 calls) Debug: compiler -> finish_catalog: 0.00021 s (1 calls) Debug: compiler -> evaluate_node_classes: 0.000165 s (1 calls) Debug: compiler -> evaluate_ast_node: 1.1e-05 s (1 calls) stable without ENC: Debug: compiler: 12.440194 s (16 calls) Debug: compiler -> evaluate_resource: 6.03942505 s (3 calls) Debug: compiler -> evaluate_resource -> Node[default]: 3.020519 s (1 calls)
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title
Josh Cooper commented on PUP-5013
Re: Improve the code for profiling resource evaluation?
Sean Griffin and I looked into this, and it does appear we do now track time evaluating resources, however, the time we compute is incorrect and misleading.
So given site.pp with:
class common {
notify { 'test':
message => generate("/Users/josh/work/puppet/exec_sleep.sh"),
}
}
and an enc:
#!/usr/bin/env ruby
#
require 'yaml'
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Scrum Team: Puppet Server Client Platform Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? We don't really have protocol, but it is more of a PUP thing so I'll just haul it into the Client board for test. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Sprint: Client 2015-09-16 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Kylo Ginsberg thanks. Do we have a protocol for this sort of thing? I'd have no problem with bringing it into my team's sprint and running it through to the end of the board, but if it's in "ready for test" and is going to get some QA review at this point, it might make more sense for it to be reviewed by PUP QA rather than SERVER QA? I'm happy to do it whichever way you think is best. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Christopher Price: I don't know the usual ticket flow for Server. This is in Ready for Test but not in a sprint - would someone from QA usually test this? Or ...? Either way, we're planning to release with this (4.2.2 first) on/around 9/9 so please advise on what we need to do next with this ticket. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Also I snipped / tweaked the commit summary for use as Release Notes Summary. Feel free to hack on that further. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Release Notes Summary: When surfacing Puppet metrics in Puppet Server, w/o this change, a huge percentage of the metrics related to resource evaluation are never registered / tracked, because there are multiple code paths that can lead to resource evaluation during compilation, and only one of them has a profiling block around it.E.g. whether or not a resource gets metrics tracked may depend on whether it was introduced via NC vs site.pp, etc.This fix to the profiling code provides much more interesting and complete data to look at. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Fix Version/s: PUP 3.8.3 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? We merge up. No more PRs needed. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Fix Version/s: PUP 4.2.2 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg assigned an issue to qa Puppet / PUP-5013 Improve the code for profiling resource evaluation? Change By: Kylo Ginsberg Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Merged up to stable and master. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Pushed up a cleaner PR. Kylo Ginsberg You'd asked about what version of 3.8.x to target; I don't have a specific release in mind, I just wanted it to be in the 3.x branch in case there is another PE release in the 3.8.x series that I can get this and some other related Puppet Server stuff rolled into. I'll ping you if that happens, if you guys haven't already done a maintenance 3.x release before then. What's your process for merge-ups these days? Should I follow this up with some PRs to merge commits up to stable/master? Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Done, and the PR should be linked to the ticket now via the magical jira github plugin. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? I'm confused. Christopher Price are you talking about changing Puppet::Parser::Resource#evaluate or Puppet::Resource#evaluate? Also, I think we may have more efficient conversation about this if you do file a PR. At least for me, it's hard to reason about this via jira markdown referencing code that's on github, and much easier in a PR. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Henrik Lindberg could you elaborate a bit? Why would that cause a problem if the profiling block was executed on the agent? IIRC the default configuration for the profilers is just to have an empty list of them, and in that case the 'profile' block is effectively a no-op? Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Henrik Lindberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Christopher Price I am saying that I don't know if it could cause problems if done on the agent - hence the ping to @kylo. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Henrik Lindberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? I can imagine that there could be a problem if calling Resource#evaluate on the agent side. In general Puppet::Parser::Resource is only used server side, but Resource is used on both sides. (Yes this is the cause of much grief). Not sure if the agent side ever evaluates resources and for what purpose if so. Kylo Ginsberg ? Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Kylo Ginsberg Henrik Lindberg Josh Cooper does anyone have any additional thoughts on this? I've done a lot of experimenting in my local branches where I'm surfacing the metrics data through an HTTP status endpoint, and I'm definitely convinced that we'll get more valuable data by moving that profiling block into Resource#evaluate. I'd like to file a PR on this but am sort of waiting to make sure no one has any major concerns... Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Kylo Ginsberg commented on PUP-5013 Re: Improve the code for profiling resource evaluation? After a quick glance, that proposal seems to make sense. I poked at git history a little bit to see if there was an obvious reason why it wasn't being done in Puppet::Parser::Resource as you propose, and I didn't see any mention so it may have just been an artifact of the setup it was tested under at the time. Or there may be a really good reason, but not jumping off the page at me Wrt git history, to save someone else a bit of clicking around: here is the commit where the initial benchmarking was added and here is the later commit where it was converted to using the Profiler Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price commented on PUP-5013 Re: Improve the code for profiling resource evaluation? Henrik Lindberg Josh Cooper Kylo Ginsberg I would be interested to hear if any of you guys have any thoughts on this. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5013) Improve the code for profiling resource evaluation?
Title: Message Title Christopher Price created an issue Puppet / PUP-5013 Improve the code for profiling resource evaluation? Issue Type: Improvement Assignee: Unassigned Created: 2015/08/10 4:55 AM Priority: Normal Reporter: Christopher Price When doing some experimental work around improving metrics in Puppet Server, I noticed that one of the more interesting metrics (about how long is spent evaluating each resource type during a catalog compilation) was not always showing up. After some poking through the code, I discovered this: https://github.com/puppetlabs/puppet/blob/2667053d0438d650c909158c79ce85cfaee8019a/lib/puppet/parser/compiler.rb#L385-L388 def evaluate_definitions exceptwrap do Puppet::Util::Profiler.profile(Evaluated definitions, [:compiler, :evaluate_definitions]) do
