Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Rob Reynolds Release Notes Summary: There was a an issue with removing a symlink with that links to a target that no longer exists. It would cause Puppet to error. This fixes that behavior so the symlink is removed without error. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Release notes fields updated! Change By: Rob Reynolds Release Notes Summary: There was a an issue with removing a symlink with a target that no longer exists. It would cause Puppet to error. This fixes that behavior so the symlink is removed without error. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Kylo Ginsberg commented on PUP-5018 Re: Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Rob Reynolds can you update the two release notes fields for this ticket? Thanks! Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds commented on PUP-5018 Re: Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Actually now that I think about it, it may just treat the files regularly when you go to remove the symlinks. It may be that the only way to see the repro is to work with the code directly. I think first try to produce the repro using puppet manifests and see if it is possible or just more of a hidden issue that can only be reached through code. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds commented on PUP-5018 Re: Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Ryan Gard this looks okay. I think that if you don't get a repro, you should probably switch to manual deletion of the original folders (not the symlinks) outside of Puppet, then follow it up with a delete. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Rob Reynolds Attachment: repro.png Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds commented on PUP-5018 Re: Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Merged into stable at https://github.com/puppetlabs/puppet/commit/d70c351b0bde0b36aa528ddf7a4129fa34a96a0c Merged into master at https://github.com/puppetlabs/puppet/commit/7a87738f9aaafcfe5171d71820047df418471e76 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Ryan Gard updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Ryan Gard QA Risk Assessment: Medium QA Status: Reviewed QA Contact: RyanGard Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds commented on PUP-5018 Re: Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Passed stable specs https://jenkins.puppetlabs.com/view/All%20in%20One%20Agent/view/Stable/view/Puppet/job/platform_aio-puppet_stage-unit_stable/397/ Passed master specs https://jenkins.puppetlabs.com/view/All%20in%20One%20Agent/view/Master/view/Puppet/job/platform_aio-puppet_stage-unit_master/175/ But did not pass acceptance due to newly found beaker issue (JIRA ticket yet to be determined). Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Ryan Gard updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Ryan Gard Attachment: console.png Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Rob Reynolds Fix Version/s: PUP4.2.1 Fix Version/s: PUP4.2.2 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Rob Reynolds Fix Version/s: PUP4.2.1 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds created an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Issue Type: Bug Affects Versions: PUP 4.2.0 Assignee: Unassigned Components: Windows Created: 2015/08/10 11:57 AM Labels: windows Priority: Normal Reporter: Rob Reynolds When attempting to delete a symlink on Windows for a target path that no longer exists, Puppet throws a Permission Denied error. Expected: The link should be removed.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Rob Reynolds commented on PUP-5018 Re: Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist The handling for this in DSC was done by falling back to regular move/delete methods - https://github.com/puppetlabs/puppetlabs-dsc/commit/cc91b358cb976e58e3ec8eaabf1a57c54377a756 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title
Rob Reynolds updated an issue
Puppet / PUP-5018
Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Change By:
Rob Reynolds
WhenattemptingtodeleteasymlinkonWindowsforatargetpaththatnolongerexists,PuppetthrowsaPermissionDeniederror.Expected:Thelinkshouldberemoved. Toreproduce,createasymlink,deletethetargetfolderandthentrytounlinkit:{noformat}itshouldunlinkasymlinkiftheexistinglinkpathdoesnotexistdopath=Dir.mktmpdir('test')symlink_path=#{path}\\linklink_target=Dir.mktmpdir('link_test')Puppet::FileSystem.symlink(link_target,symlink_path,{:force=true})system(rmdir/s/q\#{link_target}\)Puppet::FileSystem.unlink(symlink_path)end{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Ethan Brown Assignee: EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title Ethan Brown updated an issue Puppet / PUP-5018 Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist Change By: Ethan Brown Sprint: Windows2015-08-26 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5018) Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Title: Message Title
Rob Reynolds updated an issue
Puppet / PUP-5018
Puppet::FileSystem.unlink fails on Windows when the target path doesn't exist
Change By:
Rob Reynolds
WhenattemptingtodeleteasymlinkonWindowsforatargetpaththatnolongerexists,PuppetthrowsaPermissionDeniederror. ThiswasdiscoveredduringtheworkforMODULES-2175.{noformat}[1]pry(DscSymlink)e.class=Errno::EACCES{noformat}* Expected: * Thelinkshouldberemoved. *Repro:* Toreproduce,createasymlink,deletethetarget folder path andthentrytounlinkit:{noformat}itshouldunlinkasymlinkiftheexistinglinkpathdoesnotexistdopath=Dir.mktmpdir('test')symlink_path=#{path}\\linklink_target=Dir.mktmpdir('link_test')Puppet::FileSystem.symlink(link_target,symlink_path,{:force=true})system(rmdir/s/q\#{link_target}\)Puppet::FileSystem.unlink(symlink_path)end{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
