Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-27 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Fix Version/s:
 
 PUP 4.2.3 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-27 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5398 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 
 
Josh Cooper As far as I understand it, the problem cannot occur on 4.x as file watching was removed when legacy environments were removed. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-27 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Fix Version/s:
 
 PUP 4.2.3 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-27 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-5398 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 
 
Henrik Lindberg in preparing for the puppet-agent 4.2.3 release, I noticed this commit was merged up to stable, but the code is very different and looks like it was only an issue in 3.x. Can you confirm that this issue does not affect 4.x, hence we don't need a fixVersion 4.2.3? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-22 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson assigned an issue to Eric Thompson 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

Assignee:
 
 qa Eric Thompson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-22 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

QA Risk Assessment Reason:
 
 unlimited environment_timeout ineffective 
 
 
 

QA Highest Test Level:
 
 Acceptance 
 
 
 

QA Risk Probability Reason:
 
 perhaps low in 3.x but higher in 4.x  
 
 
 

QA Risk Assessment:
 
 Medium 
 
 
 

QA Risk Probability:
 
 Medium 
 
 
 

QA Risk Severity:
 
 Medium 
 
 
 

QA Highest Test Level Reason:
 
 regressions and multiple code-paths 
 
 
 

QA Status:
 
 Reviewed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
  

Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-22 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson commented on  PUP-5398 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 
 
validated in 3.x at SHA: b628b07 on rhel7 with: 
 
 
 
 
 
 
[root@e1oyf1ywgsa1fjh manifests]# puppet agent -t 
 
 
 
 
Info: Retrieving pluginfacts 
 
 
 
 
Info: Retrieving plugin 
 
 
 
 
Info: Caching catalog for e1oyf1ywgsa1fjh.delivery.puppetlabs.net 
 
 
 
 
Info: Applying configuration version '1445556697' 
 
 
 
 
Notice: production 
 
 
 
 
Notice: /Stage[main]/Main/Notify[production]/message: defined 'message' as 'production' 
 
 
 
 
Notice: Finished catalog run in 0.02 seconds 
 
 
 
 
[root@e1oyf1ywgsa1fjh manifests]# cat /etc/puppet/environments/production/manifests/site.pp 
 
 
 
 
  notify{'production':} 
 
 

Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-21 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5398 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 
 
Merged to 3.x at: bfb1f5c 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-21 Thread Steve Barlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Steve Barlow assigned an issue to qa 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Steve Barlow 
 
 
 

Status:
 
 Ready for  CI  Test 
 
 
 

Assignee:
 
 qa 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-21 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Release Notes Summary:
 
 A regression introduced in 3.7.5 would cause a directory based environment to reload if a file was changed, or cause a premature cache timeout if the filetimeout setting had a shorter time than the environment cache.The regression could also cause performance degradation in general due to many calls to get status of files. 
 
 
 

Release Notes:
 
 Bug Fix 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching fr directory environments

2015-10-20 Thread Owen Rodabaugh (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Owen Rodabaugh commented on  PUP-5398 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Fix regression that reintroduced file watching fr directory environments  
 
 
 
 
 
 
 
 
 
 
Michael Stahnke Kenn Hussey Eric Sorenson This is a bug we're pretty concerned about, especially given the comment today about 3.8.3 being the last .z for the 3.8 series. I'm working with CS management to make sure we're all aligned before we escalate this further. 
There are 4-5 customers right now with perf issues that we believe are effected by this, and we have many others we expected will be upgrading the 3.8 and staying there for quite some time. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching fr directory environments

2015-10-20 Thread Michael Stahnke (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Michael Stahnke commented on  PUP-5398 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Fix regression that reintroduced file watching fr directory environments  
 
 
 
 
 
 
 
 
 
 
I haven't heard that 3.8.3 is the last of the 3.8 series. We haven't announced EOL for it yet, so we might be putting the cart before the horse there. We are obviously putting the vast majority of resources onto newer items though.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching for directory environments

2015-10-20 Thread Eric Sorenson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Sorenson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching for directory environments  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Sorenson 
 
 
 

Summary:
 
 Fix regression that reintroduced file watching  fr  for  directory environments 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5398) Fix regression that reintroduced file watching fr directory environments

2015-10-20 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5398 
 
 
 
  Fix regression that reintroduced file watching fr directory environments  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 
 Thomas Hallgren 
 
 
 

Created:
 

 2015/10/20 7:49 AM 
 
 
 

Fix Versions:
 

 PUP 3.8.4 
 
 
 

Priority:
 
  Major 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
The fix for 

PUP-3389
 introduced a regression that resulted in all manifests being watched for directory environments. This has the effect that directory environments will be evicted when the filetimeout triggers (default 15s). The settings "infinite" therefore does not have the intended effect.  
This also causes performance issues since it means using very inefficient file watching that results in potentially millions of kernel calls to stat files. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment