Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Release Notes Summary: This is part of an enabling service used by puppet server/NC. Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Josh Cooper Fix Version/s: PUP 4.3.3 Fix Version/s: PUP 4.4.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Jeremy Barlow commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ I created a Clojure integration test which exercises this case and added it to the PR for SERVER-1126. Based upon this test passing, I'm satisfied that this issue has been resolved and am moving this to "Resolved". Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg assigned an issue to Jeremy Barlow Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Assignee: Jeremy Barlow Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Sean Griffin assigned an issue to qa Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Sean Griffin Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Sean Griffin updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Sean Griffin QA Risk Assessment: Medium QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ merged to master and updated the release version since it is not sure if there will be a 4.3.3 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Steve Barlow Sprint: Language 2016-01-27 , Language 2016-02-10 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ merged to stable at: 07d483d Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Kylo Ginsberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Ah, our good friend, The Law of Unintended Consequence has struck. This is a regression so it's targeted at stable. Stable is locked for the moment because of our (current, I'm not a fan) puppet-agent de facto release process. Anyhoo, that lock will be lifted real soon now, puppet#stable will be merged to puppet#master (by hand, but we usually do this real soon after a stable merge), and then master will be promoted to 2016.1.x. tldr: wait a few days. Won't be weeks. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Steve Barlow commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ This ticket was dropped into the integration sprint by mistake. Moving it back to Language where it belongs. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Steve Barlow Sprint: Int Language 2016-01-27 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg assigned an issue to Kylo Ginsberg Marked as blocked - is really ready for merge into stable once 4.3.2 work releases the branch for merges. Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Assignee: Henrik Lindberg Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Good to merge now, just waiting for 4.3.2 release before merging. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Thomas Hallgren commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ PR updated. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ We can do that in this ticket. (Ping Thomas Hallgren) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Jeremy Barlow commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Thinking about it, I think we should always deliver the source text. from me. Henrik Lindberg, should we do that as part of this ticket or submit a new one? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title
Henrik Lindberg commented on PUP-5713
Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_
Thinking about it, I think we should always deliver the source text. If it is a literal (or possibly at some point in the future: a constant _expression_ like 1 + 1), we also deliver the evaluated result. This means that single and double quoted strings are preserved in the source attribute, and that quotes are not present in the literal value, and escape sequences have been replaced with the character the sequence represents.
class example($a = "hello\tworld") { ... }
will provide a literal string containing the character sequence: 'h', 'e', 'l', 'l', 'o', '\x9', 'w', 'o', 'r', 'l', 'd' (11 characters), and the source character sequence: '"', 'h', 'e', 'l', 'l', 'o', '\','\t', 'w', 'o', 'r', 'l', 'd', '"' (14 characters).
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title
Jeremy Barlow commented on PUP-5713
Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_
I understand that in the case where there's a variable expressed in the content, like "$::osfamily", that the value would - after the fix were done for this PR - just be returned in default_source as "\"$::osfamily\"", with no value at all for default_literal.
Sorry, hopefully the following example will help make my question more clear.
Starting with the following class definition...
class myclass (String $string_with_single_quotes = 'string with single quotes',
String $string_with_double_quotes = "string with double quotes"
)
{
}
... ClassInformationService.classes_per_environment would produce the following for the parsed params:
[{:name=>"string_with_single_quotes", :type=>"String", :default_literal=>"string with single quotes"},
{:name=>"string_with_double_quotes", :type=>"String", :default_literal=>"string with double quotes"}]}]}}
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Patrick Carlisle commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ I expect to only have the default_source available in this case, if that's the question. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Thomas Hallgren commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Actually, there is no default_literal entry at all when this happen (since it's not a literal). The entry that receives the source for a non literal default _expression_ is named default_source. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title
Jeremy Barlow commented on PUP-5713
Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_
I previously wrote:
If I omit the $ from the default value, just "for os in family ::osfamily" instead, then I get more reasonable looking output:
{"production"=>{"./parse.pp"=>[{:name=>"myclass", :params=>[{:name=>"string_with_expression_default", :type=>"String", :default_literal=>"for os in family ::osfamily"\}]}]}}
At least at doesn't error out. But in this case, the string doesn't have the surrounding double-quotes escaped in the value - so there would be no difference between wrapping the value in single-quotes vs. double-quotes, for example.
... and Henrik Lindberg wrote:
The intent is to deliver simple literal values as values. Anything else should be delivered as a string containing the original pp source.
I interpret this to mean that for the case where simple literal values are used for a parameter's default value that the value for default_literal will just have the body of the string - with the original single-quotes/double-quote characters from the .pp file not preserved in the string content.
This would be different than how the payload for the resource_types API works. In that case, I believe the original value from the .pp file is always included in the payload, so the distinction between single-quotes vs. double-quotes - even for "literal strings" would be preserved in the payload that the Node Classifier would see in PE.
I don't have a problem with that behavior if it is the intention. I'd defer to Patrick Carlisle as to whether this would pose an issue for how the Node Classifier would intend to use this new API.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ A merge of this to stable, has to wait until 4.3.2 has been released. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Ping Thomas Hallgren I added a question on the PR - why is offset nil for some nodes in the AST, and is it always ok to just skip them (that is what the PR does). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ The problem was not that expressions were evaluated. The failure is a bug in the logic that retrieves the source code text. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ The intent is to deliver simple literal values as values. Anything else should be delivered as a string containing the original pp source. The information service should not try to evaluate - except possibly using a static literal evaluator. Anything involving interpolation, function calls, etc. would be delivered as the source of the default _expression_. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Thomas Hallgren Scope Change Category: Found Scope Change Reason: T Story Points: 1 Sprint: Language Triage Int 2016-01-27 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Thomas Hallgren commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Reversing a parsed double quoted string is not trivial since it may contain arbitrary PL expressions. The source of those expressions must be recreated from the AST model which would require a AST-to-source evaluator. AFAIK, we don't have anything like that. I have two questions: How important is it to accurately restore the exact contents of the double quoted string literal? If my assumption is correct and we don't have it, do we want an AST-to-source evaluator for other purposes? Henrik Lindberg, perhaps you can provide some advice here? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Affects Version/s: PUP 4.2.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg commented on PUP-5713 Re: ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Jeremy Barlow Note, that this is scheduled for 4.3.3 which means it will appear in such a maintenance release should we make one, else in 4.4.0. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Sprint: Language Triage Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Fix Version/s: PUP 4.3.3 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5713 ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_ Change By: Henrik Lindberg Issue Type: Task Bug Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5713) ClassInformationService.classes_per_environment errantly evaluates parameter default expression
Title: Message Title
Jeremy Barlow created an issue
Puppet / PUP-5713
ClassInformationService.classes_per_environment errantly evaluates parameter default _expression_
Issue Type:
Task
Assignee:
Unassigned
Created:
2016/01/14 3:11 PM
Priority:
Normal
Reporter:
Jeremy Barlow
In doing some testing against the Puppet::InfoService::ClassInformationService.classes_per_environment() method, I found that the value for :default_source apparently tries to evaluate the _expression_ that it needs to return for a class parameter's default value rather than just retaining the original _expression_ verbatim from the Puppet manifest .pp file, passing that back as a String.
For example, I used a Puppet class with the following content...
class myclass (String $string_with_expression_default = "for os in family $::osfamily")
{
}
