Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Josh Cooper Fix Version/s: PUP 4.3.3 Fix Version/s: PUP 4.4.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Jeremy Barlow commented on PUP-5744 Re: Remove non-JSON safe default_literal objects from classes_per_environment response I created a Clojure integration test which exercises this case and added it to the PR for SERVER-1126. Based upon this test passing, I'm satisfied that this issue has been resolved and am moving this to "Resolved". Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Henrik Lindberg assigned an issue to Jeremy Barlow Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Henrik Lindberg Assignee: Jeremy Barlow Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Sean Griffin assigned an issue to qa Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Sean Griffin Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Thomas Hallgren commented on PUP-5744 Re: Remove non-JSON safe default_literal objects from classes_per_environment response Merged to master at 715124a Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Thomas Hallgren commented on PUP-5744 Re: Remove non-JSON safe default_literal objects from classes_per_environment response Merged to stable at b6f4a28. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Thomas Hallgren Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Patrick Carlisle commented on PUP-5744 Re: Remove non-JSON safe default_literal objects from classes_per_environment response yes, everything should recursively follow the rules or the whole thing is omitted Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Henrik Lindberg commented on PUP-5744 Re: Remove non-JSON safe default_literal objects from classes_per_environment response Jeremy Barlow Yes, any key that is not a string in any hash (recursively) in a parameter's default value _expression_ leads to a default_literal for that parameter to not be included in the result. The source is always there (if the parameter has a default _expression_). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Jeremy Barlow commented on PUP-5744 Re: Remove non-JSON safe default_literal objects from classes_per_environment response I am working on an implementation that will only return a Hash if the keys are Strings. Henrik Lindberg, are you saying then that if any key within any Hash in a parameter's default_value - even a key within a Hash that may be nested under the "value" of a higher-level Hash - is not a "String" that you would omit the entire default_value from the return structure for that parameter? Given the loss of fidelity that could come from otherwise having to coerce a non-String type key into a String for JSON serialization, this sounds like a reasonable thing to do - especially given that we now will still have the ability for the original default_source to be returned for all parameters. Patrick Carlisle, does this sound reasonable to you? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title
Henrik Lindberg commented on PUP-5744
Re: Remove non-JSON safe default_literal objects from classes_per_environment response
Jeremy Barlow What should we do about hashes? In JSON tthe keys must be strings (since JSON hashes are supposed to represent objects, not actual programming language hash maps). In Ruby, when a Ruby Hash is turned into JSON it stringifies all keys. Therefore, the Puppet Hash:
{ 1=>100, 42 => 200}
is changed to JSON hash:
{ "1": 100, "42": 200 }
Stringification takes place for all non String keys including arrays and hashes.
So, in this API, when there is a Puppet Hash or Array as a Hash key, do you want that as a Ruby Hash? (To encode it correctly in JSON it should be an Array of objects with key and value attributes for each hash entry - i.e:
[ { "key": [1, 2, 3], "value": 100 } ... ]
But now, it is no longer "just json"
I am working on an implementation that will only return a Hash if the keys are Strings.
Add Co
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Sean Griffin updated an issue Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Sean Griffin QA Risk Assessment: Medium QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response We have a literal evaluator. It currently accepts reqular expressions as literals. I think we should parameterize the literal evaluator so it can be "pure json" compatible, or include regexp and possibly other puppet literals. Now, I think it only has regexp as non "pure json". In addition to changing the literal evaluator, it needs to be called with the parameter to only accept "pure json". Change By: Henrik Lindberg Story Points: 1 Release Notes Summary: Released as feature in NC / Puppet Server. Sprint: Language 2016-02-10 Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Change By: Henrik Lindberg Fix Version/s: PUP 4.3.3 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5744) Remove non-JSON safe default_literal objects from classes_per_environment response
Title: Message Title Jeremy Barlow created an issue Puppet / PUP-5744 Remove non-JSON safe default_literal objects from classes_per_environment response Issue Type: Improvement Assignee: Unassigned Created: 2016/01/22 11:45 AM Priority: Normal Reporter: Jeremy Barlow Patrick Carlisle, Henrik Lindberg, and I have been talking about how the ClassInformationService.classes_per_environment returns objects for default parameter values when those values are literal. See this comment for a little more background - https://tickets.puppetlabs.com/browse/PUP-4819?focusedCommentId=194138&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-194138. We're intending to serialize the return value from the classes_per_environment method to JSON for presentation in the network wire format. As noted in the linked comment, there are a couple of cases where the default_literal value could be delivered as a Ruby object that doesn't have a direct translation to a JSON data type: Regular expressions (Regexp) Symbols. And the only known instance where a Symbol could be returned is for a value of default (represented as :default) Longer-term, we may be investigating a more lossless (maybe custom?) wire serialization format in lieu of JSON. For the short term, though, we think it would be simplest to just not deliver default_literal objects in any parameter return values when the value cannot be unambiguously translated through JSON. Per the work done in PUP-5713, it will at least be possible in these cases for a cli
