Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet Sorry, not an expert on the rspec helpers and in which order they do things. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Chris Denneen commented on PUP-5889 Re: Add a --strict flag to Puppet Henrik Lindberg Where would that be? require 'puppetlabs_spec_helper/module_spec_helper' Dir[File.absolute_path(File.dirname(__FILE__) + '/support/*.rb')].each do |f| require f end begin require 'spec_helper_local' rescue LoadError => e handle_error(e) end
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet I guess something later is doing a new "initialize settings". Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Chris Denneen commented on PUP-5889 Re: Add a --strict flag to Puppet Henrik Lindberg I know this is old issue but just recently I added the following to my spec testing: if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0 RSpec.configure do |c| c.before :each do Puppet.settings[:strict] = :warning end end end and if I have multiple _spec.rb it seems to work for the first one just the rest it seems to default back to :error If I run the same tests with STRICT_VARIABLES=no they all pass Is there something that would revert this upon subsequent test? Add Comment
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Henrik Lindberg Assignee: Branan Riley Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Branan Riley assigned an issue to Branan Riley Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Branan Riley Assignee: Branan Riley Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson commented on PUP-5889 Re: Add a --strict flag to Puppet aha. thanks. i've never tried turning a boolean flag off, apparently. root@omznoqw8x4hawj6:~# puppet apply -e 'notice($nonesuch)' --no-strict_variables --strict off Notice: Scope(Class[main]): Notice: Compiled catalog for omznoqw8x4hawj6.delivery.puppetlabs.net in environment production in 0.03 seconds Notice: Applied catalog in 0.02 seconds root@omznoqw8x4hawj6:~# puppet apply -e 'notice($nonesuch)' --no-strict_variables Warning: Unknown variable: 'nonesuch'. at line 1:8 Notice: Scope(Class[main]): Notice: Compiled catalog for omznoqw8x4hawj6.delivery.puppetlabs.net in environment production in 0.03 seconds Notice: Applied catalog in 0.01 seconds
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet Eric Thompson You are not doing it quite right (the command line flags are a bit quirky and require correct syntax to take effect): # This is the right way to turn off strict variables and strict puppet apply -e 'notice($nope)' --strict=off --no-strict_variables Notice: Scope(Class[main]): Notice: Compiled catalog for henrik2 in environment production in 0.03 seconds Notice: Applied catalog in 0.01 seconds # with strict variables on puppet apply -e 'notice($nope)' --strict=off --strict_variables Error: Evaluation Error: Unknown variable: 'nope'. at line 1:8 on node henrik2
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson assigned an issue to Unassigned Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson commented on PUP-5889 Re: Add a --strict flag to Puppet validated on ubuntu1404 at master puppet-agent SHA: root@y2lx40198bttgf3:~# puppet apply -e 'notice($nonesuch)' Warning: Unknown variable: 'nonesuch'. at line 1:8 Notice: Scope(Class[main]): Notice: Compiled catalog for y2lx40198bttgf3.delivery.puppetlabs.net in environment production in 0.03 seconds Notice: Applied catalog in 0.01 seconds root@y2lx40198bttgf3:~# puppet apply -e 'notice($nonesuch)' --strict ignore Error: Could not initialize global default settings: Invalid value 'ignore' for parameter strict. Allowed values are 'off', 'warning', 'error' root@y2lx40198bttgf3:~# puppet apply -e 'notice($nonesuch)' --strict off Notice: Scope(Class[main]): Notice:
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Eric Thompson Assignee: qa Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson assigned an issue to qa Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Eric Thompson Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Henrik Lindberg Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Thomas Hallgren commented on PUP-5889 Re: Add a --strict flag to Puppet Merged to master at ddda4a1. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Henrik Lindberg Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet There will be no "on" option. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Thomas Hallgren commented on PUP-5889 Re: Add a --strict flag to Puppet The term "off" implies a boolean flag. Was that considered? If so, is "on" synonym with "warn" or "error"? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet Will add a ticket to change "ignore" to "off" as suggested on the dev mailinglilst. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet Will also add a ticket for the wanted feature that it should be possible to specify strictness per "module path" (i.e. directory with modules). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg commented on PUP-5889 Re: Add a --strict flag to Puppet Ryan Whitehurst Yes that is an accurate description. I can add that I worked on making --string_variables and --strict work together such that if you turn on --strict_variables it will error as it does now, and if it is off, it will follow the level set by --strict. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Eric Thompson QA Risk Assessment: High Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Eric Thompson QA Highest Test Level: Acceptance QA Risk Probability Reason: new feature QA Risk Assessment: High Medium QA Risk Severity Reason: helpful to users, but not a blocker QA Risk Probability: Low QA Risk Severity: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Ryan Whitehurst commented on PUP-5889 Re: Add a --strict flag to Puppet I may refer to versions using both MAJOR.MINOR.PATCH and x.y.z interchangeably. Let me see if I understand this correctly. Currently we have strict_variables, which raises an error when you reference an unassigned variable. We may at some point wish to add other similar strictness checks which may never become required. At times, we need to remove old features for reasons of language consistency, security, code structure, or new features. Before we do this, we need to add deprecation notifications, but we don't necessarily want to clutter output with noise from these notifications. This proposes to add a puppet setting --strict which determines the behavior of these checks. It has three possible values: ignore do not raise any messages for strictness or deprecation checks warn raise messages at the WARNING level for strictness and deprecation checks error raise messages at the ERROR level for strictness and deprecation checks For major releases (e.g., 5.0.0), changes can be introduced which break existing code, such as removing previously deprecated features or syntax. This is unrelated to --strict. For minor releases (e.g., 4.4.0), new strictness and deprecation checks may be added. This could potential cause new compilation failures if using --strict=error, but should only add new warnings if using --strict=warn and make no change if using --strict=ignore. For patch releases (e.g., 4.3.3), no changes to strictness or deprecation checks should occur. Upgrading patch versions should never change the compilation for any value of --strict. Is that an accurate description of the problem and the proposal? Add Comment
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Henrik Lindberg Fix Version/s: PUP 4.x Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Henrik Lindberg Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-5889
Add a --strict flag to Puppet
Change By:
Henrik Lindberg
Add a flag {{\--strict}} to puppet settings. When in effect this will turn on --strict_variables, and will also enable other "helpful" but undesirable behavior. (Each such behavior to be defined in a separate ticket). The semantics of this flag should be:* --strict=ignore; no strictness checks are to be performed, nothing is reported.* --strict=warn; strictness checks are performed, they are reported as warnings, individually configurable warnings follow their own setting (i.e. if they are added to disabled_warnings).-- strict=errors; strictness checks are performed, they are reported as errors and stop the execution. Further configuration to error individually is not supported.When we add this we promise to not change the set of things that lead to warning/error in .z releases, but we reserve the right to do so for .x releases. The idea being is that you can safely accept updates for .z without having to do anything. For .x releases you may need to step back to {{\--strict=warning}} and then correct the problem before going back to {{\--strict=error}}. This scheme should cater to those that are pedantic about following best practises and not using deprecated features while those that only care at major version boundaries can do so in peace without being bothered with lots of deprecation warnings.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5889 Add a --strict flag to Puppet Change By: Henrik Lindberg Sprint: Language 2016-03-09 (Burn CF) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5889) Add a --strict flag to Puppet
Title: Message Title Henrik Lindberg created an issue Puppet / PUP-5889 Add a --strict flag to Puppet Issue Type: New Feature Assignee: Unassigned Created: 2016/02/11 6:34 PM Fix Versions: PUP 4.x Priority: Normal Reporter: Henrik Lindberg Add a flag --strict to puppet settings. When in effect this will turn on --strict_variables, and will also enable other "helpful" but undesirable behavior. (Each such behavior to be defined in a separate ticket). Add Comment
