Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title John Duarte updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: John Duarte QA Risk Assessment Reason: Should be covered by unit tests Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title John Duarte updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: John Duarte QA Risk Assessment: Medium Low Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title John Duarte updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: John Duarte QA Risk Assessment: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title John Duarte updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: John Duarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title John Duarte assigned an issue to John Duarte Puppet / PUP-5962 Restore monkey patch to Symbol Change By: John Duarte Assignee: qa John Duarte Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: Josh Cooper Release Notes Summary: This restores the existing behavior in 4.3.x, so there is no change from end user perspective. Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Henrik Lindberg commented on PUP-5962 Re: Restore monkey patch to Symbol We need a new ticket for the --strict related warning/error for this. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Michael Smith assigned an issue to qa Puppet / PUP-5962 Restore monkey patch to Symbol Change By: Michael Smith Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: Josh Cooper Sprint: Client Triage 2016-03-09 (Burn CF) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: Josh Cooper Fix Version/s: PUP 4.4.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Thomas Hallgren commented on PUP-5962 Re: Restore monkey patch to Symbol David Schmitt, agreed. I'm only somewhat concerned that adding too much logic in a method like that may have a serious impact on performance. Perhaps it would be good to do a simple test to rule that out. One way would be to add a temporary counter to the method, run some typical scenarios, then check how many times the method was called. If it's not millions, then it's probably nothing to worry about. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title David Schmitt commented on PUP-5962 Re: Restore monkey patch to Symbol Thomas Hallgren, I like the possibility of having the patched behavior disabled under a --strict flag as soon as possible. That would make it possible to have a separate (optional) cell in modules' CI to start auditing this quickly. Having a log_once warning when the string/symbol comparison case is hit would also be great for people to be able to address those problems beforehand. Especially native types, providers, and functions are most likely to be impacted by this. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Henrik Lindberg commented on PUP-5962 Re: Restore monkey patch to Symbol It is truly horrible. While trying to be helpful it really messes up badly; if logic treats the symbol :undef as a string - it - will - not - end - well Agree with thomas, do the monkey patch but also warn (under control of --strict). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title
Thomas Hallgren commented on PUP-5962
Re: Restore monkey patch to Symbol
Changing the behavior of the ruby runtime to accommodate for problems with mixed strings/symbols is the wrong way to go IMO. Such ambiguities should be addressed directly instead (because we need to get rid of them). In the long run they shouldn't be allowed at all. Why not using the new --strict flag (PUP-5889) to address this? Let's change the code where it's needed and issue a warning (to be turned into an error in 5.0).
A solution for the given example could be to provide a block comparing using to_s when sorting.
attr.sort! { |a,b| a.to_s <=> b.to_s }
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Josh Cooper commented on PUP-5962 Re: Restore monkey patch to Symbol Ruby 1.9.3 has support for Symbol#<=>, however, their implementation returns nil if the thing we're comparing against is not also a symbol. And Ruby 2.1.x keeps the same logic. irb(main):003:0> :a <=> 'a' => nil Our monkey patch (and the one in plist) was more lenient. It always called other.to_s and compared that to self.to_s, so you could do the following in puppet 4.3.0: irb(main):003:0> require 'puppet' => true irb(main):004:0> require 'plist' => true irb(main):005:0> :a <=> 'a' => 0
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Henrik Lindberg commented on PUP-5962 Re: Restore monkey patch to Symbol Not sure I follow... Are you saying that Ruby 1.9.3 has support for Symbol. <=> ? If so, and since Puppet 4.x does not support Ruby 1.8.7 why do we need the monkey patch? Or, are you saying the Ruby 1.9.3 does not support it? If so then it is clear that the patch needs to go back in, and that it needs to go in before 4.4.0 is released. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-5962
Restore monkey patch to Symbol
Change By:
Josh Cooper
It pains me immensely to pen a ticket summary like this one, but c'est la vie.Backstory:* back in 2011, for http://projects.puppetlabs.com/issues/5466, we added a monkey patch to add a {{<=>}} method to {{Symbol}} to allow sorting* in 2012, as part of cleanup the monkey patch was made conditional on whether that version of Ruby already had a {{<=>}} method for {{Symbol}}. As it turns out, ruby 1.8.7 lacks that method, but ruby 1.9.3+ have that method (but a different implementation than our monkey patch) .* in PUP-4330, we vendored the plist gem into puppet. This gem happens to include much the same patch (but without the conditional logic).* in PUP-1455 (not yet released), we unvendored the plist gem, thus effectively removing that monkey patch for all rubies currently supported.This broke one spec test in the puppet-server test suite, which was how this was discovered. However, given how low-level this is, the potential for breakage in modules seems pretty high, so the prudent approach here is to restore the monkey patch.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Michael Smith updated an issue Puppet / PUP-5962 Restore monkey patch to Symbol Change By: Michael Smith Sprint: Client Triage Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Adrien Thebo commented on PUP-5962 Re: Restore monkey patch to Symbol ;_; Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title
Kylo Ginsberg updated an issue
Puppet / PUP-5962
Restore monkey patch to Symbol
Change By:
Kylo Ginsberg
It pains me immensely to pen a ticket summary like this one, but c'est la vie.Backstory:* back in 2011, for http://projects.puppetlabs.com/issues/5466, we added a monkey patch to add a {{<=>}} method to {{Symbol}} to allow sorting* in 2012, as part of cleanup the monkey patch was made condition conditional on whether that version of Ruby already had a {{<=>}} method for {{Symbol}}. As it turns out, ruby 1.8.7 lacks that method, but ruby 1.9.3+ have that method.* in PUP-4330, we vendored the plist gem into puppet. This gem happens to include much the same patch (but without the conditional logic).* in PUP-1455 (not yet released), we unvendored the plist gem, thus effectively removing that monkey patch for all rubies currently supported.This broke one spec test in the puppet-server test suite, which was how this was discovered. However, given how low-level this is, the potential for breakage in modules seems pretty high, so the prudent approach here is to restore the monkey patch.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit
Jira (PUP-5962) Restore monkey patch to Symbol
Title: Message Title Kylo Ginsberg created an issue Puppet / PUP-5962 Restore monkey patch to Symbol Issue Type: Bug Assignee: Unassigned Created: 2016/02/23 1:01 PM Priority: Normal Reporter: Kylo Ginsberg It pains me immensely to pen a ticket summary like this one, but c'est la vie. Backstory: back in 2011, for http://projects.puppetlabs.com/issues/5466, we added a monkey patch to add a <=> method to Symbol to allow sorting in 2012, as part of cleanup the monkey patch was made condition on whether that version of Ruby already had a <=> method for Symbol. As it turns out, ruby 1.8.7 lacks that method, but ruby 1.9.3+ have that method. in PUP-4330 , we vendored the plist gem into puppet. This gem happens to include much the same patch (but without the conditional logic). in PUP-1455 (not yet released), we unvendored the plist gem, thus effectively removing that monkey patch for all rubies currently supported.
