Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Henrik Lindberg Release Notes Summary: The monkey patch of Range#intersection to handle SemVer range matches have now been removed. This only affects those that have written version compare logic in Ruby. Release Notes: Deprecation Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title John Duarte updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: John Duarte QA Risk Assessment: No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Kenn Hussey commented on PUP-5975 Re: Remove Range#intersection monkey patch Henrik Lindberg please provide release notes for this issue, if applicable. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title John Duarte commented on PUP-5975 Re: Remove Range#intersection monkey patch This passed CI as a component of puppet-agent at SHA e145b29d129b0e5ad06f05dcf987934b590f28dc Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Henrik Lindberg Sprint: PDE 2017-05-03 , PDE 2017-05-31 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5975 Re: Remove Range#intersection monkey patch Excellent - I see we have PUP 7431 in our sprint and you got push rights. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Henrik Lindberg Sprint: PDE 2017-05-03 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Thomas Hallgren commented on PUP-5975 Re: Remove Range#intersection monkey patch I'm confident, it will be, as soon as semantic_puppet 1.0 is released and we've updated the vendored version PUP-7431. Right now I'm not 100% sure. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5975 Re: Remove Range#intersection monkey patch Thomas Hallgren I lost track of where we are with respect to support for SemVer and the logic in PMT. Is it safe to use drop the monkey patch and and modify the test in semver_spec.rb ? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5975 Re: Remove Range#intersection monkey patch With the monkey patch removed - there are three failures: rspec ./spec/unit/util/monkey_patches_spec.rb:91 # Range should return expected ranges for iterable things rspec ./spec/unit/util/monkey_patches_spec.rb:115 # Range should return expected ranges for noniterable things rspec ./spec/unit/semver_spec.rb:95 # SemVer::[] should produce expected ranges Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5975 Re: Remove Range#intersection monkey patch Geoff Nichols Yes, we can take this, we have other SemVer related things on our plate as well. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Geoff Nichols commented on PUP-5975 Re: Remove Range#intersection monkey patch Henrik Lindberg, is this something that PDE would address for Puppet 5.0? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Geoff Nichols Sprint: Agent Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Geoff Nichols Team: Agent Puppet Developer Experience Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Geoff Nichols Sprint: Agent Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Geoff Nichols Team: Agent Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Josh Cooper commented on PUP-5975 Re: Remove Range#intersection monkey patch I'm not sure if we need a deprecation warning. I assume the only affected code is in PMT when it does module version comparison, but the monkey patch could affect custom type/provider logic that compare versions? Might also be interesting to see if tests still pass with the monkey patch removed. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5975 Re: Remove Range#intersection monkey patch If you ended up here wondering what to do when needing to do version / range comparisons - please see PUP-6221 - Add Support for SemVer/SemVerRange in the Puppet Type system. (Which includes match/range operations and more). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5975 Re: Remove Range#intersection monkey patch Does this require a deprecation warning or is the expected work all internal to puppet? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Change By: Henrik Lindberg Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5975) Remove Range#intersection monkey patch
Title: Message Title Josh Cooper created an issue Puppet / PUP-5975 Remove Range#intersection monkey patch Issue Type: Bug Assignee: Unassigned Created: 2016/02/24 9:14 PM Priority: Normal Reporter: Josh Cooper Range#intersection was monkey patched in b6d052e7 so that semver ranges could be compared for the PMT This should be removed and handled in the code that actually cares about comparing semver strings. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
