Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg commented on PUP-6058 Re: Duplicate resource error on indirectly included class I am sorry, are you saying the problem is that there is no error when evaluating the attached test.pp ? If so, how did you expect that to fail and why? I had attached the working test case I assume that is a reference to the attached "test.pp" , and not the description (which I may have mangled). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title
Henrik Lindberg commented on PUP-6058
Re: Duplicate resource error on indirectly included class
Sounds like you are doing something like this twice:
class { a:
s => 'from b',
}
Which you cannot, even if the values are identical.
Will close this as cannot reproduce.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks commented on PUP-6058 Re: Duplicate resource error on indirectly included class Sorry, I realized a mistake and updated my comment. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks commented on PUP-6058 Re: Duplicate resource error on indirectly included class I don't expect test.pp to fail; test.pp works. The code in the description fails. It's not an issue of a resource _expression_ and an include (in either order); the class is included twice, both times via include. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg commented on PUP-6058 Re: Duplicate resource error on indirectly included class If the issue is that it is possible to first declare a class using a resource _expression_, and then using include (i.e. without parameters), then that is expected to work without errors (whereas the other way around is not allowed). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg commented on PUP-6058 Re: Duplicate resource error on indirectly included class Ok, thanks. It would help if you could put together a small reproducer and attach that. Just to be certain we are both running the same thing. My attempt at reproducing this failed. (As noted above). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks commented on PUP-6058 Re: Duplicate resource error on indirectly included class I don't think I'll be able to create a small test case… feel free to close this. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg assigned an issue to Daniel Parks Puppet / PUP-6058 Duplicate resource error on indirectly included class Change By: Henrik Lindberg Assignee: Henrik Lindberg Daniel Parks Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks assigned an issue to Henrik Lindberg Puppet / PUP-6058 Duplicate resource error on indirectly included class Change By: Daniel Parks Assignee: Daniel Parks Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks commented on PUP-6058 Re: Duplicate resource error on indirectly included class I had attached the working test case to demonstrate that a minimal test case I would have expected to fail did not. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks commented on PUP-6058 Re: Duplicate resource error on indirectly included class I haven't actually tried your code (I can), but to be clear, the test case I attached does not fail. I have been unable to find a minimal test case; it only occurs in production. I filed this bug because I wanted to track it, and because I sometimes get bugs that are not reproducible but I can still fix. Also, there are no nested classes involved. I don't think we use them at all in our codebase. I think it is entirely reasonable to close this with Cannot Reproduce. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg assigned an issue to Daniel Parks Puppet / PUP-6058 Duplicate resource error on indirectly included class Change By: Henrik Lindberg Assignee: Henrik Lindberg Daniel Parks Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title
Henrik Lindberg commented on PUP-6058
Re: Duplicate resource error on indirectly included class
Daniel Parks I tried the attached test.pp on 4.4.0, and I tried it with moving the b class into the a class. i.e
class a ( $s ) {
notify { "a notice: ${s}": }
class b {
class { a:
s => 'from b',
}
}
}
define c {
include a::b
notify {"c: ${name}": }
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg commented on PUP-6058 Re: Duplicate resource error on indirectly included class Doh, I read it wrong Too much going on at the same time. Rereading. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks commented on PUP-6058 Re: Duplicate resource error on indirectly included class I think you are reading it wrong. Either that or I've become terribly confused about syntax. That is a resource style include of the class. We do it that way whenever we need to pass parameters. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Daniel Parks assigned an issue to Henrik Lindberg Puppet / PUP-6058 Duplicate resource error on indirectly included class Change By: Daniel Parks Assignee: Daniel Parks Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg assigned an issue to Daniel Parks Puppet / PUP-6058 Duplicate resource error on indirectly included class Change By: Henrik Lindberg Assignee: Daniel Parks Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title
Henrik Lindberg commented on PUP-6058
Re: Duplicate resource error on indirectly included class
Have never seen this pattern before:
class profile::mysql::client {
class { '::mysql::client': ... }
}
What did you expect that to do? Create the inner class with name "::profile::mysql::client::mysql::client" or name "::mysql::client" ?
IMO, nested classes is just name spacing, it should not be allowed to break out of that namespace with '::'. I would expect an error that that is illegal (but I don't think we are validating that). Irrespective, it is best to not use nested classes.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs"
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6058 Duplicate resource error on indirectly included class Change By: Henrik Lindberg Sprint: Language Triage Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title
Daniel Parks commented on PUP-6058
Re: Duplicate resource error on indirectly included class
Moving include ::profile::mysql::client out of the defined type and into the classes fixes the problem. In other words, each outer class now looks like:
class . . . {
include ::profile::mysql::client
::profile::mysql::rds_client {"${name}_rds_${::stage}":
. . .
}
}
Add Comment
Jira (PUP-6058) Duplicate resource error on indirectly included class
Title: Message Title
Daniel Parks created an issue
Puppet / PUP-6058
Duplicate resource error on indirectly included class
Issue Type:
Bug
Affects Versions:
PUP 4.2.3
Assignee:
Unassigned
Attachments:
test.pp
Created:
2016/03/14 11:37 PM
Environment:
Agent: 4.2.3 Master: PE 2015.2
Priority:
Normal
Reporter:
Daniel Parks
Class[Mysql::Client] is already declared; cannot redeclare at .../site/profile/manifests/mysql/client.pp:6 at .../site/profile/manifests/mysql/client.pp:6:3
class profile::mysql::client {
